Commit Graph

443 Commits

Author SHA1 Message Date
Zach Anderson a9ab8f4e7d [GN] Hack around Dart 2 application_snapshot deps issue
For Dart 2 snapshots, application_snapshots() hardcodes a deps on
//utils/kernel-service:copy_kernel_service_snapshot

related #33167

Change-Id: I9a598e83a3e8ebb9a27bfe83132f3a957f2fea0e
Reviewed-on: https://dart-review.googlesource.com/56161
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-05-22 17:47:16 +00:00
Nate Bosch 2ff2af7921 Allow running pub with --preview-dart-2
- Make a snapshot in Dart 2 mode
- Check for the VM argument `--preview-dart-2` and run the correct
  snapshot

Towards fixing https://github.com/dart-lang/sdk/issues/32188

Change-Id: I56d5e7f268ff40b80783fae571981705536280f2
Reviewed-on: https://dart-review.googlesource.com/54743
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-05-18 20:27:29 +00:00
Ryan Macnak 61b15fede8 [build] Remove unnecessary inputs from uses of application_snapshot.
These dependencies are tracked via a depfile generated along with the snapshot.

Change-Id: I4245a982212a5aff28aea8456d0219808df54af0
Reviewed-on: https://dart-review.googlesource.com/51245
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-04-16 21:13:09 +00:00
Zach Anderson 0394d3a0cf [infra] Begin removing gyp
This CL begins removing gyp from Dart's tree.

Removing gyp will go in three stages:
1. Remove unused .gyp and .gypi files.
2. Translate *_sources.gypi files to *_sources.gni files
3. Remove //third_party/gyp from DEPS

This CL is stage 1.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2992593002 .
2017-08-04 22:19:35 -07:00
Ryan Macnak 26a364f998 Support spawnUri in app snapshots.
- Don't mark core_isolate_snapshot_buffer as a const pointer.
 - Update app snapshots without code to not rewrite the VM isolate snapshot, as already done by app snapshots with code.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2637193002 .
2017-01-17 15:59:41 -08:00
Ryan Macnak 12a3699301 Revert "Support spawnUri in app snapshots."
Failures on IA32.

This reverts commit c6ecfe1746.

Review-Url: https://codereview.chromium.org/2631893002 .
2017-01-13 15:52:36 -08:00
Ryan Macnak c6ecfe1746 Support spawnUri in app snapshots.
Don't mark core_isolate_snapshot_buffer as a const pointer.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2623423007 .
2017-01-13 15:18:27 -08:00
Ryan Macnak f89056f6cd Revert "Support spawnUri in app snapshots."
This reverts commit 593d4504b0.
This reverts commit 113aa64b98.
This reverts commit 422afa2ead.

Review-Url: https://codereview.chromium.org/2633543003 .
2017-01-13 11:02:44 -08:00
Ryan Macnak 593d4504b0 Support spawnUri in app snapshots.
Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2628283002 .
2017-01-13 10:37:51 -08:00
Ryan Macnak 5062baffb6 Revert pub to script snapshots in the GN build. Fixes #28346.
App snapshots do not yet support spawnUri (issue #28368).

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2621423004 .
2017-01-12 13:07:29 -08:00
Zachary Anderson 7f55ad8b86 Fuchsia: Allows building the full SDK for host and target.
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2571713004 .
2016-12-13 13:02:52 -08:00
Zachary Anderson 90d3962ca3 Don't depend on dart_bootstrap if there is a usable prebuilt sdk
Also replace invoke_dart() with compiled_action(), and some other
cleanups.

fixes #27781

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2493833002 .
2016-11-10 11:16:24 -08:00
Zachary Anderson c1313a5ec7 Format GN files and add a presubmit check that GN is properly formatted
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2451613005 .
2016-10-26 08:50:54 -07:00
Ryan Macnak af7bf4dab0 GN: Build the SDK with app snapshots instead of script snapshots.
R=zra@google.com

Review URL: https://codereview.chromium.org/2442513003 .
2016-10-21 17:40:21 -07:00
Zachary Anderson 7c784cea9f Linux create_sdk GN build for host
This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2379803002 .
2016-09-29 13:23:00 -07:00
William Hesse 79b682b885 Add explicit package spec to snapshot build steps
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2372573002 .
2016-09-26 15:52:31 +02:00
William Hesse 0695b1db3a Remove package root target and support scripts
BUG=https://github.com/dart-lang/sdk/issues/23565
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2346163005 .
2016-09-20 13:32:50 +02:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d3e356ca75be8aeff3efde5df946d746b9f8352

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: https://github.com/dart-lang/sdk/commit/6d238ba197c8bda71afe790f16f6e9adaf7abd13
2016-09-16 15:03:18 +02:00
William Hesse 6d238ba197 Revert "Use checked-in .package file for building and testing"
This reverts commit 5d3e356ca7.

BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2340813004 .
2016-09-15 15:46:49 +02:00
William Hesse 5d3e356ca7 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
2016-09-15 14:50:30 +02:00
Sigmund Cherem b18c5a3e7c sdk files reorganization to make dart2js a proper package
BUG=
R=brianwilkerson@google.com, floitsch@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1212513002.
2015-06-29 10:21:14 -07:00
Rico Wind f3c6339206 Switch over testing pub seperately from the the normal packages
This will call a new test script that Natalie will fill in the blanks of for pub testing.

This also moves pub from third_party/pkg_tested into third_party/pkg.

The corresponding changes to the buildbot is here:
http://src.chromium.org/viewvc/chrome?revision=295555&view=revision

R=nweiz@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1166093002.
2015-06-09 08:12:51 +02:00
Natalie Weizenbaum 3d8c06c4e9 Start pulling pub from its own repo.
Pub now lives in third_party/pkg/pub (it's in pkg to make it possible to import
using "package:" imports).

R=ricow@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//1165473002
2015-05-29 14:50:18 -07:00
Natalie Weizenbaum e7a1c3c585 Remove the core library stubbing infrastructure.
This hasn't been used in a long time. It's just clutter now.

R=ahe@google.com

Review URL: https://codereview.chromium.org//1134583005
2015-05-18 12:42:36 -07:00
nweiz@google.com c8de060c54 Revert "Revert "Use native async/await support in pub.""
The VM now fully supports all the weird async stuff pub is doing, and all the
tests pass with native async/await!

Previous CLs were r43484 and r43483.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//937243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43897 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:28:54 +00:00
nweiz@google.com bbe0d9325c Revert "Use native async/await support in pub."
This caused SDK compilation issues that may have obscured pub test failures as
well.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//887223007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43484 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:15:44 +00:00
nweiz@google.com 1835c63d0a Use native async/await support in pub.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//896623005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43483 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 20:45:49 +00:00
nweiz@google.com 80e6b5be2c Remove the http package from the repo.
This also does away with the pub_packages build target.

R=ahe@google.com, rnystrom@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//810223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42469 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-18 19:04:04 +00:00
rnystrom@google.com 6cc5c28c66 Make the pub build step depend on the async/await compiled sources.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//557083006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40125 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 22:39:49 +00:00
rnystrom@google.com 17c1642748 Store the async-await compiled pub code directly in the repo.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//557563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40041 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 16:55:16 +00:00
rnystrom@google.com 5167458d68 Skeleton code for running the forthcoming async/await compiler on pub.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//472173004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39530 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-25 20:38:58 +00:00
nweiz@google.com b92dcc79cc Code review for r38255
R=ricow@google.com

Review URL: https://codereview.chromium.org//468623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39215 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 19:18:30 +00:00
nweiz@google.com f067ad0dc8 Build core library stubs as part of building the SDK.
BUG=38265
R=floitsch@google.com

Review URL: https://codereview.chromium.org//392073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38302 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-16 19:11:14 +00:00
nweiz@google.com d8663eeeda Create a separate packages directory for running pub.
Once issue 6943 is fixed, the http package will start using pub's
cross-platform library support to work with both dart:io and
dart:html. However, this package is also used *within* pub, so we need
a way for pub to import it that doesn't require it being run through
pub.

This change supports this by stripping out and dart:html imports from
the http package and creating a special packages directory only used
by pub that uses this modified version.

BUG=20068
R=floitsch@google.com

Review URL: https://codereview.chromium.org//397773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38255 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 20:28:08 +00:00
ricow@google.com dcf45d898e Fix mac gyp generation by moving target to seperate file.
R=whesse@google.com

Review URL: https://codereview.chromium.org//247273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35256 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 13:01:48 +00:00
ricow@google.com 5080e18fc4 Create targets for dart2js files, pub files, pkg files.
We are seeing issues on mac 10.7 where the list of inputPaths in xcode files becomes to long (this is also dependent depth of your build directory).
The build silently fails without giving any error.

BUG:18333

Also see:
http://build.chromium.org/p/client.dart/builders/dart2js-safari-mac10.7-1-3-be/builds/4640/steps/Build%20SDK/logs/stdio

R=ahe@google.com

Review URL: https://codereview.chromium.org//247073003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35255 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 11:34:13 +00:00
asiva@google.com a12382dc22 Fix for issue 11112 align flags to formats used by other tools.
R=hausner@google.com

Review URL: https://codereview.chromium.org//16673006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23831 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 21:57:49 +00:00
nweiz@google.com 1dd302a00b Add a gitignore for pub's gyp outputs.
BUG=10191

Review URL: https://codereview.chromium.org//14081027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21992 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 22:19:21 +00:00
nweiz@google.com 8ce1364479 Have pub.gyp depend on the packages symlink directory.
TBR

Review URL: https://codereview.chromium.org//14474017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21981 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 20:53:20 +00:00
nweiz@google.com cc6e2f7b93 Put a snapshot of pub in the SDK.
BUG=9117

Review URL: https://codereview.chromium.org//13966011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21979 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 20:43:39 +00:00
nweiz@google.com 24213beff5 Move pub into sdk/lib/_internal.
This also converts pub to a more package-like layout, which will help in the
eventual exposing of pub internals as a library. Since pub's sources are now in
lib/src, this also makes them importable from the tests and entrypoint using
"package:" imports.

BUG=6619

Review URL: https://codereview.chromium.org//14297021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21907 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 21:44:26 +00:00
rnystrom@google.com 6c9cc582ec Use the cached pubspec if possible for describing hosted packages.
BUG=https://code.google.com/p/dart/issues/detail?id=9027

Review URL: https://codereview.chromium.org//14241005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21777 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 22:29:44 +00:00
rnystrom@google.com 76cc853f06 Disable SDK constraint checking on bleeding edge.
BUG=

Review URL: https://codereview.chromium.org//14247026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21773 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 21:13:08 +00:00
nweiz@google.com 89cb31e4c4 Fix some warnings in pub and pkg packages.
Review URL: https://codereview.chromium.org//13817008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21701 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 20:24:47 +00:00
rnystrom@google.com a204feb031 Fix type annotation.
Review URL: https://codereview.chromium.org//13933030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21700 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 20:12:59 +00:00
nweiz@google.com da643164c5 Migrate pub away from throwing strings.
This also makes it a little more intelligent about which errors it prints what
information for.

BUG=9921

Review URL: https://codereview.chromium.org//14253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21698 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 20:08:20 +00:00
rnystrom@google.com fe71916d71 Switch to backtracking solver.
BUG=https://code.google.com/p/dart/issues/detail?id=9260

Review URL: https://codereview.chromium.org//14232023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21690 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 18:32:20 +00:00
rnystrom@google.com ff4ef8885b Select packages that match SDK constraints.
BUG=https://code.google.com/p/dart/issues/detail?id=9216

Review URL: https://codereview.chromium.org//14298006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21659 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 23:14:40 +00:00
rnystrom@google.com a2b229b4a0 Revise based on feedback from previous patch.
Review URL: https://codereview.chromium.org//14249006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21644 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 18:36:31 +00:00
rnystrom@google.com 91edf93383 Disable backtracking solver.
Review URL: https://codereview.chromium.org//14308004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21572 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-16 20:20:35 +00:00