Commit Graph

14 Commits

Author SHA1 Message Date
Bob Nystrom ba2e4aff24 Some minor clean-up in test.dart.
- Fix fuzzy arrow errors.
- Default the Dart repo URI so it doesn't always need to be explicitly
  set.
- Run dartfmt on everything.
- Move some members out of the garbage bin "TestUtils" class:
  - Move the stuff around the Dart repo directory to a new Repository
    class.
  - Move absolute() into Path where it belongs.
  - Move workingDirectory in Path since it is a Path.
  - Delete the random number stuff since it was apparently unused.

Change-Id: I3dab3a4f1713b7a749e64b6776149d05a0ce1b69
Reviewed-on: https://dart-review.googlesource.com/14502
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-19 19:05:58 +00:00
Bob Nystrom 7ce978bf91 Tighten types in test.dart even more.
This removes all implicit casts and many implicit uses of dynamic. It
adds a gratuitous number of explicit "as" casts and arguably makes the
code worse.

This is an interim step towards replacing the big configuration map
with an actual typed object. These "as" casts should help catch places
where the configuration object is being used and where the code will
need to be changed to use a new object.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2903703002 .
2017-05-30 14:02:24 -07:00
Jacob Richman 119b2d58ce Format all files under tools and utils directory.
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2827793002 .
2017-04-20 09:08:31 -07:00
ricow@google.com af21d74d2d Fix safari browser to use Future.value
Also correct type errors found by the analyzer.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18089005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24532 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 17:07:17 +00:00
sgjesse@google.com d6955d176c Reapply "Update the test runner to use the new dart:io API"
This reverts r20031.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12751005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20070 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 11:13:39 +00:00
sgjesse@google.com f5270bf202 Revert "Update the test runner to use the new dart:io API" again
This reverts r20027 and r20029

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12475010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20031 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 15:38:18 +00:00
sgjesse@google.com fdaca2fe83 Revert "Update the test runner to use the new dart:io API" again
This reapplies r20004 and r20008 and fixes a HTTP server issue.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12431020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20027 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 15:24:36 +00:00
sgjesse@google.com 3e2ffb4394 Revert "Update the test runner to use the new dart:io API" again
This reverts r20004 and r20008.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12559013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20009 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 12:13:37 +00:00
sgjesse@google.com db7821cdf3 Reapply "Update the test runner to use the new dart:io API"
The Linux binary will work on the bots. Fixed a number of issues.

The new binaries are from r19850.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12608007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20004 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 11:39:20 +00:00
sgjesse@google.com 78403ce605 Revert "Update the test runner to use the new dart:io API"
This reverts commit r19987.

The included binaries did not work on the bots due to a glibc version issue.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12864003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19988 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 08:08:56 +00:00
sgjesse@google.com 7ff44f77ac Update the test runner to use the new dart:io API
The new binaries are from r19850.

R=whesse@google.com, ager@google.com, ricow@google.com, kustermann@google.com

BUG=

Review URL: https://codereview.chromium.org//12417004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19987 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 07:54:07 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere.
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
kustermann@google.com d2c575c0b0 Create generated tests inside the build directory
Patch Set 1 is a revert of r18295.

Review URL: https://codereview.chromium.org//12223074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18802 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 08:10:37 +00:00
efortuna@google.com 0345368d65 Unbreak local browser testing.
BUG=

Review URL: https://codereview.chromium.org//11931025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17176 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 00:35:23 +00:00