Commit Graph

427 Commits

Author SHA1 Message Date
Alexander Thomas ff8100d1e3 [infra] Add dartk reload/rollback configurations to test matrix (#33126)
Change-Id: Iedff74fbdfd04165755f2609333742f62e48f18f
Reviewed-on: https://dart-review.googlesource.com/56114
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-05-31 10:48:23 +00:00
Alexander Thomas d28c5499fc [infra] Add support for app_jitk compiler to test.py (#33126)
* Add app_jitk configuration to test matrix.
* Skip it on non-Dart 2 test suites.

Change-Id: I05f75dbbd33d34a4acf4df1fe63104933d39d2fe
Reviewed-on: https://dart-review.googlesource.com/56113
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-05-28 11:54:56 +00:00
Alexander Thomas 96cfc632bb [infra] Use a less specific browser version that works across platforms
TBR=whesse@google.com

Change-Id: Ieff493c187dc5da5dbee49887454cf25e1dc6eef
Reviewed-on: https://dart-review.googlesource.com/56115
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-22 21:11:03 +00:00
Alexander Thomas 2a8eb8089d [infra] Specify chrome version used by builds running on the test matrix
Prepares the test matrix for the corresponding recipe change:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1064632

Change-Id: I21d380f6ad452e3eca6e6f20133297d31347872c
Reviewed-on: https://dart-review.googlesource.com/56109
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-05-22 16:17:34 +00:00
Alexander Thomas 4d22c0de58 [infra] Improve cycle time of dart2js builders
* Remove co19_2 from file sets for now.
* Skip extremely slow test.
* Remove redundant build target from test matrix.

#33150

Change-Id: Ib17d2e7438dc2ab473e751f1d79c617cbc26275d
Reviewed-on: https://dart-review.googlesource.com/55661
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-05-17 10:21:23 +00:00
Alexander Thomas 2d5c1064b9 [infra] Add .bat to pub command on Windows
#32656

Change-Id: I3a34bf2c81676eea0ab112a8aad701962590a6c3
Reviewed-on: https://dart-review.googlesource.com/55165
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-05-15 12:50:32 +00:00
Alexander Thomas 243f3e5333 [infra] Add basic pub integration test
Closes #32656

Change-Id: Id3646e7b9567e6f60e449a90c355d3e535ac2a6a
Reviewed-on: https://dart-review.googlesource.com/51661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-05-15 07:09:58 +00:00
William Hesse 006fda374b Update test matrix with correct path to dart on Mac OS
Change-Id: Ie50148e5519bd4695d547727bb2fdaf3263f01d1
Reviewed-on: https://dart-review.googlesource.com/49641
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-05 11:19:12 +00:00
William Hesse 1c913801a6 Add third_party packages to dart2js testing shards
The http_server in the test.py scripts uses package_resolver, which
uses 10 packages from third_party/pkg and third_party/pkg_tested.

Change-Id: I1e9ca660b9bd0a6270bcc8e4121da6a3bf9713bd
Reviewed-on: https://dart-review.googlesource.com/47781
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-23 12:56:06 +00:00
Zach Anderson aac5d04198 [infra] Add optimization_counter_threshold builder tag to the test matrix
related #32619

Change-Id: I0fc20f21cf3a6e231e0f3d962f139fd072acf3ab
Reviewed-on: https://dart-review.googlesource.com/47540
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-03-21 18:39:12 +00:00
William Hesse bc3b0540f7 Add hash for downloading Linux Chrome to tools/bots/browsers.
Change-Id: Iafacb0d2f1753019878927462e2edd8dfc18b6fe
Reviewed-on: https://dart-review.googlesource.com/45780
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-16 10:35:11 +00:00
Alexander Thomas c8d044e27d [infra] Remove non-strong mode vm kernel tests steps from test matrix
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: I161b13bff4d6b4464d83eb39da9cb8e6d4051374
Reviewed-on: https://dart-review.googlesource.com/46142
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-03-15 16:53:06 +00:00
Alexander Thomas 5c90b1fd98 [infra] Add vm-kernel-legacy builder to the test matrix
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: Ia9829fc106162b161e9e31bc918feebc691b3621
Reviewed-on: https://dart-review.googlesource.com/46742
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-03-15 14:31:13 +00:00
Alexander Thomas 019dae1904 [infra] Remove front end unit tests from other builders
The new front end builders will continue to run them.

Change-Id: Iffd5af76bd3a082256ea4fb146981737462938f9
Reviewed-on: https://dart-review.googlesource.com/46042
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-13 12:40:39 +00:00
Alexander Markov ef80524b4f [benchmarks trybot] Add precompiler_entry_points.json
Change-Id: I3edbf7b20f3ab7afce89d7adabd537a6e47133d0
Reviewed-on: https://dart-review.googlesource.com/46005
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-03-12 22:11:10 +00:00
Jonas Termansen e067f7fdfa The dart-dfe target is no longer being benchmarked.
Change-Id: I9188362c0f62e4df50a0b8262d03a183c615eedb
Reviewed-on: https://dart-review.googlesource.com/45703
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2018-03-09 13:31:08 +00:00
Sigmund Cherem d059e97974 Add platform.dill files to the hostchecked try bots.
This change is needed before we turn on the CFE by default in dart2js.

R=whesse@google.com,athom@google.com

Change-Id: I2868d2dcef82d95456a56e809fe90e28dc698437
Reviewed-on: https://dart-review.googlesource.com/45640
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-08 17:29:47 +00:00
Paul Berry 440b58d644 Start running analyzer tests with --preview-dart-2.
The changes to the CQ bot should take effect immediately.  The changes
to the other bots will take effect once those bots are switched over
to use the test matrix.

Change-Id: Ibfe59817a11f730fd1847cdc60b3244b4a71a480
Reviewed-on: https://dart-review.googlesource.com/45300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-03-07 15:04:33 +00:00
Alexander Thomas d0eb2d63e8 [infra] Add front-end builder to test matrix
#32123

Change-Id: I996ed57edc78f46aac6fa65a45e07500ad3758a0
Reviewed-on: https://dart-review.googlesource.com/44160
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-05 14:53:03 +00:00
Alexander Thomas 926ef7d742 [infra] Remove dart2js jsshell builder from the test matrix
Change-Id: I850f0d1d75e030da71593e56292fe986e15cc846
Reviewed-on: https://dart-review.googlesource.com/44461
Reviewed-by: William Hesse <whesse@google.com>
2018-03-01 11:56:39 +00:00
Alexander Thomas 990fbea399 [infra] Update analyzer builders in the test matrix
Change-Id: I6a1b9533700646c0ab9b264063e31d6fd671dee7
Reviewed-on: https://dart-review.googlesource.com/44241
Reviewed-by: Paul Berry <paulberry@google.com>
2018-03-01 09:58:24 +00:00
Sigmund Cherem d0c3e48a5f Add dart2js-with-kernel to the CQ
This is blocked on first landing the change to the dart2js_swarming recipe.

R=whesse@google.com,athom@google.com

Change-Id: Id7c26499cbb3d5337d6c72c10a688dd22d60dd78
Reviewed-on: https://dart-review.googlesource.com/41580
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-02-16 23:46:57 +00:00
Alexander Thomas 7702816194 [infra] Add builder tag for vm-kernel-optcounter-threshold builder
#31838

Change-Id: I46e681518b569905a8b2b30f7add53e69aeef446
Reviewed-on: https://dart-review.googlesource.com/40742
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-13 12:32:11 +00:00
Alexander Thomas 6f58ab48e9 [infra] Re-enable sharding on vm-kernel/vm-kernel-precomp builders
* Send fewer files to shards by not including co19_2 in the file set.

Change-Id: I317a8fc44cf60e0489e23514cf9bf119afa827ee
Reviewed-on: https://dart-review.googlesource.com/39941
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-08 21:48:52 +00:00
Alexander Thomas f2af628b8a [infra] Disable sharding on vm-kernel and vm-kernel-precomp builders
TBR=whesse@google.com

Change-Id: I0277aa21b7aef6118e639d01a26ed7c98e5cdf6e
Reviewed-on: https://dart-review.googlesource.com/39762
Reviewed-by: Alexander Thomas <athom@google.com>
2018-02-07 16:42:52 +00:00
Alexander Thomas 222ad40af3 [infra] Add missing package to vm-kernel file set
TBR=whesse@google.com

Change-Id: I58a25a274dca173b8e025e44972226d9a196d5b7
Reviewed-on: https://dart-review.googlesource.com/39760
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-02-07 16:27:49 +00:00
Alexander Thomas a5992af988 [infra] --use-blobs on vm-kernel-precomp-win
Change-Id: I47d0e40dcece7d81356a44f4ddb071059fb8b149
Reviewed-on: https://dart-review.googlesource.com/39740
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-02-07 16:19:49 +00:00
Alexander Thomas ea683b93a8 [infra] Update VM builders in test matrix to match CQ
Change-Id: I85d8a51fa6639c5d20704da749ea6b2b72c224bb
Reviewed-on: https://dart-review.googlesource.com/39701
Reviewed-by: William Hesse <whesse@google.com>
2018-02-07 14:37:37 +00:00
Alexander Thomas 71910f0656 [infra] Shard vm-kernel builders on Luci
Change-Id: I9ff39eae6cf6bcd9aad59a8320d6a665e480182a
Reviewed-on: https://dart-review.googlesource.com/38580
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-07 14:20:11 +00:00
Alexander Thomas 4256f10f99 [infra] Increase timeout for front end tests on vm-kernel in test matrix
Change-Id: I0155868d1311d3ab21660881ef36f8f6ceafe24e
Reviewed-on: https://dart-review.googlesource.com/37980
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-02-05 11:12:47 +00:00
Alexander Thomas 1c9d9234bf [infra] Remove unfinished trigger configuration
Change-Id: I5af8518c41c12f37b7b9c602512fa3f4693f53f2
Reviewed-on: https://dart-review.googlesource.com/37661
Reviewed-by: William Hesse <whesse@google.com>
2018-02-05 11:12:47 +00:00
Siva Chandra 71dba8a0e5 Link the platform kernel with the command line dart executable.
Change-Id: Ib376a259e2e9ff9b487820c041d6795f8f7192d1
Reviewed-on: https://dart-review.googlesource.com/37420
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
2018-02-01 15:11:29 +00:00
Alexander Thomas 338685e9b6 [infra] Increase timeout for front_end tests in test matrix
Change-Id: I4b6b321fbf6522f81844018c787228e05141a9a4
Reviewed-on: https://dart-review.googlesource.com/35200
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-17 15:44:19 +00:00
Alexander Thomas 27ebef64d4 [infra] Add VM Kernel Windows x64 builders
Bug: https://github.com/dart-lang/sdk/issues/31707
Change-Id: Ie56f4c6f78c9b7c27fc4f587857e412db3e8f358
Reviewed-on: https://dart-review.googlesource.com/33960
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-01-16 15:39:03 +00:00
Jenny Messerly 2a8d1c023b enable corelib_2 and lib_2 tests for DDK on the bots
Change-Id: I72d5b9d34bc93f888c9da5da169e3a1cab003913
Reviewed-on: https://dart-review.googlesource.com/34505
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-01-13 01:21:10 +00:00
Jenny Messerly 1ace9bfe00 enable corelib_2 tests for DDK on the bots
Change-Id: I97fb3f606545db64313a1c3e8d1b687d536ac589
Reviewed-on: https://dart-review.googlesource.com/34503
Reviewed-by: Vijay Menon <vsm@google.com>
2018-01-13 00:39:33 +00:00
Alexander Thomas 89bd41d19a [infra] Simplify vm-kernel configurations in test matrix
This also adds the missing vm-kernel opt-counter builder.

Bug: https://github.com/dart-lang/sdk/issues/31753
Change-Id: I0199218f83d227cfc52505c213d7b689acd9c43e
Reviewed-on: https://dart-review.googlesource.com/31984
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-01-09 20:59:49 +00:00
Alexander Thomas c4e89ecaf4 [Infra] Correct step name in test matrix
Change-Id: I6f27037103feb4bdd037cdc0a78fa0a254c95930
Reviewed-on: https://dart-review.googlesource.com/32080
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-01-03 13:52:24 +00:00
Alexander Thomas 97e2994818 [Infra] Remove asan ia32 builder from test matrix
Bug: 31749
Change-Id: I3e9354a9f914788bbe2d08841e2212bddf033d12
Reviewed-on: https://dart-review.googlesource.com/31943
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-01-03 13:19:44 +00:00
Sigmund Cherem 414bad86df Directly create dart2js platform files using its patch files
Change-Id: I1c7d59968bfafeeb5a8b5252fa2d47e3c05b893e
Reviewed-on: https://dart-review.googlesource.com/27404
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2017-12-19 20:31:57 +00:00
Alexander Thomas 61bc4e07e9 [Infra] Add VM Kernel simarm/simdbc builders to test matrix
Change-Id: I37a0961382ca0da5ed549c76c18f3ac5b15ab29e
Reviewed-on: https://dart-review.googlesource.com/27580
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2017-12-14 12:30:35 +00:00
Bob Nystrom 650c9dcc8e Support extractTypeArguments() in 1.0 mode on the VM and dart2js.
Without strong mode, a "good enough" implementation is to simply call
the generic method with "dynamic" for the type arguments, which is what
this does. That should be enough to unblock our internal users.

We also need to not report a compile error when
dart_internal/extract_type_arguments.dart imports the hidden
"dart:_internal" library.

This patch does both of those for the VM and dart2js (using its old
front end).

Note that the test still fails because the test is more particular than
most actual user code would be -- it validates that the instantiated
type arguments are *exactly* correct, and not that the returned object
is merely subtype compatible.

Bug:
Change-Id: I0343beace4991861b29712b3fd7067ec8dc8f8ba
Reviewed-on: https://dart-review.googlesource.com/28020
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-12-12 19:04:18 +00:00
Vyacheslav Egorov efca9c69ab [vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration.
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.

Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.

Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.

Reland of https://dart-review.googlesource.com/27820

Change-Id: I49400fae716f75425e70bf1e561b3375ba39157e
Reviewed-on: https://dart-review.googlesource.com/28565
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2017-12-12 12:19:10 +00:00
Alexander Thomas 68bbe83132 [Infra] Add -rnone to ensure DDC kernel custom scripts don't use xvfb
TBR=whesse@google.com

Change-Id: I0e670e5b48fb0c4abe23c789344f2e2ea22ae667
Reviewed-on: https://dart-review.googlesource.com/28564
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2017-12-12 10:45:12 +00:00
Alexander Thomas 6538cb9004 [Infra] Fix broken DDC buildernames in test matrix caused by bad merge
TBR=whesse@google.com

Change-Id: I59f298aef3f280b10a6eb4f495c73adab76128ff
Reviewed-on: https://dart-review.googlesource.com/28561
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-12 08:59:01 +00:00
Alexander Thomas bdd88891b9 [Infra] Move runtime into DDC builder names
This makes it easier to add other runtimes later.

Change-Id: I90dfd9c404167eff880eed00933ffea212ccdef2
Reviewed-on: https://dart-review.googlesource.com/27942
Reviewed-by: William Hesse <whesse@google.com>
2017-12-12 08:11:12 +00:00
Bob Nystrom a53e4dd504 Finish migrating stuff out of lib_strong.
Some of these are data files that weren't picked up by the migration
script. Some are files that slipped between blocks of tests.

Change-Id: I184dc4701758b280444d54ec55c225ade30f3276
Reviewed-on: https://dart-review.googlesource.com/26423
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2017-12-11 23:45:23 +00:00
Vyacheslav Egorov e84fa65696 Revert "[vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration."
This reverts commit 50865e9387.

CQ on Mac is broken.

TBR=kustermann@google.com

Bug:
Change-Id: I41a7cab59c076dba4f25f5904725cca5bb4619c9
Reviewed-on: https://dart-review.googlesource.com/28420
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-12-11 21:07:43 +00:00
Vyacheslav Egorov 50865e9387 [vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration.
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.

Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.

Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.

Change-Id: I882b28f6a011eabf69c349ff0792b275434e39ff
Reviewed-on: https://dart-review.googlesource.com/27820
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2017-12-11 12:49:22 +00:00
Jens Johansen a6f66714ec [DDC] Enable sourcemap unit tests
Bug:
Change-Id: I10240c27eb06e8b0eddeac6a051ef00790970b11
Reviewed-on: https://dart-review.googlesource.com/27560
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2017-12-11 09:25:10 +00:00