Commit Graph

4 Commits

Author SHA1 Message Date
Jens Johansen d03a0d798e Re-insert linebreak in dwarf_stack_trace_test
This file was auto-formatted 2 months ago.
This - among other things - removed a linebreak which shifted linenumbers
by one, but didn't update the expected linenumbers from a throw accordingly.
Somehow the testserver has claimed that this has passed until now.
I have no idea how that happened.

This CL re-introduces the linebreak by inserting a comment,
which (currently) forces dartfmt to have the wanted linebreak.

BUG=
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2945273002 .
2017-06-21 13:47:38 +02:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Ryan Macnak 2343b96911 Mark dwarf_stack_trace_test as flaky in product mode, due to identical code folding.
Fix dwarf_stack_trace_test in checked mode (generated output directory includes a hypen).

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2784033002 .
2017-03-30 10:01:52 -07:00
Ryan Macnak 7589236f45 Dwarf tools interpret line number table pc's as start boundries instead of end boundries.
Put kNoSourcePosition on line 0 instead of line 1.

Closes #28785

R=fschneider@google.com, johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2762313003 .
2017-03-22 10:30:02 -07:00