Commit Graph

80 Commits

Author SHA1 Message Date
Ryan Macnak c30af41b96 Reapply "[mirrors] Add IsolateMirror.loadUri."
- Forward only kImportTag requests to DFE. This restores the current handling of a kScriptTag request when loading the kernel isolate in the simulators.
 - Mark dynamic_load_test as failing in the reload stress tests (reload fails to preserve library identity).

Change-Id: Ibe6f0a3505b99736a38d566abf3b2151505d7a7e
Reviewed-on: https://dart-review.googlesource.com/56706
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-05-29 22:01:01 +00:00
Kevin Millikin 7ff8adcec9 Fix an incorrect dart:mirrors test
The class defined by an anonymous mixin application is always
abstract.  If it were not, then it would be a Dart 2 static error that
it does not provide implementations of any of the abstract members of
the mixed-in class.  For example:

  class S {}
  abstract class M {
    int f();
  }
  abstract class C extends S with M {}

The class defined by `S with M` must be abstract because it does not
provide an implementation of `f`.

Change-Id: I3a990d7db4c5cb3c2dc83f4f12e4fd1eba68f876
Reviewed-on: https://dart-review.googlesource.com/56107
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-05-22 13:56:41 +00:00
Jenny Messerly e10f0717d2 fix test status for a few tests changed in 3002e47e
In particular:
super_call4_test/01
mirrors/deferred_constraints_constants_test

Change-Id: I8b0a32c4ce760e757f94d0d82b0b3123c55c3551
Reviewed-on: https://dart-review.googlesource.com/54163
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-05-08 01:04:47 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files.
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-04-10 19:03:21 +00:00
Ben Konyi 42581e4fa6 [VM] Added '--enable-asserts' to the top-level help message.
Change-Id: I91b22cc1563b7c5217f21032109d948a5bb78b57
Reviewed-on: https://dart-review.googlesource.com/48456
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2018-03-28 18:54:00 +00:00
Erik Ernst 8493f68271 Adjusted status for lib_2/async/future_or_type_test.dart
In response to redness for the dartanalyzer after landing
7c05f1e608.

Change-Id: I9fdc606fd30e43144d3f75d67b42820c1e7c0487
Reviewed-on: https://dart-review.googlesource.com/47460
Reviewed-by: Erik Ernst <eernst@google.com>
2018-03-21 12:17:45 +00:00
Lasse Reichstein Holst Nielsen 7c05f1e608 Add more tests for FutureOr used as a type.
Change-Id: I53a569eeee04f54fe2ac55009a25a806356d9880
Reviewed-on: https://dart-review.googlesource.com/36440
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2018-03-21 10:49:09 +00:00
Terry Lucas ea392fee27 TouchEvents now supported on Safari
TBR=sigmund@google.com

Change-Id: If485b39afeb0ce389c98d90ebe8a7ea6359e0fba
Reviewed-on: https://dart-review.googlesource.com/46950
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 14:40:03 +00:00
Terry Lucas 60469482f1 Move ClientRect members to DOMRect.
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 13:27:46 +00:00
Sigmund Cherem e8018bfdea Mark tests as flaky
TBR=efortuna@google.com

Change-Id: I3cb7153665609c0f02b1246e558857e20d09e100
Reviewed-on: https://dart-review.googlesource.com/45527
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-07 19:08:12 +00:00
Leaf Petersen 3d6ad7b3a2 Remove fuzzy arrows except on assignability
Change-Id: I00ffa8f6f85cede8badd4d7082da4603f998956c
Reviewed-on: https://dart-review.googlesource.com/40470
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-02-17 00:30:56 +00:00
Lasse R.H. Nielsen 0fb1c5bc7b Mark test as failing on analyzer.
Change-Id: I7ebe8f4cbdafbf6b93fb3af2950c956c18790c6f
Reviewed-on: https://dart-review.googlesource.com/41680
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-15 11:32:59 +00:00
Lasse R.H. Nielsen 0d5ce913c9 Add cast/retype to Stream, StreamTransformer and Converter.
Switch default for StreamController.addStream cancelOnError parameter to false.
Add orElse named argument to Stream.{first,last}Where.
First step in renaming the argument from defaultValue to orElse.

Change-Id: I22039c1f6933664ebc287c71e802799a64776f08
Reviewed-on: https://dart-review.googlesource.com/34822
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-09 14:09:39 +00:00
William Hesse bc148d44e2 Correct name of lib_2/async/periodic_timer4_test in status file
TBR=lrn@google.com

Change-Id: Ife80122754aa7e69bd98d6dab289a6a2aa9df7f3
Reviewed-on: https://dart-review.googlesource.com/40222
Reviewed-by: William Hesse <whesse@google.com>
2018-02-09 01:50:04 +00:00
William Hesse baaab3968f Mark new periodic_timer4_test as flaky on chrome and ff with all compilers
It is failing on chrome with dartdevc as well

TBR: lrn@google.com
Bug: https://github.com/dart-lang/sdk/issues/32094
Change-Id: I8c6c4734ef4d125fd0e17cba550f2fbd401a69c0
Reviewed-on: https://dart-review.googlesource.com/40221
Reviewed-by: William Hesse <whesse@google.com>
2018-02-09 01:19:56 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-07 15:38:09 +00:00
William Hesse 209dac0899 Update status for dartk on sim architectures and cross-frame test.
BUG=dart:32039
R=athom@google.com

Change-Id: Ic62951a846c24f8a00f347afd6c6620fd56b5c13
Reviewed-on: https://dart-review.googlesource.com/39161
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-02-06 18:10:32 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime.
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-17 13:13:17 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook.
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-07 08:38:30 +00:00
Morten Krogh-Jespersen a9a5081e10 Remove duplicate entries in same section from status files.
If two sections are syntactically equal, they are considered same section.

The discovery of duplicate entries was perfomed by the test in the CL:
https://dart-review.googlesource.com/#/c/sdk/+/21341

All removals has been done by hand to make sure the best comment was chosen.

Bug:
Change-Id: I105f6375adc1b5f555eb7c2af7d7d1e4e1922a32
Reviewed-on: https://dart-review.googlesource.com/21340
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-27 11:07:18 +00:00
Ryan Macnak 35227914a5 Further update status files for "Verify canonical objects before taking a snapshot or shutting down."
Bug: https://github.com/dart-lang/sdk/issues/31376
Change-Id: Ib0086b82cb0464c5526db44f2cd11d69021299c6
Reviewed-on: https://dart-review.googlesource.com/22280
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
2017-11-20 23:46:56 +00:00
Vyacheslav Egorov e834248640 [gardening] Restore status lines removed by accident
Bug:
Change-Id: I230a003c5300e5f4e7f5586e0582ec5c16fc6268
Reviewed-on: https://dart-review.googlesource.com/21348
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-11-16 11:51:21 +00:00
Lasse R.H. Nielsen adcb6a7399 Make main invocation not fail strong-mode type checking.
Bug: http://dartbug.com/31270
Change-Id: Id6ad2a429d5dc44b437a0fdd8fb4889d3dccf194
Reviewed-on: https://dart-review.googlesource.com/18480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-11-03 16:06:00 +00:00
Martin Kustermann 84dbb6e0b6 [VM] Do eager rehashing of [LinkedHashMap]s in order to avoid checking on every access
This improves 
  * JIT performance by around 14% 
  * precompiled performance by around 2%
on a simple map microbenchmark.

Change-Id: I623e2a715a709f89f2514ae30fbb504ee2e31661
Reviewed-on: https://dart-review.googlesource.com/17165
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-10-31 13:42:15 +00:00
Ben Konyi 41bda23a77 Migrated test block 214 to Dart 2.0.
wrapping_collections_test was modified since JSNative is deprecated and
was causing the test to fail ('class js has no getter for JSNative').

Bug:
Change-Id: Icc8951bce4be1152984b66769676080f89e5f1f7
Reviewed-on: https://dart-review.googlesource.com/9420
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-11 20:22:31 +00:00
Terry Lucas 213830e122 Migrated Block 188 to Dart 2.0
R=bkonyi@google.com

Change-Id: I3a450b04becaef007cc81fda1dbca1fda58b3d19
Reviewed-on: https://dart-review.googlesource.com/12361
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-11 14:42:22 +00:00
Terry Lucas 8611852b81 Migrated Block 199 to Dart 2.0
R=bkonyi@google.com

Change-Id: Ic52e7afb489b15b2f2e45f5ad9191cf5e441c047
Reviewed-on: https://dart-review.googlesource.com/11342
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-10 13:53:24 +00:00
Terry Lucas 83ff87e4a3 Migrated Block 204 to Dart 2.0
R=bkonyi@google.com

Change-Id: I032f25969e75fb9966222da969e73a665bf35f44
Reviewed-on: https://dart-review.googlesource.com/12321
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2017-10-10 13:00:01 +00:00
Terry Lucas 0319fb1e87 Migrated Block 200 to Dart 2.0
R=bkonyi@google.com

Change-Id: I9d998f61c2bc3d4b9c6ea71cb1111c00983a80a5
Reviewed-on: https://dart-review.googlesource.com/11347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-09 02:45:04 +00:00
Terry Lucas 16b6ba6a04 Splitout another set of group tests.
TBR=rnystrom@google.com

Change-Id: I6d9aea59eac88de07b76b9597cf6ceac32350b55
Reviewed-on: https://dart-review.googlesource.com/12305
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-09 01:07:37 +00:00
Terry Lucas 61e6389f8a Migrated Block 202 to Dart 2.0
R=bkonyi@google.com

Change-Id: Ibca90f46788ef86fdc57f746f48e8fd85b78aa5a
Reviewed-on: https://dart-review.googlesource.com/11361
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-08 23:19:49 +00:00
Ben Konyi 24ee7dab3c Migrated test block 35 to Dart 2.0.
No changes made to tests.

Bug:
Change-Id: I98d755d0c8005fd9cf0770966927b57a5fcc25de
Reviewed-on: https://dart-review.googlesource.com/11620
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-06 23:56:03 +00:00
Ben Konyi e2f92be5ae Migrated test block 34 to Dart 2.0.
Bug:
Change-Id: Ib2e0effabc354b5864f59b0de6611381d7dfd0df
Reviewed-on: https://dart-review.googlesource.com/11250
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2017-10-06 22:52:56 +00:00
William Hesse 64dd9dca79 Remove status lines for browser element_types tests from lib_2.status
Browser tests can only be run with a compiler, so they belong
in lib_2_dart2js.status or lib_2_dartdevc.status

TBR=terry@google.com

Bug:
Change-Id: If3c5c0dc3e4e2180771d2ac9e4deed063b14194b
Reviewed-on: https://dart-review.googlesource.com/11722
Reviewed-by: William Hesse <whesse@google.com>
2017-10-05 23:41:10 +00:00
Ben Konyi 7ea539a4c5 Migrated test block 190 to Dart 2.0.
Migrated multiple tests from unittest->test, fixed small strong mode
issue in cross_frame_test.

Bug:
Change-Id: I1c504ab4ac45e487ff3d3d156416e579978adc20
Reviewed-on: https://dart-review.googlesource.com/4820
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-05 22:00:26 +00:00
Ben Konyi d932b15c0d Migrated test block 33 to Dart 2.0.
Bug:
Change-Id: Ifb1626e45868c1bfc626edd83c7d9db5680764ed
Reviewed-on: https://dart-review.googlesource.com/11246
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2017-10-05 21:04:03 +00:00
Ben Konyi 992d060da6 Migrated test block 31 to Dart 2.0.
Minor changes for strong-mode.

Bug:
Change-Id: Ia9387a4d7976156bb592515bb848f7be45699478
Reviewed-on: https://dart-review.googlesource.com/11021
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-05 19:34:33 +00:00
Terry Lucas 949fda879a Restored keygen element test, not in chrome but other browsers support.
In addition, split out all the group tests to individual ones - unable to detect group failures in DDC.

TBR=bkonyi@google.com

Change-Id: I80b4a146e9bea3fb959d56ec3123667bfec122bd
Reviewed-on: https://dart-review.googlesource.com/11365
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-05 19:15:35 +00:00
Terry Lucas aeb7995355 Migrated Block 201 to Dart 2.0
R=bkonyi@google.com

Change-Id: Iad6df128725ffc81bbf352b02efc0412aa83272f
Reviewed-on: https://dart-review.googlesource.com/11360
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-05 18:01:10 +00:00
Terry Lucas 0beb87c853 Migrated Block 197 to Dart 2.0
R=bkonyi@google.com

Change-Id: Ic5ab3a1a5f300cc6df757ea03119595eac9dafc2
Reviewed-on: https://dart-review.googlesource.com/11340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-05 10:46:21 +00:00
Terry Lucas c886f96a8a Migrated Block 198 to Dart 2.0
R=bkonyi@google.com

Change-Id: I2280e12ba6d01a40df735083820c0ba96874ded5
Reviewed-on: https://dart-review.googlesource.com/11341
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-05 08:41:08 +00:00
Jakob Roland Andersen 42e28ca782 Migrated test batch 213 to Dart 2.0.
Bug:
Change-Id: I31f519c18ab62cc0aef969f60116ed518bcb77e3
Reviewed-on: https://dart-review.googlesource.com/11061
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-10-05 07:56:30 +00:00
Terry Lucas bbbb548e0a Migrated Block 195 to Dart 2.0
R=bkonyi@google.com

Change-Id: Ic5622d23d3159016625cfc17785f140ba9df409e
Reviewed-on: https://dart-review.googlesource.com/8739
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-05 06:08:10 +00:00
Terry Lucas 7f137ca921 Migrated Block 194 to Dart 2.0
R=bkonyi@google.com

Change-Id: I4e77f837a26d37e2d8f650c941f72454e6536b8d
Reviewed-on: https://dart-review.googlesource.com/8737
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-05 04:19:10 +00:00
Jakob Roland Andersen 0955c0ca9e Migrated test batch 211 to Dart 2.0.
Bug:
Change-Id: Iee8198332fd94ef708eab1aa34867c5d68054c6a
Reviewed-on: https://dart-review.googlesource.com/10420
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-10-04 21:27:40 +00:00
Jakob Roland Andersen 7091266045 Migrated test batch 207 to Dart 2.0.
Bug:
Change-Id: Ia0bfee80bf788a6eda83813fc986182a0d56a648
Reviewed-on: https://dart-review.googlesource.com/9980
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-10-04 20:14:19 +00:00
Jakob Roland Andersen 7f34184508 Migrated test batch 210 to Dart 2.0.
Bug:
Change-Id: I8552149b85676cba497d78a9f6e3861257b746bc
Reviewed-on: https://dart-review.googlesource.com/10361
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-10-03 14:39:09 +00:00
Jakob Roland Andersen d2cd2a4720 Migrated test batch 209 to Dart 2.0.
Bug:
Change-Id: If23630da318547e3beaf417a5ad97b30f6ffcbd3
Reviewed-on: https://dart-review.googlesource.com/10340
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
2017-10-03 13:02:49 +00:00
Jakob Roland Andersen 56c8922c7c Migrated test batch 208 to Dart 2.0.
Bug:
Change-Id: I97b3ca0d43bf68a60cdc2959844888c82c6af9eb
Reviewed-on: https://dart-review.googlesource.com/10260
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
2017-10-03 10:23:49 +00:00
Jakob Roland Andersen c930fc0781 Migrated test batch 206 to Dart 2.0.
Bug:
Change-Id: I231aa434de41c55a290ab3e399c97b7dbbbb028d
Reviewed-on: https://dart-review.googlesource.com/9940
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
2017-10-02 13:26:07 +00:00