dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

43 Commits

Author SHA1 Message Date
Keerti Parthasarathy 9eb09d825b Revert "Create _nullFuture and _falseFuture in the root zone." 
This reverts commit 9bb085a1c6 due to
test failure in google3.

Change-Id: I63940e62bd97c83bc432db99b44c991e6c1e025e
Reviewed-on: https://dart-review.googlesource.com/52422
Reviewed-by: Dan Grove <dgrove@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2018-04-24 20:45:38 +00:00
Lasse R.H. Nielsen 9bb085a1c6 Create _nullFuture and _falseFuture in the root zone. 
Avoids issues where they are lazily created in a different current zone and that zone messes with, for example, schedule microtask, which the future uses to schedule invocations of its callbacks.

Change-Id: I6697ca469426472523089fcf7ca44312b9c6ff5f
Reviewed-on: https://dart-review.googlesource.com/49509
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2018-04-06 16:10:52 +00:00
Lasse Reichstein Holst Nielsen 7c05f1e608 Add more tests for FutureOr used as a type. 
Change-Id: I53a569eeee04f54fe2ac55009a25a806356d9880
Reviewed-on: https://dart-review.googlesource.com/36440
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-21 10:49:09 +00:00
Terry Lucas fbf0113aa6 Fixed tests to successfully run with the DDC. 
TBR=vsm@google.com

Change-Id: I38c1ec16cb27dc3a46bb62ae129d9daa9cc4e9be
Reviewed-on: https://dart-review.googlesource.com/43621
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-25 18:43:33 +00:00
Leaf Petersen 3d6ad7b3a2 Remove fuzzy arrows except on assignability 
Change-Id: I00ffa8f6f85cede8badd4d7082da4603f998956c
Reviewed-on: https://dart-review.googlesource.com/40470
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-02-17 00:30:56 +00:00
Lasse R.H. Nielsen 0d5ce913c9 Add cast/retype to Stream, StreamTransformer and Converter. 
Switch default for StreamController.addStream cancelOnError parameter to false.
Add orElse named argument to Stream.{first,last}Where.
First step in renaming the argument from defaultValue to orElse.

Change-Id: I22039c1f6933664ebc287c71e802799a64776f08
Reviewed-on: https://dart-review.googlesource.com/34822
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-02-09 14:09:39 +00:00
Lasse R.H. Nielsen bdc6e9c862 Add ticks counter to Timer. 
Change-Id: Ie5ed28fa8b7ef9c6aea97331267cf3c717b17099
Reviewed-on: https://dart-review.googlesource.com/21342
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-08 10:16:00 +00:00
Florian Loitsch 3b8e4d41a7 Reapply "Run async functions immediately." 
Which was reverted in commit 032be73dbe.
Originally commited in commit 67bac0bce6.
Original review URL: https://dart-review.googlesource.com/5263

Change-Id: Ic7333c29e502a3924dc6aade8ffa46fc8aa5b04a
Reviewed-on: https://dart-review.googlesource.com/38120
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-02 15:50:16 +00:00
Siva Chandra 5e3aa8e9c2 Disable background compilation to improve determinism of slow consumer tests. 
Change-Id: I138e0fd8af8b6b3f7ec196333079924f7905dbc4
Reviewed-on: https://dart-review.googlesource.com/38144
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
 2018-02-01 21:49:49 +00:00
Florian Loitsch 032be73dbe Revert "Run async functions immediately." 
This reverts commit 67bac0bce6.

Reason for revert: broke the bot.

Original change's description:
> Run async functions immediately.
> 
> Migrated from https://codereview.chromium.org/2478703003/
> 
> Change-Id: I1d678c01ba5876490b12c676c500171328361d31
> Reviewed-on: https://dart-review.googlesource.com/5263
> Commit-Queue: Florian Loitsch <floitsch@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

TBR=whesse@google.com,rnystrom@google.com,vegorov@google.com,kustermann@google.com,zra@google.com,floitsch@google.com,jmesserly@google.com,vsm@google.com,regis@google.com,sigmund@google.com

Change-Id: I20c948057423c3fa5aa8c72843f8f2a17e086ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/37981
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-01 15:01:21 +00:00
Florian Loitsch 67bac0bce6 Run async functions immediately. 
Migrated from https://codereview.chromium.org/2478703003/

Change-Id: I1d678c01ba5876490b12c676c500171328361d31
Reviewed-on: https://dart-review.googlesource.com/5263
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-02-01 14:08:57 +00:00
Jenny Messerly 5013b28bbe fix #31999, remove fuzzy arrow runtime support from DDC 
Also updates tests that relied on fuzzy arrows.

Change-Id: Ia8df1d8d421e43dfada589223d5e46182b92fa67
Reviewed-on: https://dart-review.googlesource.com/37425
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-31 22:20:38 +00:00
Leaf Petersen 6b3576f673 Fix fuzzy arrow issues in tests. 
Also fixes a variety of miscellaneous accidental strong mode compile time or runtime check violations.

Change-Id: Ia8a41ac291aff3689efae0b11a9c51a2db30ef33
Reviewed-on: https://dart-review.googlesource.com/34924
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-01-16 23:08:01 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Janice Collins ad3efd8717 Migrate leftovers in lib/async to Dart 2.0. 
Bug:
Change-Id: I57ceb6a807fd63691028f2c5542f4446f748dda2
Reviewed-on: https://dart-review.googlesource.com/14882
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-20 16:41:18 +00:00
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests. 
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-17 23:37:15 +00:00
Bob Nystrom 307742d07e Move tests from package "test" (back) to "unittest". 
Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.

Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-10 19:46:12 +00:00
Jennifer Messerly 3a79c35f3c optimize maps/sets in DDC, fixes #29865 
- string/int keys use identity maps
- construct the correct type rather than relying on factory constructors when possible
- checks if key has identity semantics and use that when possible
- avoid helper calls/casts/etc in implementations
- use native ES6 Map/Set key order tracking
- optimized constructor for map literals
- fixes #30466, const maps are now canonicalized correctly

Change-Id: Id44acf3d9bf8cb153a4755aa28df08fe91bfc633
Reviewed-on: https://dart-review.googlesource.com/8167
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-10-04 19:04:27 +00:00
Ben Konyi fe01ec1d12 Migrated test block 179 to Dart 2.0. 
Some changes were required to stream_transformer_test to make it strong
mode clean. Other minor changes involved migrating from unittest->test.

Bug:
Change-Id: Ia21144090710137e4803c651cf9e3fd62e17f5f7
Reviewed-on: https://dart-review.googlesource.com/3707
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-20 19:29:01 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Ben Konyi 66a18d7e69 Migrated test block 174 to Dart 2.0. 
Minor changes to a couple of tests to fix strong mode issues.

Bug:
Change-Id: I0d8298c750b0f8c3c332019fee826548e5700843
Reviewed-on: https://dart-review.googlesource.com/3688
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-14 23:33:28 +00:00
Ben Konyi a061a49e07 Migrated test block 175 to Dart 2.0. 
Migrated stream_periodic* tests from unittest->test. Otherwise, simple
block.

Bug:
Change-Id: I99d59949ef5031513efd126303988da43d6f07cb
Reviewed-on: https://dart-review.googlesource.com/3702
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-14 22:07:28 +00:00
Ben Konyi cdc7a16d8e Migrated test block 166 to Dart 2.0. 
Bug:
Change-Id: Ib21357cf328ec25c1acc58c3b37a4a7bf2910fa1
Reviewed-on: https://dart-review.googlesource.com/4612
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 19:22:08 +00:00
Ben Konyi e4411375ed Migrated test block 181 to Dart 2.0. 
Manually merged collection/linked_list_test. Otherwise, simple block.

Bug:
Change-Id: I30df1dc7b02f0767ea0dcfc8247b2e1ce820aed9
Reviewed-on: https://dart-review.googlesource.com/3741
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-11 18:24:02 +00:00
Ben Konyi ddf2987ed7 Migrated test block 180 to Dart 2.0. 
Small changes were required for zone_debug_test to become strong mode
clean.

Bug:
Change-Id: I5ef52d7d116dd25793117511d8ee1904a172c014
Reviewed-on: https://dart-review.googlesource.com/3740
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-11 13:52:19 +00:00
Ben Konyi 7530b4b7ba Migrated test block 176 to Dart 2.0. 
No major changes other than moving tests from unittest->test.

Bug:
Change-Id: Icc9935da0072fc11c54e42a369792fe2748323de
Reviewed-on: https://dart-review.googlesource.com/3703
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-11 13:20:14 +00:00
Ben Konyi 72df7029fb Migrated test block 177 to Dart 2.0. 
Minor changes, all related to moving from unittest->test.

Bug:
Change-Id: Ie85eccf43c775211cf9d1eb58417ec3b3cc7f9a5
Reviewed-on: https://dart-review.googlesource.com/3704
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-09 01:44:40 +00:00
William Hesse 93f255db7d Migrated test block 172 
Author: bkonyi@google.com

Migrated test block 172 to Dart 2.0 and rolled forward package:test to 0.12.24+2 to fix issues with testing streams.

Migrated stream_controller_async from unittest->test.

This is a duplicate copy of CL https://dart-review.googlesource.com/c/sdk/+/3685/ rebased, with merge conflict resolved.
Bug:
Change-Id: I56e8ef24c74dfccbda10800541d6916053d8c931
Reviewed-on: https://dart-review.googlesource.com/4621
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-09 00:18:53 +00:00
Ben Konyi 8f63a56c59 Migrated test block 178 to Dart 2.0. 
Migrated tests from unittest->test, updated status files for tests that
are now passing.

Bug:
Change-Id: Ie116d2e39ba472c6c0ae8dec9d6ba100364a6bcc
Reviewed-on: https://dart-review.googlesource.com/3706
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-08 23:35:54 +00:00
Ben Konyi 80bcb08439 Migrated test block 173 to Dart 2.0. 
Very simple block; minor modifications to stream_controller_test.dart.

Bug:
Change-Id: I53ab9eb2200178b5f604c162ba2168bd1db312a3
Reviewed-on: https://dart-review.googlesource.com/3686
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-09-08 23:33:33 +00:00
Ben Konyi e897f75c74 Fixed strong mode error in slow_consumer3_test introduced as part of Dart 2.0 migration (test block 171). 
TBR=rnystrom@google.com,jcollins@google.com
BUG=

Review-Url: https://codereview.chromium.org/3004903002 .
 2017-08-30 07:06:11 -07:00
Ben Konyi d08e59e09c Migrated test block 171 to Dart 2.0. 
R=rnystrom@google.com

Moved schedule_microtask[2,3,5]_test off of package:test to
package:async_helper and package:expect.
Review-Url: https://codereview.chromium.org/3001793002 .
 2017-08-30 06:46:35 -07:00
Ben Konyi eb8b398163 Changed void -> dynamic return type to fix issue caused by poor merge decision. 
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/3012563002 .
 2017-08-29 16:45:25 -07:00
Ben Konyi 0ea752b5bf Relanding test block 170 migration. 
"Migrated test block 170 to Dart 2.0.""

This reverts commit 201df65b50201f023a1db5bb26bea7b8976c3b32.

Review-Url: https://codereview.chromium.org/3005813002 .
 2017-08-29 16:22:07 -07:00
Ben Konyi e8b337f08f Revert "Migrated test block 170 to Dart 2.0." 
This reverts commit 6e6b0cadea9adbb48556384fac52b17c2ac15443.
 2017-08-29 15:37:15 -07:00
Ben Konyi a7b19c1b47 Migrated test block 170 to Dart 2.0. 
Updated status file to account for strange failure in package:test when
running multiple_timer_test on dartdevc.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995013002 .
 2017-08-29 15:25:42 -07:00
Vyacheslav Egorov ab83ea939f Fix lib_2/async/future_test.dart multitest. 
It was broken by migration in 42d354c91d.

BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/3012433002 .
 2017-08-28 13:34:52 +02:00
Lasse R.H. Nielsen c8b6c19314 Revert "Add ticks counter to Timer." 
Tests broken in DDC

Review-Url: https://codereview.chromium.org/3011503002 .
 2017-08-28 13:14:09 +02:00
Lasse R.H. Nielsen 39c8f64ea3 Add ticks counter to Timer. 
Avoid VM scheduling multiple timer events if it gets delayed. This doesn't
scale for processes that are suspended for extended amounts of time.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/3003853002 .
 2017-08-28 12:57:45 +02:00
Ben Konyi 42d354c91d Migrated test block 168 to Dart 2.0. 
This block felt trickier than others, mostly due to random errors that I
wasn't able to find a cause for. Tests that I'm uncertain about are:
-first_regression_test
-future_timeout_test
-future_or_bad_type_test/implements

These all have status entries to prevent failures, but I think these
tests need another set of eyes.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2999943002 .
 2017-08-21 00:59:34 -07:00
Ben Konyi 55612ef10c Migrated test block 167 to Dart 2.0. 
No manual work required for this block.

BUG=
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2993213003 .
 2017-08-17 12:42:36 -07:00