Jacob Richman
14531fa62d
Re-land "Format all multitests"
...
Only delta from the original is a bad merge of tests/corelib/list_test.dart
This reverts commit 44d8be0ed3 .
BUG=
Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman
44d8be0ed3
Revert "Format all multitests"
...
This reverts commit 312b66dd5f .
BUG=
Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman
312b66dd5f
Format all multitests
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman
88eb557b65
Fix warnings_checker.dart handling of multitests
...
Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives
All files under tests were manually updated with
find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'
For now both old and new styles are allowed to accommodate CO19 tests.
R=efortuna@google.com
BUG=
Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman
bf2b545150
Revert "Update all tests"
...
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman
3c7353d987
Update all tests
...
Support //# multitests for better dartfmt compatibility and fewer multitest false positives
All files under tests were manually updated with
find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'
For now both old and new styles are allowed to accommodate CO19 tests.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman
6a7d6c385e
Add comments
...
Add spaces to make sure dartfmt doesn't destroy bespoke indentation
BUG=
R=sra@google.com
Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
floitsch@google.com
bcb3c3e8ba
Don't hide interceptors in mirrors.
...
The special code for mirrors was brittle and was the reason for several bugs.
BUG= http://dartbug.com/18076
BUG= http://dartbug.com/15405
BUG= http://dartbug.com/14025
BUG= http://dartbug.com/13842
BUG= http://dartbug.com/16804
BUG= http://dartbug.com/15555
R=karlklose@google.com
Review URL: https://codereview.chromium.org//236313012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35586 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-30 18:21:11 +00:00
rmacnak@google.com
5e310f4e31
Update mirror tests for removed API and other analyzer warnings.
...
BUG=http://dartbug.com/14695
R=gbracha@google.com
Review URL: https://codereview.chromium.org//64793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30290 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 19:55:05 +00:00
iposva@google.com
1cae21b556
- Reverting mirror changes.
...
Review URL: https://codereview.chromium.org//62373008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30029 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 02:07:37 +00:00
iposva@google.com
a2d280501e
- Reverting mirror changes.
...
Review URL: https://codereview.chromium.org//63563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30027 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:48:45 +00:00
rmacnak@google.com
bc897425e1
Cascaded mirror removal revert.
...
Review URL: https://codereview.chromium.org//63363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30024 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:20:51 +00:00
rmacnak@google.com
1caa73df59
Remove implementations of mirror methods not in the API from the VM. Update tests.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//63063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30005 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 22:30:45 +00:00
rmacnak@google.com
306d474235
Use symbol literals in the mirror tests. (Except for void, the empty string and setters.)
...
R=mlippautz@google.com
Review URL: https://codereview.chromium.org//24239010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27773 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 16:17:13 +00:00
mlippautz@google.com
3a3329c1ac
Fix tests that broke in r27633.
...
Make analyzer happy.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//24089006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27634 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 20:13:49 +00:00
mlippautz@google.com
9f41ce82ae
Merge tests for dart2js and VM using multi-tests.
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//24008002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27633 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 19:50:13 +00:00
mlippautz@google.com
cd958c8ca4
Fix reparsing of function parameters that include type parameters.
...
The parser is now properly initializing parsed_function/current_function to make
internal lookups work (instead of crashing).
BUG=
R=hausner@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//24019007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27418 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 01:06:43 +00:00
mlippautz@google.com
817a6fff3a
Implement ParameterMirror.{isFinal,hasDefaultValue,defaultValue}.
...
Fixes issue 12196 and partially addresses issue 12430.
BUG=
R=ahe@google.com , asiva@google.com , gbracha@google.com
Review URL: https://codereview.chromium.org//23020025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26730 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 17:31:09 +00:00
ahe@google.com
5873a310cd
Retain abstract classes.
...
BUG=http://dartbug.com/6490
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//19387003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25083 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 08:17:54 +00:00
ahe@google.com
3abe288a30
Implement JsMethodMirror.parameters and returnType.
...
BUG=http://dartbug.com/11513
R=kasperl@google.com
Review URL: https://codereview.chromium.org//18052004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24580 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 11:07:54 +00:00