 Jakob Roland Andersen
|
eaafacb59d
|
Revert "Revert "Reland "Migrated test batch 123 to Dart 2.0."""
This reverts commit 85e8613e66.
Reason for revert: Giving this one last try.
Wasn't able to reproduce the buildbot's failure on macOS or Windows, so
marking the entire test as RuntimeError, instead of just part of it.
GitHub issue: https://github.com/dart-lang/sdk/issues/30675
Original change's description:
> > This is a reland of 594e6cf010
> > Original change's description:
> > > Migrated test batch 123 to Dart 2.0.
> > >
> > > Bug:
> > > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > > Reviewed-on: https://dart-review.googlesource.com/4800
> > > Reviewed-by: Florian Loitsch <floitsch@google.com>
TBR=jakobr@google.com,floitsch@google.com
Change-Id: I0508cf605c40125132a807a019b5cf412a393ac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5680
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
|
2017-09-14 08:29:07 +00:00 |
|
|
Jakob Roland Andersen
|
85e8613e66
|
Revert "Reland "Migrated test batch 123 to Dart 2.0.""
This reverts commit e9cd03e8f8.
Reason for revert: Still fails on macOS/Windows. Sigh.
Original change's description:
> Reland "Migrated test batch 123 to Dart 2.0."
>
> This is a reland of 594e6cf010
> Original change's description:
> > Migrated test batch 123 to Dart 2.0.
> >
> > Bug:
> > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > Reviewed-on: https://dart-review.googlesource.com/4800
> > Reviewed-by: Florian Loitsch <floitsch@google.com>
>
> Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
> Reviewed-on: https://dart-review.googlesource.com/5301
> Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
> Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
TBR=jakobr@google.com,floitsch@google.com
Change-Id: Ia20ce3555e88e7c366893fb6416b77a2164db05f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5362
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
|
2017-09-13 09:21:55 +00:00 |
|
|
Jakob Roland Andersen
|
e9cd03e8f8
|
Reland "Migrated test batch 123 to Dart 2.0."
This is a reland of 594e6cf010
Original change's description:
> Migrated test batch 123 to Dart 2.0.
>
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>
Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
Reviewed-on: https://dart-review.googlesource.com/5301
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
|
2017-09-13 08:59:27 +00:00 |
|
|
Jakob Roland Andersen
|
ce4d332255
|
Revert "Migrated test batch 123 to Dart 2.0."
This reverts commit 594e6cf010.
Reason for revert: Apparently, label_test failed on macOS/Windows, but not on Linux.
Original change's description:
> Migrated test batch 123 to Dart 2.0.
>
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>
TBR=jakobr@google.com,floitsch@google.com
Change-Id: I7cec6458621920229e61133f868566ee65784269
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5181
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
|
2017-09-12 14:03:11 +00:00 |
|
|
Jakob Roland Andersen
|
594e6cf010
|
Migrated test batch 123 to Dart 2.0.
Bug:
Change-Id: I780329831dc189add7b192faf85161659a4a8b53
Reviewed-on: https://dart-review.googlesource.com/4800
Reviewed-by: Florian Loitsch <floitsch@google.com>
|
2017-09-12 13:28:37 +00:00 |
|