dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

65 Commits

Author SHA1 Message Date
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Lasse R.H. Nielsen 3db338e896 Remove tests checking dynamic behavior for what is now a compile-time error. 
The syntax is still reatined in the language/ directory, and there is no
Dart 2 behavior corresponding to what is supposed to be tested.

Change-Id: If395922760fb6d9a7b0263aa2cc76288600394fe
Reviewed-on: https://dart-review.googlesource.com/43023
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-22 12:23:13 +00:00
Régis Crelier ed1d8bd475 [VM parser] Complete support for generalized void (fixes #30516). 
'void' is now allowed as type annotation for locals, fields, and formal
parameters, in addition to being previously allowed as type argument.
Update status files.

Change-Id: I6459f56824dc0a695615d8dc87c9a8a1f9be29ef
Reviewed-on: https://dart-review.googlesource.com/37651
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-01-31 00:56:41 +00:00
Régis Crelier 2e3a4f8723 [VM] Ignore flag --error-on-bad-override in strong mode (fixes #31646). 
Change-Id: Idabd0108a69b37a9181c6bb260a25b3ebae2ba63
Reviewed-on: https://dart-review.googlesource.com/32003
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-01-03 15:40:36 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook. 
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-12-07 08:38:30 +00:00
Morten Krogh-Jespersen a9a5081e10 Remove duplicate entries in same section from status files. 
If two sections are syntactically equal, they are considered same section.

The discovery of duplicate entries was perfomed by the test in the CL:
https://dart-review.googlesource.com/#/c/sdk/+/21341

All removals has been done by hand to make sure the best comment was chosen.

Bug:
Change-Id: I105f6375adc1b5f555eb7c2af7d7d1e4e1922a32
Reviewed-on: https://dart-review.googlesource.com/21340
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-27 11:07:18 +00:00
Bob Nystrom ba84855c0a Migrate the lingering language_strong tests over to language_2. 
Change-Id: I4d60b650a2146c1d9be0fd0c5f98eac85f9e2eb1
Reviewed-on: https://dart-review.googlesource.com/16333
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-27 23:44:08 +00:00
William Hesse c74829f644 Simplify language_2 status files 
language_2_vm.status, language_2_precompiled.status, and
language_2_flutter.status have had disjunctions removed,
sections moved to the right file, identical sections merged,
sections ordered by header, section expressions sorted,
section contents alphabetized, and redundant lines removed.

Bug:
Change-Id: I5d35fe6ec747197e5750b81213803ad4b0de1e9d
Reviewed-on: https://dart-review.googlesource.com/14062
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-17 08:34:25 +00:00
Ben Konyi 73e13aefe6 Migrated block 145 to Dart 2.0. 
Various changes made for strong mode.

Bug:
Change-Id: I7d57cba0ec0420b68f7c1cf3d31fb4c8577e9898
Reviewed-on: https://dart-review.googlesource.com/13201
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-10-13 23:52:14 +00:00
Bob Nystrom e2cc730067 Migrate blocks 51 and 52. 
It looks like some of the tests in this block were already migrated,
but I re-migrated them and made a few tweaks that I think make them
better 2.0 tests.

Change-Id: I6d9058a53408f046d7db34f2244eeeb2c5eda625
Reviewed-on: https://dart-review.googlesource.com/13620
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-13 22:46:23 +00:00
Terry Lucas 7eb00ea45d Migrated Block 146 to Dart 2.0 
R=bkonyi@google.com

Change-Id: If6c7c2ebd8a4e3a3b724ada3967fc5836123732d
Reviewed-on: https://dart-review.googlesource.com/13621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-13 21:27:17 +00:00
Jaime Wren 09c44617e6 Migrate Dart 2.0 test block 133 
Change-Id: I58172fdfe7daf5910d11ce90491b5aefa137accd
Reviewed-on: https://dart-review.googlesource.com/13623
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-10-12 21:22:41 +00:00
Jaime Wren 3e13e9783d Migrate Dart 2.0 test block 128 
Change-Id: I3621006cbd2db4075f1ea55f5e34ecee688a2e18
Reviewed-on: https://dart-review.googlesource.com/13380
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-12 17:35:02 +00:00
Florian Loitsch e92c759e0b Migrate test block 129. 
Change-Id: I36f6a3f007862a7c5d2e8f304cb6730cdc9b4610
Reviewed-on: https://dart-review.googlesource.com/12289
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-11 08:59:49 +00:00
Jaime Wren 5b01202e3a Migrate test block 64 
Change-Id: I4c72d401ea22c4c46054924a971cf8cd6ed92575
Reviewed-on: https://dart-review.googlesource.com/12420
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-10-10 18:36:56 +00:00
Janice Collins e166ab3e2b Migrate test block 160 to Dart 2.0. 
Successfully migrated 7 tests. Need manual work on 6 tests:
- language_2/try_catch_test.dart:
  (TODO) Merge from language/try_catch_test.dart into this file.
- language_2/type_argument_in_super_type_test.dart:
  (TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_check_const_function_typedef2_test.dart:
  (TODO) Fix code that mentions "checked" mode.
- language_2/type_checks_in_factory_method_test.dart:
  (TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_conversion_ssa_test.dart:
  (TODO) Fix code that mentions "checked" mode.
- language_2/type_error_test.dart:
  (TODO) Merge from language/type_error_test.dart into this file.
  (TODO) Ensure code that checks for a TypeError uses 2.0 semantics.


Bug:
Change-Id: I43901890540efcf55da13d013571ce91979cbb64
Reviewed-on: https://dart-review.googlesource.com/11142
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-10 15:55:32 +00:00
Florian Loitsch bb1b39deaf Migrate test block 159. 
Change-Id: I71498e6b3d8c6b11ee53fc78b5b1b72dbe8c9fd8
Reviewed-on: https://dart-review.googlesource.com/12299
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-10 12:05:51 +00:00
Florian Loitsch 5b01aaa4e5 Migrate test block 147. 
Change-Id: I811e8dd4c44d42e6d0ffc94635c6922a21627c46
Reviewed-on: https://dart-review.googlesource.com/12297
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-10 11:25:03 +00:00
Jaime Wren 31e5cab243 Migrate test block 62 
- negative tests merged into non-negative tests
- lots of factory tests

Change-Id: I825e3ab6153f0dce243c3b8f1c4d223ab8ec5f9b
Reviewed-on: https://dart-review.googlesource.com/12126
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-10-09 20:00:01 +00:00
pq 6f58da2ef8 Migrate test block 138 to Dart 2.0. 
Bug:
Change-Id: I9050869dc3365d122cf3c8754b39859d20e20902
Reviewed-on: https://dart-review.googlesource.com/10161
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-06 17:33:58 +00:00
Ben Konyi 1d53f0a1cc Migrated test block 38 to Dart 2.0. 
Single test with no changes, although it still uses unittest.

Bug:
Change-Id: I0111814db289f512950d5e83471dab546867553f
Reviewed-on: https://dart-review.googlesource.com/11648
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-05 23:53:13 +00:00
Florian Loitsch 16034fcbd5 Migrate test block 144. 
Change-Id: I9a0abd2cb9a0a4341980f50af193006e09aa5542
Reviewed-on: https://dart-review.googlesource.com/11281
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 11:20:20 +00:00
Jakob Roland Andersen d7c5584976 Migrate test block 143. 
Change-Id: I843937de387436e07b289ccc35efa6776d59c142
Reviewed-on: https://dart-review.googlesource.com/11280
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 07:27:28 +00:00
Florian Loitsch 3b64211ab2 Migrate test block 127. 
Change-Id: I05a4baa3c641d71ccee1fce1e7f680f3fd9f42fc
Reviewed-on: https://dart-review.googlesource.com/9041
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 06:43:21 +00:00
Florian Loitsch ec69c47c12 Migration of test block 126. 
Change-Id: I8bbccbfae0194f246b8305ea4ca7bb02b5b6a9ec
Reviewed-on: https://dart-review.googlesource.com/7546
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-04 21:38:10 +00:00
pq dd069fc800 Migrate test block 142 to Dart 2.0. 
Bug:
Change-Id: I358bcf6d7d3d4c78b572ed4bbcb05696c47268cc
Reviewed-on: https://dart-review.googlesource.com/10640
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-03 20:00:27 +00:00
Janice Collins 3bed0647a0 Migrate block 162 to Dart 2.0. 
Based heavily on https://codereview.chromium.org/3007803002, but built from scratch with the updated migration script.

Change-Id: I52ecd5dd97a73ec2f5fc524de532c5605c5d0a7d
Reviewed-on: https://dart-review.googlesource.com/9360
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-10-03 17:47:59 +00:00
Ben Konyi 876bb0c494 Migrated test block 130 to Dart 2.0. 
Slightly tricky block. Many map_literal* tests were modified as they were creating maps with
multiple instances of the same key.

Bug:
Change-Id: I5dcaa458ee8f68a4934950bb32229ff92100149b
Reviewed-on: https://dart-review.googlesource.com/9064
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-29 04:24:02 +00:00
Ben Konyi 5bb98ebc33 Migrated test block 161 to Dart 2.0. 
This block contained a lot of static type warnings and took a lot of
status file wrangling to get right.

Bug:
Change-Id: I037402a31f978af15716964c8ff5192036df4276
Reviewed-on: https://dart-review.googlesource.com/7440
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-28 17:15:51 +00:00
pq 57d452dbf7 Migrate test block 134 to Dart 2.0. 
Bug:
Change-Id: I67bba5c5049c62b8313d49efe36c81fc600b995a
Reviewed-on: https://dart-review.googlesource.com/7847
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-28 16:15:47 +00:00
Jaime Wren d18c5c3620 Migrated test block 63 to Dart 2.0 
Change-Id: I35b3ceb1ac2aa7fc4e26a28ff814bccba6bbb004
Reviewed-on: https://dart-review.googlesource.com/7200
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-28 16:06:08 +00:00
Jaime Wren 3d020fa91e Migrated test block 60 to Dart 2.0, take 2 
Original review at https://dart-review.googlesource.com/c/sdk/+/7160

Change-Id: If2aeecec04640bee3b622d97c8fcdd6cb1bdd369
Reviewed-on: https://dart-review.googlesource.com/8731
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-27 18:07:05 +00:00
pq a02ca2070f Migrate block 141 to Dart 2.0. 
Bug:
Change-Id: If806f50a6254c187fc862fc7e5c19f45ccb9a8e8
Reviewed-on: https://dart-review.googlesource.com/8361
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-26 18:42:04 +00:00
Ben Konyi 8253f51b64 Migrated test block 140 to Dart 2.0. 
Bug:
Change-Id: I935b29026125e0318cc977a7d5c6fd45479a0d56
Reviewed-on: https://dart-review.googlesource.com/7853
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-25 14:53:02 +00:00
Ben Konyi c0364e372d Migrated test block 58 to Dart 2.0. 
No major changes.

Bug:
Change-Id: I7092880088d0fd334d6d2b1f6d4f1dbc2cb03ed2
Reviewed-on: https://dart-review.googlesource.com/7487
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-25 13:51:22 +00:00
Ben Konyi 24e40a0f61 Migrated test block 139 to Dart 2.0. 
Did not migrate null_bottom / null_is_bottom type tests. Modified
null_test to not run some mirrors related checks on platforms that don't
support mirrors.

Bug:
Change-Id: I7fce784f537cc298e2945a32073700083d9275f8
Reviewed-on: https://dart-review.googlesource.com/7848
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-23 00:06:38 +00:00
Ben Konyi 038c281a47 Migrated test block 131 to Dart 2.0. 
Quite a few changes were made to method_override* tests.

Bug:
Change-Id: I554c83ae766010b55f17a86caee9418d0c34cbe7
Reviewed-on: https://dart-review.googlesource.com/7683
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 21:53:58 +00:00
pq d9326f4ab3 Migrate test block 135 to Dart 2.0. 
Bug:
Change-Id: Icda59de9bfad2e9b2683f019fb9c6fc54c12547c
Reviewed-on: https://dart-review.googlesource.com/7587
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:04:06 +00:00
Jaime Wren ec431ffa39 Revert "Migrated test block 60 to Dart 2.0" 
This reverts commit 9141047cd7.

Change-Id: I222dd72cabe4a69576e7f5d87e2ae61b96ac6b16
Reviewed-on: https://dart-review.googlesource.com/7636
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 21:34:32 +00:00
Jaime Wren 9141047cd7 Migrated test block 60 to Dart 2.0 
Change-Id: I3b9f5ea80001adf0017599c86db3be235fbf12e1
Reviewed-on: https://dart-review.googlesource.com/7160
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 20:43:34 +00:00
Ben Konyi a87493f8ca Migrated test block 165 to Dart 2.0. 
Minor changes to a couple of tests to make them strong-mode clean.

Bug:
Change-Id: Id0cac7a120dbdf940d101c3e5de8c206a0ad6342
Reviewed-on: https://dart-review.googlesource.com/4613
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-21 19:00:36 +00:00
Bob Nystrom 74e4ccdeb8 Migrate block 120. 
Change-Id: Ia5a433e70ab3bdf953a116a0b65de42138125d2b
Reviewed-on: https://dart-review.googlesource.com/6347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 22:23:58 +00:00
Ben Konyi 192579020c Migrated test block 121 to Dart 2.0. 
Bug:
Change-Id: I194436597ba39b2e2b872fb58b77314ab925b3aa
Reviewed-on: https://dart-review.googlesource.com/7080
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-19 23:36:24 +00:00
Terry Lucas 83146c0689 Migrated test block 53 to Dart 2.0 
Change-Id: I14461accc36505b3c8dfcf88705ccf8c9fd817f4
Reviewed-on: https://dart-review.googlesource.com/4522
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-15 03:51:03 +00:00
Ben Konyi 01e5f01cfc Migrated test block 164 to Dart 2.0. 
Fairly simple block with the exception of the
causal_async_exception_stack* tests needing to be refactored to be
migrated from unittest->test.

Bug:
Change-Id: I8f4879a10730b6186bdd1b392084a2e4055262eb
Reviewed-on: https://dart-review.googlesource.com/4641
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-14 21:49:59 +00:00
Jakob Roland Andersen d687bc6673 Migrated test batch 122 to Dart 2.0. 
Bug:
Change-Id: Icb90877af264b2f61c9e32be7420ed748cab601f
Reviewed-on: https://dart-review.googlesource.com/5741
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-14 14:42:48 +00:00
Jakob Roland Andersen eaafacb59d Revert "Revert "Reland "Migrated test batch 123 to Dart 2.0.""" 
This reverts commit 85e8613e66.

Reason for revert: Giving this one last try.

Wasn't able to reproduce the buildbot's failure on macOS or Windows, so
marking the entire test as RuntimeError, instead of just part of it.

GitHub issue: https://github.com/dart-lang/sdk/issues/30675

Original change's description:
> > This is a reland of 594e6cf010
> > Original change's description:
> > > Migrated test batch 123 to Dart 2.0.
> > > 
> > > Bug:
> > > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > > Reviewed-on: https://dart-review.googlesource.com/4800
> > > Reviewed-by: Florian Loitsch <floitsch@google.com>
TBR=jakobr@google.com,floitsch@google.com

Change-Id: I0508cf605c40125132a807a019b5cf412a393ac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5680
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-14 08:29:07 +00:00
Ben Konyi 30dde80447 Migrated test block 57 to Dart 2.0. 
Bug:
Change-Id: I4b6845b0539fc5b8bb7118d6e920685afb0b3edc
Reviewed-on: https://dart-review.googlesource.com/5342
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-13 18:08:58 +00:00
Jakob Roland Andersen 85e8613e66 Revert "Reland "Migrated test batch 123 to Dart 2.0."" 
This reverts commit e9cd03e8f8.

Reason for revert: Still fails on macOS/Windows. Sigh.

Original change's description:
> Reland "Migrated test batch 123 to Dart 2.0."
> 
> This is a reland of 594e6cf010
> Original change's description:
> > Migrated test batch 123 to Dart 2.0.
> > 
> > Bug:
> > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > Reviewed-on: https://dart-review.googlesource.com/4800
> > Reviewed-by: Florian Loitsch <floitsch@google.com>
> 
> Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
> Reviewed-on: https://dart-review.googlesource.com/5301
> Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
> Reviewed-by: Jakob Roland Andersen <jakobr@google.com>

TBR=jakobr@google.com,floitsch@google.com

Change-Id: Ia20ce3555e88e7c366893fb6416b77a2164db05f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5362
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-13 09:21:55 +00:00
Jakob Roland Andersen e9cd03e8f8 Reland "Migrated test batch 123 to Dart 2.0." 
This is a reland of 594e6cf010
Original change's description:
> Migrated test batch 123 to Dart 2.0.
> 
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>

Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
Reviewed-on: https://dart-review.googlesource.com/5301
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-13 08:59:27 +00:00