 Florian Loitsch
|
8e01f69305
|
Void is not required to be null anymore.
In checked mode, `void` now accepts any value.
Fixes #28937.
Fixes #28938.
BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, kmillikin@google.com, lrn@google.com, regis@google.com
Committed: https://github.com/dart-lang/sdk/commit/521dc6620fd2c4591aa975745c14b304428f17eb
Reverted: https://github.com/dart-lang/sdk/commit/a3c0cb65af4bbbdde756208dcccdcdf896902b5b
Committed: https://github.com/dart-lang/sdk/commit/4e52c457a9ac412b6b0a3a350020998c7e2f7d9a
Reverted: https://github.com/dart-lang/sdk/commit/4b35d3995b2b273728751c19976ece0edca0eddc
Committed: https://github.com/dart-lang/sdk/commit/6caf9ef4439e20ea726d8a5383ed34d42b02c84b
Reverted: https://github.com/dart-lang/sdk/commit/30d9bf2ed3225f04c52d999a1a5c61e63a90578d
Review-Url: https://codereview.chromium.org/2718513002 .
|
2017-05-08 11:31:37 +02:00 |
|
|
Jens Johansen
|
30d9bf2ed3
|
Revert "Void is not required to be null anymore."
This reverts commit 6caf9ef443.
Commit breaks vm-kernel-linux-debug-x64-be.
Triggers asserts like
../../runtime/vm/flow_graph_compiler_x64.cc: 658: error: expected: dst_type.IsMalformedOrMalbounded() || (!dst_type.IsDynamicType() && !dst_type.IsObjectType() && !dst_type.IsVoidType())
Quick-check with python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options --no-enable-malloc-hooks isolate
BUG=
Review-Url: https://codereview.chromium.org/2865603003 .
|
2017-05-05 08:56:26 +02:00 |
|
|
Florian Loitsch
|
6caf9ef443
|
Void is not required to be null anymore.
In checked mode, `void` now accepts any value.
Fixes #28937.
Fixes #28938.
BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, lrn@google.com, regis@google.com
Committed: https://github.com/dart-lang/sdk/commit/521dc6620fd2c4591aa975745c14b304428f17eb
Reverted: https://github.com/dart-lang/sdk/commit/a3c0cb65af4bbbdde756208dcccdcdf896902b5b
Committed: https://github.com/dart-lang/sdk/commit/4e52c457a9ac412b6b0a3a350020998c7e2f7d9a
Reverted: https://github.com/dart-lang/sdk/commit/4b35d3995b2b273728751c19976ece0edca0eddc
Review-Url: https://codereview.chromium.org/2718513002 .
|
2017-05-04 16:27:52 +02:00 |
|
|
Florian Loitsch
|
4b35d3995b
|
Revert "Void is not required to be null anymore."
This reverts commit 4e52c457a9.
BUG=
Review-Url: https://codereview.chromium.org/2863463002 .
|
2017-05-03 19:22:22 +02:00 |
|
|
Florian Loitsch
|
4e52c457a9
|
Void is not required to be null anymore.
In checked mode, `void` now accepts any value.
Fixes #28937.
Fixes #28938.
BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, lrn@google.com, regis@google.com
Committed: https://github.com/dart-lang/sdk/commit/521dc6620fd2c4591aa975745c14b304428f17eb
Reverted: https://github.com/dart-lang/sdk/commit/a3c0cb65af4bbbdde756208dcccdcdf896902b5b
Review-Url: https://codereview.chromium.org/2718513002 .
|
2017-05-03 17:43:23 +02:00 |
|
|
Florian Loitsch
|
a3c0cb65af
|
Revert "Void is not required to be null anymore."
This reverts commit 521dc6620f.
BUG=
Review-Url: https://codereview.chromium.org/2855173002 .
|
2017-05-03 17:36:39 +02:00 |
|
|
Florian Loitsch
|
521dc6620f
|
Void is not required to be null anymore.
In checked mode, `void` now accepts any value.
Fixes #28937.
Fixes #28938.
BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, lrn@google.com, regis@google.com
Review-Url: https://codereview.chromium.org/2718513002 .
|
2017-05-03 17:31:21 +02:00 |
|