Commit Graph

3 Commits

Author SHA1 Message Date
Mike Fairhurst a48e0ef493 Fix #28740 demangle constructors in stack traces (A.A becomes new A) REDO
Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

Previous attempt (a84b6b7f) didn't update vm/cc tests, which broke the
build, was reverted, and also revealed an important case:

Functions within constructors:
- Were A.A.x, now are new A.x

Doing this was cleanest by switching the loop out for recursion, which
provides a nice guarantee that any anonymous function within some other
function will always have the correct prefix, and the class name (which
may or may not be prepended at the end) is only applied once, and its
existence is only checked in one place.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2823253005 .
2017-04-28 10:19:20 -07:00
Jacob Richman b7995140f8 Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)."
This reverts commit a84b6b7f7b.

BUG=

Review-Url: https://codereview.chromium.org/2824323002 .
2017-04-18 16:48:33 -07:00
Mike Fairhurst a84b6b7f7b Fix #28740 demangle constructors in stack traces (A.A becomes new A).
Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

BUG=
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2818933003 .
2017-04-18 15:18:29 -07:00