Jacob Richman
14531fa62d
Re-land "Format all multitests"
...
Only delta from the original is a bad merge of tests/corelib/list_test.dart
This reverts commit 44d8be0ed3 .
BUG=
Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman
44d8be0ed3
Revert "Format all multitests"
...
This reverts commit 312b66dd5f .
BUG=
Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman
312b66dd5f
Format all multitests
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman
88eb557b65
Fix warnings_checker.dart handling of multitests
...
Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives
All files under tests were manually updated with
find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'
For now both old and new styles are allowed to accommodate CO19 tests.
R=efortuna@google.com
BUG=
Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman
bf2b545150
Revert "Update all tests"
...
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman
3c7353d987
Update all tests
...
Support //# multitests for better dartfmt compatibility and fewer multitest false positives
All files under tests were manually updated with
find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'
For now both old and new styles are allowed to accommodate CO19 tests.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman
6a7d6c385e
Add comments
...
Add spaces to make sure dartfmt doesn't destroy bespoke indentation
BUG=
R=sra@google.com
Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
johnniwinther@google.com
8522acc30c
Handle metadata on nested function parameters.
...
BUG=http://dartbug.com/16281
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=36485
Committed: https://code.google.com/p/dart/source/detail?r=36547
Review URL: https://codereview.chromium.org//296463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36653 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 08:29:27 +00:00
johnniwinther@google.com
b4c8f544ee
Revert "Handle metadata on nested function parameters."
...
This reverts commit r36547.
Crash in
http://build.chromium.org/p/client.dart/builders/dart2js-linux-release-minified-1-5-be/builds/4716/steps/dart2js-d8%20tests%20--minified/logs/stdio
Review URL: https://codereview.chromium.org//297903004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36563 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 11:45:44 +00:00
johnniwinther@google.com
7d040cee6b
Handle metadata on nested function parameters.
...
BUG=http://dartbug.com/16281
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=36485
Review URL: https://codereview.chromium.org//296463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36547 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 08:30:36 +00:00
johnniwinther@google.com
bca0af893a
Revert "Handle metadata on nested function parameters."
...
This reverts commit r36485.
Crash in
http://build.chromium.org/p/client.dart/builders/dart2js-ff-linux-4-4-be/builds/5670/steps/dart2js-ff%20tests/logs/stdio
R=karlklose@google.com
Review URL: https://codereview.chromium.org//296513015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36489 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 12:29:18 +00:00
johnniwinther@google.com
4f6742dc8e
Handle metadata on nested function parameters.
...
BUG=http://dartbug.com/16281
R=karlklose@google.com
Review URL: https://codereview.chromium.org//296463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36485 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 11:20:21 +00:00