Commit Graph

21 Commits

Author SHA1 Message Date
Erik Corry 2fb5d08102 Spelling a
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2841543002 .
2017-04-24 14:53:51 +02:00
Jacob Richman 14531fa62d Re-land "Format all multitests"
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests"
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests"
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman 6a7d6c385e Add comments
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
Srdjan Mitrovic b3405d5ebc Add --no-background-compilation to tests that expect to run code in optimized form
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1759973002 .
2016-03-02 16:30:58 -08:00
Stephen Adams e78c269603 Use annotations on confuse() in null_test
Verified no material code changes.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1511293003 .
2015-12-09 13:38:47 -08:00
floitsch@google.com 22ab27256e Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650

Reverted: https://code.google.com/p/dart/source/detail?r=32652

Committed: https://code.google.com/p/dart/source/detail?r=32654

Reverted: https://code.google.com/p/dart/source/detail?r=32665

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32692 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 12:08:18 +00:00
floitsch@google.com 4b184d887a Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."
Revert "Update status file."

This reverts commit r32654 and r32661.

Review URL: https://codereview.chromium.org//163853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32665 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 18:36:46 +00:00
floitsch@google.com dfaf149d7e Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650
Reverted: https://code.google.com/p/dart/source/detail?r=32652

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32654 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 15:10:12 +00:00
floitsch@google.com 9cbc78cd36 Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."
This reverts commit r32650.

Review URL: https://codereview.chromium.org//163513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32652 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 13:46:37 +00:00
floitsch@google.com 6e0b2d61c4 Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32650 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 12:39:28 +00:00
lrn@google.com 6ecdf2db1d Fix static type warnings in language/null_test.
Update status file to mark analyzer as failing. It does not detect
extending or implementing Null.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//22978011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26188 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 11:39:00 +00:00
lrn@google.com 14a75969c3 Add Null class to dart:core.
Make dart2js accept this class as the type of `null`.

Dart2js still fails on tests on the form: x is Null
VM does not recognize Null as the type of `null`.

BUG= http://dartbug.com/12382
R=fschneider@google.com, karlklose@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23012003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26175 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 09:12:19 +00:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library.
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library."
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library.
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
sigmund@google.com 64d7bc5acf test rename overhaul: step 8 - language tests
Review URL: https://chromiumcodereview.appspot.com//10248007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7101 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-27 18:45:10 +00:00