Commit Graph

4 Commits

Author SHA1 Message Date
floitsch@google.com 8fd6d0aafd Remove Expect from core library.
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library."
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library.
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
floitsch@google.com 8281292638 Fix bad code-generation for nested-ifs in for loops.
In the builder we compile (x && y && z) into nested ifs. Before
code-emission we try to detect this pattern:

            If
          /    \
         /      \
      1 expr1    \
       If         \
      /  \         \
     /    \         goto
  1 expr2            |
    goto    goto     |
      \     /        |
       \   /         |
   phi1(expr2, true|false)   <=== nested if's join block
          \          |
           \         |
             phi(phi1, true|false)

However we forgot to verify that the nested if's join block didn't
contain any expression.

Fixes issue 4826.

Review URL: https://chromiumcodereview.appspot.com//10917012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11627 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 16:53:47 +00:00