dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

312 Commits

Author SHA1 Message Date
Florian Loitsch 05bb0edf41 Revert "Update the function_type tests for Dart 2.0." 
This reverts commit 46418dc31a.

Review-Url: https://codereview.chromium.org/2986313002 .
 2017-08-02 17:45:03 +02:00
Florian Loitsch 46418dc31a Update the function_type tests for Dart 2.0. 
Mainly ensures that `dynamic Function(int)` and `int Function(int)` aren't treated as assignable.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2987133002 .
 2017-08-02 17:07:27 +02:00
Bob Nystrom ad7e4df362 Migrate block 39 language/async_backwards ... /async_star_take. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2990973002 .
 2017-07-28 14:28:57 -07:00
Bob Nystrom f32d1b2bcd Migrate block 37, language/arithmetic2 ... /async_await_syntax_test. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2992003002 .
 2017-07-28 11:16:23 -07:00
Erik Corry e431e93e87 Revert two Kernel changes that were causing test failures. 
Example failure:
python tools/test.py -m release -c dartk --builder-tag no_ipv6 \
    language/function_type/function_type63_test

Revert "Serialize typedef parameters (including function typed ones) to Kernel and use it to resynthesize typedefs from Kernel."
This reverts commit afc392b66d.
Reverts https://codereview.chromium.org/2990783002

Revert "Add Member.documentationComment and use it to resynthesize documentation from Kernel."
This reverts commit 47ecf72272.
Reverts https://codereview.chromium.org/2990873002

Also reverts some attempts to fix test files:
302b410364
https://codereview.chromium.org/2984343002
05ccf27015
https://codereview.chromium.org/2992683002
f71dcd7834
https://codereview.chromium.org/2984363003

Also had to revert some test changes that were committed on top of a red buildbot, in order to try to get back to a place where bots were green:

23952fdf56
https://codereview.chromium.org/2990773002
557cab2a3e
https://codereview.chromium.org/2985173002

R=johnniwinther@google.com, karlklose@google.com
BUG=

Review-Url: https://codereview.chromium.org/2986093002 .
 2017-07-28 14:08:23 +02:00
Bob Nystrom 23952fdf56 Migrate language/arithmetic2_test ... language/async_await_syntax_test. 
R=sra@google.com

Review-Url: https://codereview.chromium.org/2990773002 .
 2017-07-27 16:13:47 -07:00
Bob Nystrom 557cab2a3e Migrate language/async_backwards... ... language/async_star_take... 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2985173002 .
 2017-07-27 15:48:30 -07:00
Erik Ernst bb8d6ed680 Added status for syntax_test/none. 
Other tools had this status entry, but dartk/dartkp were omitted. In
all cases, the change is needed because the allowed usages of `void`
have been relaxed, but most tools do not support that yet.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2984273002 .
 2017-07-27 14:03:07 +02:00
Siva Annamalai 33c50e9374 1. Correctly set root_library based on the application script URI instead of looking for the library that has the 'main' method. 
2. Adjust the Dart front end to not require a 'main' method when the in memory filesystem is used, this allows execution of VM unit tests which all do not necessarily have a 'main' method (integrated CL from siggi)

3. Change kernel reader to not look for a 'main' methos when Dart_LoadKernel is called.

4. Change Dart_LoadScript to also support loading of dart programs when Dart front end is used

R=aam@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2948273002 .
 2017-07-19 18:09:19 -07:00
Sigmund Cherem 9bbe761f4b Update status files for kernel tests 
Now kernel-service sends an "error" status whenever there are compile time errors,
so many of these tests that were not executed at runtime are now correctly being
reported by the VM as compile time errors.

This was only possible now that we are plumbing all error messages through a
single API, we can later evaluate whether it makes sense to recover
on some of these errors and how to deal better with recovery

Review-Url: https://codereview.chromium.org/2976403002 .
 2017-07-18 20:29:20 -07:00
Erik Ernst 182c4d5923 Added test using void in new positions. 
This is the first step of addressing issue 30176.
The test contains syntax errors according to all tools, and status
files have been adjusted accordingly.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2980293002 .
 2017-07-18 13:27:33 +02:00
Lasse R.H. Nielsen 8e21707a47 Fix bug in test's /none version. Update status files. 
R=eernst@google.com

Review-Url: https://codereview.chromium.org/2975193002 .
 2017-07-14 14:04:10 +02:00
Lasse R.H. Nielsen 609d26a227 Add assert-in-initializer-list to formal specification. 
Add tests for new syntax.
Not dart-formatted yet since the formatter doesn't accept the new syntax.

R=eernst@google.com, floitsch@google.com

Review-Url: https://codereview.chromium.org/2962153002 .
 2017-07-10 13:59:38 +02:00
Peter von der Ahé 6bb89e4fbf Use type variables on Typedef correctly. 
R=johnniwinther@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2967923002 .
 2017-07-05 13:12:27 +02:00
Vyacheslav Egorov f167ad18da test.py: temporarily disable background optimizer in vm-dartk-debug config. 
It is causing flakiness on bots.

Unmark tests marked as flaky by 45e4d848d2

See https://github.com/dart-lang/sdk/issues/30016.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2970733002 .
 2017-07-03 17:05:12 +02:00
Peter von der Ahé 45e4d848d2 [gardening] Update status files for kernel debug mode. 
Review-Url: https://codereview.chromium.org/2969883002 .
 2017-07-03 15:37:16 +02:00
Jens Johansen 6873d96db3 [kernel] Update status file 
Removed no-longer-current status-file entry.

See issue #28790.

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2962303002 .
 2017-07-03 08:17:17 +02:00
Jens Johansen 6cb702b723 [Kernel] Add check in the constant evaluator. 
Currently some tests pass in checked mode but fails in non-checked mode
because we don't check the result of a constant-evaluation that should
be bool in non-checked mode.
This CL changes it so we always check the bool result in the constant-evaluator.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2956493003 .
 2017-06-29 11:18:10 +02:00
Paul Berry 0958e40357 Adjust return types of spec-mode function expressions to match VM. 
R=scheglov@google.com

The spec is unclear about what is supposed to happen here (see
https://github.com/dart-lang/sdk/issues/30044).  Matching the VM
behavior allows us to pass the existing tests.
Review-Url: https://codereview.chromium.org/2958363002 .
 2017-06-28 14:36:00 -07:00
Ben Konyi 89eda8a533 Updated status file to fix kernel bot failures. 
TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2953933003 .
 2017-06-22 15:09:49 -07:00
Ben Konyi 143baba8fc Reintroducing parser changes to cause compile-time errors when trying to reinitialize a final field. Updated status files to hopefully address the test failures. Issue 29658. 
This reverts commit 12e93cc41e.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2953843003 .
 2017-06-22 13:48:57 -07:00
Martin Kustermann 42e2ae40e8 Update status file for dartk-checked (status files are out-dated due to builder being on FYI) 
Closes https://github.com/dart-lang/sdk/issues/29225

R=jensj@google.com

Review-Url: https://codereview.chromium.org/2948153005 .
 2017-06-22 15:36:30 +02:00
Ryan Macnak 095ff155fd VM: Allow trailing comma in assert statements. 
Issue #29959

R=regis@google.com

Review-Url: https://codereview.chromium.org/2946173002 .
 2017-06-21 09:08:16 -07:00
Jens Johansen 202306f39b [kernel] Fix loading of type argument in catch. 
Catch simply gave NullConstant as arguments to _instanceOf,
now I've copied what the IsExpression does, and made
LoadInstantiatorTypeArguments actually work in this case
(by filling out the scopes_->this_variable value,
by actually visiting the catch guard in the scope builder
rather than skipping it).

Fixes #29553.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2938173002 .
 2017-06-21 10:56:21 +02:00
Jens Johansen 29036d398b [kernel] Fix loss of supertype arguments. 
Before this, if a generic class was instantiated with only dynamic,
TypeArgument::null would be used as the type argument, ignoring
types from the super.
Now it only returns TypeArguments::null if the class directly gives all
type arguments (and they are all dynamic).

Fixes #29537

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2941983002 .
 2017-06-21 10:22:40 +02:00
Alan Knight 12e93cc41e Revert "Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658." 
This reverts commit 9755a98b00.

BUG=

Review-Url: https://codereview.chromium.org/2949943002 .
 2017-06-20 15:25:55 -07:00
Ben Konyi 9755a98b00 Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658. 
BUG=
R=zra@google.com

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
Review-Url: https://codereview.chromium.org/2947043002 .
 2017-06-20 14:40:36 -07:00
Jens Johansen 5472eb7831 [kernel] Don't emit field initializers in a redirecting constructor 
BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2940323002 .
 2017-06-20 13:54:25 +02:00
Jens Johansen c649557584 [kernel] Check type for list literals 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2949493002 .
 2017-06-20 13:04:08 +02:00
Ben Konyi a4a227e375 Revert "Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658." 
This reverts commit b5cff3f68f.

TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2944223002 .
 2017-06-19 17:23:01 -07:00
Ben Konyi b5cff3f68f Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658. 
BUG=
R=asiva@google.com

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
Review-Url: https://codereview.chromium.org/2939553005 .
 2017-06-19 12:07:37 -07:00
Jens Johansen 0a1583aa04 [kernel] Fix assert message. 
This mimics the behaviour of the source-based pipeline,
i.e. instead of "manually" calling _AssertionError._create and giving
the correct parameters (wrong parameters, actually), use the helper
method _AssertionError.ThrowNew.

BUG=
R=ahe@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/2940283002 .
 2017-06-16 12:28:18 +02:00
Jens Johansen dc72d9c34e Update language_kernel.status for closed issue. 
BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2940073002 .
 2017-06-15 13:41:13 +02:00
Peter von der Ahé 6302a5b31b Implement metadata on classes and additional semantic checks. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2938793002 .
 2017-06-14 14:59:53 +02:00
Peter von der Ahé 5f3fd3060b Restore status file comment. 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2939713002 .
 2017-06-14 08:31:37 +02:00
Peter von der Ahé 3c17c44d52 Implement metadata on methods and fields. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2935993002 .
 2017-06-14 08:25:17 +02:00
Peter von der Ahé db2e915aac Improve recovery from compile-time errors. 
R=danrubel@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2938573002 .
 2017-06-13 16:00:15 +02:00
Jens Johansen 76336b225f [kernel] Streaming ScopeBuilder 
The old ScopeBuilder is replaced with StreamingScopeBuilder
that does not use the Ast.

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2886873008 .
 2017-06-13 11:39:31 +02:00
Peter von der Ahé ea30fb6a0d Follow-up to CLs 2933723002 and 2932973003. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2933813002 .
 2017-06-13 09:45:41 +02:00
Peter von der Ahé a78250d931 Support metadata on local variables. 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2936503002 .
 2017-06-13 09:15:54 +02:00
Peter von der Ahé 092ef81f95 Complain about cyclic typedefs. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2931303002 .
 2017-06-13 09:13:23 +02:00
Peter von der Ahé 8da7993d63 Attempt to instantiate an enum class is a compile-time error. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2935593002 .
 2017-06-13 09:12:51 +02:00
Peter von der Ahé f559a6d1e9 Throw NSM on unresolved factory redirection. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2933733002 .
 2017-06-13 09:12:20 +02:00
Bob Nystrom e5263f0c40 Removed uses of removed negated status variables. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2935883002 .
 2017-06-12 16:04:18 -07:00
Peter von der Ahé 080a25f3a6 Various semantic checks on field initializers. 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2929383002 .
 2017-06-12 11:15:49 +02:00
Peter von der Ahé 2867303232 Various issues with duplicated names. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2934713002 .
 2017-06-12 11:11:45 +02:00
Peter von der Ahé 0c7d657333 Complain about duplicated defer. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2933723002 .
 2017-06-12 10:33:40 +02:00
Peter von der Ahé 35d77460e4 Various semantic checks regarding const and final. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2932973003 .
 2017-06-12 10:27:22 +02:00
Peter von der Ahé 96e494d534 Complain about external methods with a body. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2930093002 .
 2017-06-10 10:13:04 +02:00
Peter von der Ahé 043c0096ad Complain about use before declaration. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2924423003 .
 2017-06-10 10:12:18 +02:00