Commit Graph

7 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library.
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library."
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library.
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b)
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 17:19:58 +00:00
ager@google.com d0e409e89c Fix type annotation error in test.
R=floitsch@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10693163

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9592 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 13:22:58 +00:00
ager@google.com a0a3931bcf Fix bug in recompilation handling.
The recompilation infrastructure would set the propagated type of
operations just before code generation (skipping type propagation and
check insertion). This fixes that by splitting the recompilation
handling into two parts. One that is used only to register
recompilation candidates and one that is used to propagate the field
types for recompilation candidates. The one that propagates types is
only used when directly followed by type-propagation and check
insertion.

Remove the graph.highTypeLikelyhood flag which forced the use of
speculative type assumptions for everything if there was a field with
a likely type. That seems too aggressive to me.

R=floitsch@google.com
BUG=
TEST=language/field_optimization3_test.dart

Review URL: https://chromiumcodereview.appspot.com//10702167

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9591 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 13:11:07 +00:00