There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
Adds support for:
- Type literals
- By-value reference to top-level or static function
- Const constructor invocation inside const literal list or map
Nested const expressions are linearized to LetPrims, and we rely on the dart_tree to inline all primitives (since non-const variable references may not occur in a const expression).
There are still a bunch of constants that we support but don't actually treat as constants. Reference to top-level constants are still treated as a getter invocations, for instance.
We bail out on local constant declarations since they must either be inlined at multiple places or we must generate a constant declaration for them.
BUG=
R=kmillikin@google.com, sigurdm@google.com
Review URL: https://codereview.chromium.org//348053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37585 260f80e4-7a28-3924-810f-c04153c831b5
Jacob Richman