Commit Graph

4 Commits

Author SHA1 Message Date
Bob Nystrom 14011f47e3 Resurrect deleted language tests.
They're back from the grave, and ready to party!

Change-Id: I088134a9be7ecabf1fbf751c015a656a15cabff9
Reviewed-on: https://dart-review.googlesource.com/12821
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-11 17:47:11 +00:00
Morten Krogh-Jespersen 312ce6d002 Migrating another batch of tests to dart 2.
Start:
./language[_strong]/closure_side_effect_test.dart
End:
./language[_strong]/compile_time_constant2_test.dart

Except for tests/language_2/closure_type_test.dart, all other files has been copied automatically by the tool.

R=jcollins@google.com, whesse@google.com

PS: Forgot to run git cl upload command right after the migrate_tool, which I should have done, to make the automatic and manual changes clearer.
Review-Url: https://codereview.chromium.org/3002573002 .
2017-08-16 11:51:42 +02:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
asgerf@google.com 7f4ac7d27e dart2dart: Support for inner functions in new IR.
In CPS, closure variables are modeled as ref cells. In tree, variables
are in scope within inner functions and closure variables are handled directly.

In Dart, a function must be declared if it has a return type or is recursive.
Therefore tree now has both FunctionExpression and FunctionDeclaration, the latter
is mainly to be used for functions that cannot occur in expression context.

The CPS also has two ways of creating functions, CreateFunction and DeclareFunction,
but here the latter is only strictly necessary for recursive function.

The CL also contains quite a bit of other code improvements that came along.

BUG=
R=kmillikin@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//366853007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38005 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 10:09:16 +00:00