Commit Graph

6 Commits

Author SHA1 Message Date
Siva Annamalai 4ba69c4df5 Fixes for some strong mode issues in the isolate tests. Not able to turn
these tests on by default yet because of an issue in the stacktrace
package (see issue 31764)

Change-Id: Ifeb5dc4fc85e7d83b3011948133ce6d2a1998248
Reviewed-on: https://dart-review.googlesource.com/29480
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-01-05 06:19:33 +00:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
lrn@google.com 1b208bd6e6 Update Isolate API.
Remove AS_EVENT as priority of ping/kill. It wasn't very usable or predictable.
Make priority consistently named and a named parameter.
Add response object to ping/addExitListener so it doesn't have to send null.
This is useful for cases where you want to use the same receive port for
multiple purposes.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1074223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45092 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 10:29:54 +00:00
lrn@google.com 19bcddfc6b Add Isolate.kill().
This sends a kill signal to the isolate, which is allowed to terminate
the isolate as soon as possible, and at the latest before the next event.

R=ajohnsen@google.com, floitsch@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34234

Review URL: https://codereview.chromium.org//190013005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34960 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 07:22:48 +00:00
lrn@google.com b81c6a25f5 Revert "Add Isolate.kill()."
Either ping or kill tests fail in some cases.

Review URL: https://codereview.chromium.org//208193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34247 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 13:20:51 +00:00
lrn@google.com ac43cac578 Add Isolate.kill().
This sends a kill signal to the isolate, which is allowed to terminate
the isolate as soon as possible, and at the latest before the next event.

R=ajohnsen@google.com, floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//190013005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34234 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 08:56:03 +00:00