Commit Graph

15 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Sigmund Cherem e6f6ce9743 fix safari test
Apparently my approach to use wss didn't work to exercise the error codepath. This change makes us excersize errors. After testing this in Safari though, I coudln't reproduce the issue, so I remove the note about this being a regression test for the original issue.

Review URL: https://codereview.chromium.org/1513363003 .
2015-12-10 16:02:27 -08:00
Sigmund Cherem db4195c752 Fix #19137: handle when regexp doesn't match in constructorNameFallback
R=sra@google.com

Review URL: https://codereview.chromium.org/1510763006 .
2015-12-10 12:28:12 -08:00
kevmoo@google.com 4283c3e41e using unittest via package import
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
jacobr@google.com 97075e2d22 WebSocket security checks changed a bit with the latest Dartium roll so the test failed with the following error when protocol 'chat' was used. failed: Error during WebSocket handshake: Sec-WebSocket-Protocol mismatch"
I've switched the WebSocket constructor test to pass in the protocol 'chat' so that coverage for passing in a protocol is not impacted.

Note that chrome dev channel reports the same error when a JS WebSocket is created with protocol 'chat' given the same scenario.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26496 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 00:33:54 +00:00
blois@google.com 6fad216eb7 Expanding WebSocket test
BUG=

Review URL: https://codereview.chromium.org//12465018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20797 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-02 16:45:09 +00:00
blois@google.com f2684ae979 Adding support checks for WebSocket.
BUG=

Review URL: https://codereview.chromium.org//11783069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16883 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 21:08:15 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg.
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
podivilov@google.com 064342cc5b Copy lib/dom tests that use dart:html to lib/html.
R=vsm@google.com

Review URL: https://chromiumcodereview.appspot.com//10178014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7124 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-28 10:34:16 +00:00