Terry Lucas
bc75856e54
Update getClientRects, removed xtab, removed bogus entry in dom.json,
...
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.
Fixed all tests using query and queryAll.
Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675
R=kevmoo@google.com
Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-03-27 20:45:33 +00:00
Jacob Richman
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
kevmoo@google.com
4283c3e41e
using unittest via package import
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//231413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
gram@google.com
981c4b11df
Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
...
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com
f7d27f2c64
Modified unittest to use new argument syntax.
...
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
efortuna@google.com
12c3bcdd4d
Take three of FooList to List<Foo> again.
...
Review URL: https://codereview.chromium.org//10947040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12596 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 19:49:11 +00:00
efortuna@google.com
1bc6009f30
Revert r12581.
...
TBR
Review URL: https://codereview.chromium.org//10952032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12590 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 19:03:59 +00:00
efortuna@google.com
7638353d5c
Take two of making FooList List<Foo>.
...
Review URL: https://codereview.chromium.org//10952008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12581 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 17:50:47 +00:00
efortuna@google.com
2f5f36c87c
Revert 12414.
...
Review URL: https://codereview.chromium.org//10910301
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12416 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-16 00:27:43 +00:00
efortuna@google.com
2c6d3d823d
Part one of Converting DOMList types like FooList to List<Foo>.
...
This makes the immutable list types actually inherit from list, but to actually make the
FooList types invisible to the user is going to take a lot more work.
Additionally "lists" with extra methods will need to be unified for consistency.
Review URL: https://codereview.chromium.org//10914293
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12414 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 22:15:41 +00:00
efortuna@google.com
9163dfe93c
revert 1204. Will investigate when I get a chance.
...
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com
383488ec4f
Update unittest to new package layout.
...
Review URL: https://codereview.chromium.org//10917275
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com
659a57df3e
Revert "Make unittest follow the new package layout."
...
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.
Review URL: https://codereview.chromium.org//10911318
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com
2ba81033a6
Make unittest follow the new package layout.
...
Review URL: https://codereview.chromium.org//10918240
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
dgrove@google.com
c265902bea
Move unittest from lib to pkg.
...
Review URL: https://chromiumcodereview.appspot.com//10836241
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
podivilov@google.com
064342cc5b
Copy lib/dom tests that use dart:html to lib/html.
...
R=vsm@google.com
Review URL: https://chromiumcodereview.appspot.com//10178014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7124 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-28 10:34:16 +00:00