2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
4283c3e41e
using unittest via package import
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//231413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
1784f2dd68
Fix streams_test.
...
Review URL: https://codereview.chromium.org//14930007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22427 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 16:52:56 +00:00
f41508d33b
Added new version of reduce.
...
Removed min/max and uses of min/max.
Review URL: https://codereview.chromium.org//14071002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21258 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 08:32:31 +00:00
bef8ebb5f6
Add Iterable.fold (and Stream.fold) which replace reduce.
...
For now this is just a copy. In a next step we will change the behavior of
`reduce`.
BUG= http://dartbug.com/9536
Review URL: https://codereview.chromium.org//13548002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20978 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 16:12:40 +00:00
2cc6ad6965
Stop expecting errors when pausing, resuming or canceling a canceled stream.
...
Also stop expecting an error if resuming an unpaused stream.
It's better to forgive.
Review URL: https://codereview.chromium.org//13529007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20863 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-03 14:14:32 +00:00
65718c56df
Rename XMatching to XWhere.
...
For example firstMatching -> firstWhere.
BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337
Review URL: https://codereview.chromium.org//12537009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
03f5a66836
Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
...
This reverts r18591.
Review URL: https://codereview.chromium.org//12295009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
0e0473d33a
Unbreak pub:
...
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."
This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.
Revert "Remove deprecated mappedBy."
This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.
BUG=dartbug.com/8560
Review URL: https://codereview.chromium.org//12286004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 18:38:42 +00:00
0672317bec
Remove deprecated mappedBy.
...
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576
Review URL: https://codereview.chromium.org//12212213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
ad839e6957
Revert "Remove deprecated mappedBy."
...
This reverts commit 18575.
Review URL: https://codereview.chromium.org//12207205
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
b37100770b
Remove deprecated mappedBy.
...
Review URL: https://codereview.chromium.org//12212213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
87867a746c
Fixing DOM's EventStream.isBroadcast
...
BUG=8457
Review URL: https://codereview.chromium.org//12263046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18541 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 21:30:31 +00:00
9b23dff467
Reapply "Rename mappedBy to map."
...
This reverts commit r17907.
TBR.
Review URL: https://codereview.chromium.org//12090093
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
b1a118d5ce
Revert "Rename mappedBy to map."
...
This reverts commit 17899.
Review URL: https://codereview.chromium.org//12087103
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
0dc2f4b1ba
Rename mappedBy to map.
...
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.
BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982
Review URL: https://codereview.chromium.org//12086062
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
a807c1fb7c
Fixing streams test.
...
Fails on dartium because of a missing param for the reduce test.
TBR
BUG=
Review URL: https://codereview.chromium.org//12066006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17725 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 18:04:47 +00:00
ffc85c7428
Fixing type check error using Stream.take in dart2js checked mode.
...
Encountered this issue converting dart:html tests over to streams.
BUG=
Review URL: https://codereview.chromium.org//12061002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17719 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 16:58:31 +00:00
d2aa044d2b
Deprecating old DOM event APIs.
...
This also exposes EventTarget.dispatchEvent. We had discussed naming this as 'dispatch', but it seems a bit safer to use 'dispatchEvent' to avoid potential name conflicts.
BUG=
Review URL: https://codereview.chromium.org//12047054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17595 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 19:42:02 +00:00
b94a1065cb
Fixing the DOM event streams test to work on FF and IE.
...
I was using the focus event since it's supposed to be synchronous and it's nice to test with a browser-generated event for completeness, but it turns out the IE and FF<18 implement this as an async event (FF 18 appears to be correct).
Just changed the test to manually trigger the event which is a fairly close approximation.
BUG=7888
Review URL: https://codereview.chromium.org//11875022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17102 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 22:57:33 +00:00
a4977979c4
Adding streams to dart:html.
...
This exposes all DOM events as streams. This keeps the current DOM event syntax as well, I'd like to make sure this API is stable before deprecating the old syntax, then we'll remove it a while after that.
I made an initial stab at getting the event types correct for the streams, though it's not documented very well and frequently inconsistent between browsers. Hopefully it's close, and I imagine there will be changes to come.
BUG=
Review URL: https://codereview.chromium.org//11824072
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17028 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 20:19:28 +00:00
Jacob Richman