Commit Graph

20 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Jacob Richman 6a7d6c385e Add comments
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
alanknight@google.com b59c1f55c9 Move test to a separate group and suppress on Dartium
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//893653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43343 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 19:06:18 +00:00
alanknight@google.com 78e00035f1 Check for null prototype in isJavaScriptSimpleObject
BUG=
R=floitsch@google.com, sra@google.com

Review URL: https://codereview.chromium.org//886673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43340 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 17:42:10 +00:00
blois@google.com ab7e487be7 Fixing iframe.contentWindow.postMessage passing incorrect data
It should have been doing the structured clone algorithm on the message being posted (window.postMessage does this), but was not.

BUG=18956
R=efortuna@google.com

Review URL: https://codereview.chromium.org//296153013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36581 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 20:01:52 +00:00
kevmoo@google.com 4283c3e41e using unittest via package import
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
kevmoo@google.com b16286c0e1 tests/html: removed usage of deprecated unittest features
R=sigmund@google.com

Review URL: https://codereview.chromium.org//226903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34755 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-05 01:01:48 +00:00
sra@google.com 534221778e Redo "dart2js typed data constructor argument validation"
Fix the postmessage test which has an error encouraged by issue 10136

Patch Set 1 is previously reviewed code.

Review URL: https://codereview.chromium.org//129003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31625 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 20:42:04 +00:00
jmesserly@google.com 28c2096ffa use .append instead of .nodes.add
R=blois@google.com

Review URL: https://codereview.chromium.org//14883008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22652 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 20:57:52 +00:00
ager@google.com 431954b584 Rename dart:typeddata to dart:typed_data.
R=asiva@google.com, floitsch@google.com, srdjan@google.com
BUG=

Review URL: https://codereview.chromium.org//14426006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21871 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 11:54:54 +00:00
ager@google.com 7f79491c06 Move to new dart:typeddata types
Mads: if you land this, please rerun go.sh from tools/dom/scripts to regenerate html_dart2js.dart.  I didn't include it here to make this patchable.

Stephen: I still need to run the perf tests we talked about to sanity check.

Review URL: https://codereview.chromium.org//14367012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21789 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 08:22:51 +00:00
blois@google.com 710d8804c1 Just grouping the code to narrow FF's failure down to the specific scenario which is failing.
BUG=

Review URL: https://codereview.chromium.org//12706024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20214 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 16:30:54 +00:00
antonm@google.com dc577cc0ba Add special treatement for typed arrays...
...and a test for views and buffers serialization.

R=ager@google.com,blois@google.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//12670003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20061 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 08:31:49 +00:00
blois@google.com f46672cb73 Converting tests over to using event streams.
BUG=

Review URL: https://codereview.chromium.org//12040059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17735 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 23:31:15 +00:00
blois@google.com 2688c60a05 Dartifying members.
Updating dart:html to generate members which follow the Dart naming guidelines.

BUG=4830

Review URL: https://codereview.chromium.org//11418075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15405 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 17:38:23 +00:00
floitsch@google.com 3e2f323981 Dynamic -> dynamic.
Review URL: https://codereview.chromium.org//11312237

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14898 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 15:33:25 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
ajohnsen@google.com 7e451fc1a4 Move SplayTreeMap from coreimpl to collection.
BUG=

Review URL: https://codereview.chromium.org//11304007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14178 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 09:40:54 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
sra@google.com 5c1a93e251 Convert between Dart and JavaScript SerializedScriptValues on postMessage.
Review URL: https://codereview.chromium.org//11065003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13311 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 19:19:16 +00:00