Commit Graph

23 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc.
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
2016-12-19 15:00:55 -08:00
Jacob Richman 595ec1d785 Make is checks work on JavaScriptFunction objects.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2110273003 .
2016-07-01 11:31:25 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Harry Terkelsen f01e8b3e73 dart2js cps: Update status file for html tests
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1585943004 .
2016-01-15 12:16:36 -08:00
Jacob Richman 8d793ca758 Dartium typed js interop work dart repo side of the change. Also tries to get
BUG=

Review URL: https://codereview.chromium.org/1391353002 .
2015-10-07 11:44:50 -07:00
Alan Knight 07b2ddd401 Preserve identity of Dart wrappers on DOM objects
BUG=

Review URL: https://codereview.chromium.org/1380963003 .
2015-10-01 14:04:01 -07:00
kevmoo@google.com 4283c3e41e using unittest via package import
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
vegorov@google.com 0470bef7e8 Fix html/js test on Dartium.
Don't use identity check on strings, use equality instead.

R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//136953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32245 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 13:51:59 +00:00
vegorov@google.com 0b33ed017c Ensure that dart:js does not attempt to load cached proxies from prototypes.
dart:js caches proxies on the object itself thus it must guard loading cached proxy from the object with a hasOwnProperty check.

R=justinfagnani@google.com
BUG=dart:16199

Review URL: https://codereview.chromium.org//138723006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32244 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 13:01:27 +00:00
justinfagnani@google.com b18fb9f535 Fix js_test on IE9
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//53873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29638 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 03:48:37 +00:00
justinfagnani@google.com 0dce271821 Add Event, HtmlCollection, NodeList and Window to transferrable types
BUG=

Review URL: https://codereview.chromium.org//46533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29623 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 01:43:38 +00:00
jacobr@google.com fa8b243f62 Add JsArray
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//41163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29393 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 20:46:36 +00:00
justinfagnani@google.com 2f0a7104a7 Add test for calling emulated functions from JS
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//35533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29267 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 18:25:24 +00:00
justinfagnani@google.com 45e20b5921 "Fix" dart:js tests in IE9
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//35173004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29125 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 21:12:36 +00:00
jacobr@google.com 5ee178076a A few API changes:
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
 - Throw on types other than Map and Iterable.
 - Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.

Still to do: Reach a conclusion on Serializable

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//27514003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:36:10 +00:00
justinfagnani@google.com e32d5c24c3 Cleanup JS() expressions.
New Constructor for JsObject that preserves the correct prototype.
Type check user-supplied values that pass through to JS().
Don't call _convertToJs(this)

Based on: https://chromiumcodereview.appspot.com/26092003/

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26270003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28813 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:13:40 +00:00
justinfagnani@google.com 03eb80a189 Maintain referential integrity of proxy instances in dart:js
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26092003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28686 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:43:16 +00:00
justinfagnani@google.com cee2b116ce Revert "Maintain referential integrity of proxy instances in dart:js"
This reverts commit bf87105c535cd2f6fa28904547b4e9f2804bc301.

BUG=

Review URL: https://codereview.chromium.org//26742008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28557 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 21:28:15 +00:00
justinfagnani@google.com b2316c569a Maintain referential integrity of proxy instances in dart:js
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26092003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28547 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:24:18 +00:00
justinfagnani@google.com c282ae9d65 Cache the context proxy. Don't use window for global 'this'.
BUG=
R=ahe@google.com, alexandre.ardhuin@gmail.com, vsm@google.com

Review URL: https://codereview.chromium.org//25138003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28181 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:06:57 +00:00
vsm@google.com 699bf601f7 Fix dart:js test for IE
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//19235003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25038 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-16 00:02:52 +00:00
vsm@google.com a81a6fcce6 RFC: introduce dart:js
This is a port of js-interop with an optimized dart2js compilation.
It also gets rid of noSuchMethod.
I also made some renamings inspired by https://github.com/dart-lang/js-interop/issues/68

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//15782009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25018 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 19:44:44 +00:00