Commit Graph

22 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase.
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase."
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase.
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-11-14 11:13:04 +00:00
Terry Lucas f27144d7b5 Roll 50: Updated for push to origin/master.
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Jacob Richman 864b64fd5e Strong html
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
kevmoo@google.com 5952d7a067 Upgrading tests with unittest deprecations
R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//218273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34569 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 18:33:18 +00:00
kevmoo@google.com b565b6296f pkg/unittest: Run tests in zones
Added a changelog to unittest
Deprecated a number of methods made extraneous by zone change
Fixed related issues in html and html tests

BUG= https://code.google.com/p/dart/issues/detail?id=13277
BUG= https://code.google.com/p/dart/issues/detail?id=16541
R=sigmund@google.com

Review URL: https://codereview.chromium.org//133313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32400 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 01:34:20 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask.
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 15:52:17 +00:00
floitsch@google.com 2b550970e6 Run DOM callbacks in the zone they are coming from.
This CL is an adapted version of: https://chromiumcodereview.appspot.com/23054006/

R=blois@google.com

Review URL: https://codereview.chromium.org//24509004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27961 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 16:50:25 +00:00
jmesserly@google.com 28c2096ffa use .append instead of .nodes.add
R=blois@google.com

Review URL: https://codereview.chromium.org//14883008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22652 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 20:57:52 +00:00
jmesserly@google.com 6f85889ab7 fix a bug in the Event constructor
R=blois@google.com

Review URL: https://codereview.chromium.org//14387011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22130 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 17:18:55 +00:00
blois@google.com f46672cb73 Converting tests over to using event streams.
BUG=

Review URL: https://codereview.chromium.org//12040059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17735 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 23:31:15 +00:00
blois@google.com edf1d5149f - Changing event constructors to use named parameters.
- Making more parameters optional.
- Converting remaining init*Event calls to constructors.

BUG=

Review URL: https://codereview.chromium.org//12025027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17488 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 19:43:21 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg.
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
podivilov@google.com 064342cc5b Copy lib/dom tests that use dart:html to lib/html.
R=vsm@google.com

Review URL: https://chromiumcodereview.appspot.com//10178014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7124 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-28 10:34:16 +00:00