dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

26 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
Alan Knight 4e790fef3d appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Committed: https://github.com/dart-lang/sdk/commit/930a40daa50a93adfce8786f4d7ef25e06324dda

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-16 10:30:51 -07:00
Alan Knight 610edadff2 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 930a40daa5.

BUG=

Review URL: https://codereview.chromium.org//1230203005 .
 2015-07-13 15:32:17 -07:00
Alan Knight 930a40daa5 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-13 12:50:49 -07:00
Alan Knight 1e8a275a20 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 560f12bb21.

	modified:   sdk/lib/html/dart2js/html_dart2js.dart
	modified:   sdk/lib/html/dartium/html_dartium.dart
	modified:   tests/html/element_add_test.dart
	modified:   tools/dom/templates/html/impl/impl_Element.darttemplate

BUG=

Review URL: https://codereview.chromium.org//1230553003 .
 2015-07-08 12:19:30 -07:00
Alan Knight 560f12bb21 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-08 10:16:37 -07:00
aprelev@gmail.com 23efbfec7e Improve document.appendText test as a follow up to "Fix Try Dart newline handling on IE11". 
R=ahe@google.com

Review URL: https://codereview.chromium.org//512043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39684 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-28 22:35:50 +00:00
aprelev@gmail.com 6e19ede429 Fix Try Dart newline handling on IE11. 
BUG=dartbug.com/20593
R=ahe@google.com, blois@google.com, efortuna@google.com

Review URL: https://codereview.chromium.org//494253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39626 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-27 23:12:19 +00:00
kevmoo@google.com 4283c3e41e using unittest via package import 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-09 19:42:11 +00:00
blois@google.com 5690418a11 Fixing a bunch of dartc errors in dart:html tests. 
BUG=

Review URL: https://codereview.chromium.org//11644061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16413 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-21 01:38:08 +00:00
blois@google.com 911a7ec284 Changes to make it easier to add elements. 
BUG=3584

Review URL: https://codereview.chromium.org//11316121

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15469 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-28 20:28:03 +00:00
blois@google.com 2688c60a05 Dartifying members. 
Updating dart:html to generate members which follow the Dart naming guidelines.

BUG=4830

Review URL: https://codereview.chromium.org//11418075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15405 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-27 17:38:23 +00:00
blois@google.com d1da6affdd Deprecating Element.elements for Element.children. 
BUG=3584

Review URL: https://codereview.chromium.org//11413071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15118 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 23:01:13 +00:00
efortuna@google.com 6dc3ba672a Rename addHTML to addHtml. 
Review URL: https://codereview.chromium.org//11409003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14921 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-14 21:55:27 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions. 
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax. 
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-26 22:52:03 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance. 
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout. 
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout." 
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout. 
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-14 18:22:24 +00:00
lrn@google.com f52c24b62f Rename NoSuchMethodException to NoSuchMethodError. 
Moved NoSuchMethodError to errors.dart.
No changes in co19 tests, but test status updated.

Review URL: https://chromiumcodereview.appspot.com//10909166

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12172 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-11 09:52:25 +00:00
blois@google.com 4d29efad2f Implementing polyfills for insertAdjacent* to get them working on FF. 
Refactoring IE test to pass on IE9.

This is essentially the same CL as before, but had to roll back because it broke on IE9. Specifically, insertAdjacentHTML is not supported on IE9 on table elements. It is fully supported on IE10.

BUG=3600,3685

Review URL: https://chromiumcodereview.appspot.com//10883070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11480 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-28 21:49:41 +00:00
blois@google.com 77796d2ee3 Revert "Implementing polyfills for insertAdjacent* to get them working on FF." 
This reverts commit 802cf18b82edc16584b12e6f8b8ecac2801a8051.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10871088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11405 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-27 19:04:02 +00:00
blois@google.com 19068aefb9 Implementing polyfills for insertAdjacent* to get them working on FF. 
Implementing addHTML and addText.

BUG=3600,3685

Review URL: https://chromiumcodereview.appspot.com//10879080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11399 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-27 17:27:03 +00:00
blois@google.com ef7c57676a Revert "Adding Element.AddHTML and Element.addText methods." 
This reverts commit f1b1dc4f51ebbfa5f37e65cff0a638c80217f5d9.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10878027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11251 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-23 19:04:27 +00:00
blois@google.com 810807a7b3 Adding Element.AddHTML and Element.addText methods. 
These are to make it easier to append HTML and text to existing DOM nodes.

BUG=3685

Review URL: https://chromiumcodereview.appspot.com//10854208

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11249 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-23 18:36:29 +00:00