Commit Graph

34 Commits

Author SHA1 Message Date
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json,
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-27 20:45:33 +00:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
kevmoo@google.com 4283c3e41e using unittest via package import
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
blois@google.com ab50cfcc68 Adding annotations for native types of type Object or dynamic.
Also added generation warnings to try to detect these.

BUG=10946
R=sra@google.com

Review URL: https://codereview.chromium.org//16638013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23875 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 19:46:57 +00:00
jmesserly@google.com 28c2096ffa use .append instead of .nodes.add
R=blois@google.com

Review URL: https://codereview.chromium.org//14883008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22652 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 20:57:52 +00:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library.
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library."
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library.
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
blois@google.com 457e364487 Removing many Element APIs from DocumentFragment
Many Element APIs made no sense on DocumentFragment since it no longer derives from Element (as of M2).

BUG=7858

Review URL: https://codereview.chromium.org//12039072

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17609 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 22:50:03 +00:00
blois@google.com 105732cdac Removing test for method which was removed.
with http://code.google.com/p/dart/source/detail?r=16829 I removed DocumentFragment.matches, but forgot to update this test.

TBR=jmesserly
BUG=

Review URL: https://codereview.chromium.org//11820013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16831 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 01:47:44 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
blois@google.com 5690418a11 Fixing a bunch of dartc errors in dart:html tests.
BUG=

Review URL: https://codereview.chromium.org//11644061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16413 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:38:08 +00:00
blois@google.com 5bc653278a Dartifying dart:html type names.
BUG=

Review URL: https://codereview.chromium.org//11419300

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15739 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 17:48:38 +00:00
blois@google.com 2688c60a05 Dartifying members.
Updating dart:html to generate members which follow the Dart naming guidelines.

BUG=4830

Review URL: https://codereview.chromium.org//11418075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15405 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 17:38:23 +00:00
blois@google.com d1da6affdd Deprecating Element.elements for Element.children.
BUG=3584

Review URL: https://codereview.chromium.org//11413071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15118 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:01:13 +00:00
blois@google.com f89aca9976 Removing Element.rect.
BUG=

Review URL: https://codereview.chromium.org//11367040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14720 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 01:29:09 +00:00
lrn@google.com 2208fcd208 Change NotImplementedException to UnimplementedError.
Retain a NotImplementedException type for backwards compatibility.
This class will be removed soon.
The constructor of UnimplementedError is currently const in order to
support the NotImplementedException. That will be fixed too.

Review URL: https://codereview.chromium.org//11358060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14467 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 13:18:37 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
blois@google.com 1919b5a3ad Removing ElementList.
This includes fixes to make it work properly on Dartium checked (_ChildrenElementList.filter and _FrozenElementList.filter no longer use typed lists).

BUG=2712

Review URL: https://codereview.chromium.org//11016015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13133 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 19:51:08 +00:00
blois@google.com c6c2918caf Revert "Removing ElementList (splitting out removing NodeList into a separate CL)."
This reverts commit 13076 because of issues with queryAll in checked mode.

TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//11033007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13083 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-01 19:03:57 +00:00
blois@google.com 2d71772ff0 Removing ElementList (splitting out removing NodeList into a separate CL).
BUG=2712

Review URL: https://codereview.chromium.org//10979063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13076 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-01 17:52:52 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
kasperl@google.com 8bd4bf096b Update almost all tests (except co19) to use the new try-catch syntax.
R=ngeoffray@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10891020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11492 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-29 08:11:41 +00:00
blois@google.com b128fea156 Adding .toggle method to Element.classes to match the JS element.classList.toggle method.
BUG=1063

Review URL: https://chromiumcodereview.appspot.com//10868026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11420 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-27 21:22:11 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg.
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
gram@google.com 9248731b39 Change asyncTest/callbackDone style tests to use the new expectAsync/
guardAsync form, and fix a couple of issues in the unit test library
related to these.
Note: this CL covers the changes in the tests directory. There are a few
changes in utils and samples; these will de done in a separate CL.
Review URL: https://chromiumcodereview.appspot.com//10412015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7877 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-22 20:37:25 +00:00
sigmund@google.com daef678742 test renaming overhaul: step 4 client tests
Review URL: https://chromiumcodereview.appspot.com//10191033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7041 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-26 20:09:35 +00:00