Commit Graph

27 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
kevmoo@google.com 4283c3e41e using unittest via package import
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
kevmoo@google.com b16286c0e1 tests/html: removed usage of deprecated unittest features
R=sigmund@google.com

Review URL: https://codereview.chromium.org//226903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34755 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-05 01:01:48 +00:00
kevmoo@google.com 5952d7a067 Upgrading tests with unittest deprecations
R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//218273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34569 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 18:33:18 +00:00
efortuna@google.com 842b1f41c3 Make type parameter in toDataUrl have an optional default value as per the spec.
BUG=
R=amouravski@google.com

Review URL: https://codereview.chromium.org//18500010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24753 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 21:19:16 +00:00
jmesserly@google.com 28c2096ffa use .append instead of .nodes.add
R=blois@google.com

Review URL: https://codereview.chromium.org//14883008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22652 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 20:57:52 +00:00
efortuna@google.com ae82b45193 Rename context2d to context2D.
BUG=

Review URL: https://codereview.chromium.org//13726010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21006 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 23:16:48 +00:00
antonm@google.com 115ff4b40b Map enums to strings.
R=blois@google.com,podivilov@chromium.org

Review URL: https://codereview.chromium.org//13704011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20984 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 17:00:25 +00:00
antonm@google.com 6514936a7a Disable some tests due to Chrome roll.
Those test exercise getters which work now with enums
in Chromium.

TBR=ager@google.com,blois@google.com,podivilov@chromium.org,vsm@google.com

Review URL: https://codereview.chromium.org//13647005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20926 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-04 17:09:24 +00:00
blois@google.com f46672cb73 Converting tests over to using event streams.
BUG=

Review URL: https://codereview.chromium.org//12040059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17735 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 23:31:15 +00:00
antonm@google.com f68706e4c4 Initial work on ImageData.data.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//12036013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17526 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 08:25:37 +00:00
blois@google.com b6bb355744 Adding test for toDataUrl.
Bug 7482 is saying that toDataUrl is not working properly, while investigating I noticed that we don't have any tests explicitly for it.

url_test uses toDataUrl but has additional functionality which causes it to not work on all platforms.

BUG=7482

Review URL: https://codereview.chromium.org//11571038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16300 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 01:23:46 +00:00
blois@google.com 2946cab0bd Updating test to use the most common syntax.
The test was using fairly outdated syntax for setting width/height.

BUG=6346

Review URL: https://codereview.chromium.org//11448034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15799 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 18:45:44 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
blois@google.com 8ad35fa9a6 Refactoring tests to run on Safari.
Basically there was redundancy between canvas_test and canvasrenderingcontext2d test, I removed this redundancy and kept the failing test in canvas_test, which is now essentially empty.

BUG=

Review URL: https://codereview.chromium.org//11085007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13363 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 17:46:59 +00:00
blois@google.com 845c13e426 Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants.
This is the same as the earlier CL for this, which failed because of dartium build issues which have since been fixed by Anton.

BUG=4592

Review URL: https://codereview.chromium.org//11028068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13361 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 16:15:23 +00:00
blois@google.com 9cfdc2dddc Revert "Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants."
This reverts commit 12972 because it was failing in dartium.

TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//10996048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12973 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 17:13:35 +00:00
blois@google.com ab684728a8 Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants.
Original CL failed because:
Additional tests were marked as fail because they used the broken behavior. I've fixed these tests and removed their exclusions.

Argument types were mismatched, causing Dartium to fail.

BUG=4592

Review URL: https://codereview.chromium.org//10984055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12972 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 16:39:36 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg.
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
gram@google.com 9b79e27e17 Some unit test fixes:
Fixed a couple of issues in the ensureInitialized() function.
Added expectAsyncUntil methods to support callbackDone style tests.
Split the matcher tests up so that we can exclude those that use isInstance
from the environments where they don't work.
Eliminated the need for two functions calls in throws/throwsA.
Fixed some tests.
Changed some uses of Expect to expect.
Fixed a bug when using expectAsync with a count of zero.
Fixed a bug where we weren't updating the call count in invoke0/1/2.
Made expect behave sensibly in cases where the user doesn't supply a 
matcher (e.g. expect(foo, 0)). USing the predicate form with a 
reason now requires a named parameter.
Review URL: https://chromiumcodereview.appspot.com//10544167

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8753 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 23:17:57 +00:00
vsm@google.com f7011b8730 Some HTML API cleanup
This CL adds:

- A context2d getter to CanvasElement.
- A top-level query method.
- A top-level queryAll method.

TEST=query_test, canvas_test

Review URL: https://chromiumcodereview.appspot.com//10544111

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8591 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 03:01:04 +00:00
gram@google.com d2efc58b00 New expectation functions plus convert old tests to use these.
Review URL: https://chromiumcodereview.appspot.com//10441104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8355 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-06 20:15:58 +00:00
podivilov@google.com 064342cc5b Copy lib/dom tests that use dart:html to lib/html.
R=vsm@google.com

Review URL: https://chromiumcodereview.appspot.com//10178014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7124 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-28 10:34:16 +00:00