Jacob Richman
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
alanknight@google.com
604106c107
Add webkitAudioPannerNode as an optional name
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//873803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43149 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 20:27:23 +00:00
efortuna@google.com
8e07c04649
Update supported browser annotations for Firefox Web Audio.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//335453006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38244 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 18:06:35 +00:00
vsm@google.com
42f132e219
Another audiocontext_test fix
...
The OscillatorNode.type setter no longer throws an exception on an invalid string. It just ignores the value. See:
https://codereview.chromium.org/209423006/diff/100001/Source/modules/webaudio/OscillatorNode.idl
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//307483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36670 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 12:13:10 +00:00
vsm@google.com
995cdea488
Remove invalid portion of test
...
This API (the createBuffer overload) is now gone in Chrome 36. See upstream issue:
https://code.google.com/p/chromium/issues/detail?id=354133
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//299393008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36666 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 11:23:34 +00:00
kevmoo@google.com
4283c3e41e
using unittest via package import
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//231413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
rmacnak@google.com
de7c68ce3a
Test for OscillatorNode.type=. Fix bug in StringGetPeerHelper when passed an immediate object. Fix asserts when getting typed data address to allow for empty arrays.
...
BUG=http://dartbug.com/11984
R=asiva@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//28973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29049 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:12:09 +00:00
efortuna@google.com
f81052f2c8
Reapply expanding overloaded functions into separate functions.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18577002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
efortuna@google.com
3629744086
"Reverting 24655"
...
BUG=
Review URL: https://codereview.chromium.org//18277003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
efortuna@google.com
fc0df10d8b
Expand overloaded methods and optional parameters in the html library.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//16494002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
ager@google.com
431954b584
Rename dart:typeddata to dart:typed_data.
...
R=asiva@google.com , floitsch@google.com , srdjan@google.com
BUG=
Review URL: https://codereview.chromium.org//14426006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21871 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 11:54:54 +00:00
ager@google.com
d98c34fa8f
Fix audiocontext test
...
R=vsm@google.com
BUG=
Review URL: https://codereview.chromium.org//14365027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21796 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 09:45:00 +00:00
efortuna@google.com
4a500cdae0
Adjust AudioContextTest for Safari JS prototypes
...
BUG=
Review URL: https://codereview.chromium.org//12802007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20186 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 23:46:53 +00:00
efortuna@google.com
5d6e0608f7
Reapply making ScriptProcessorNode not an EventTarget.
...
BUG=
Review URL: https://codereview.chromium.org//11510013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20180 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 22:18:25 +00:00
efortuna@google.com
e1109ed077
Detect if webkitNotifications is available and remove webkit prefix (replaced
...
with "experimental").
BUG=
Review URL: https://codereview.chromium.org//11883025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17105 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 23:54:58 +00:00
blois@google.com
5bc653278a
Dartifying dart:html type names.
...
BUG=
Review URL: https://codereview.chromium.org//11419300
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15739 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 17:48:38 +00:00
blois@google.com
76b1800cd6
Splitting the Audio types out of the HTML library.
...
BUG=3108
Review URL: https://codereview.chromium.org//11280103
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15529 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 17:58:26 +00:00
gram@google.com
981c4b11df
Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
...
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
efortuna@google.com
9198bbc51b
Make new audionode names backwards compatible.
...
Review URL: https://codereview.chromium.org//11358042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14432 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 20:50:58 +00:00
efortuna@google.com
c5e480af62
Fix for audiogainnode/gain node naming in current Chrome and Safari.
...
Review URL: https://codereview.chromium.org//11345038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14310 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 21:12:52 +00:00
gram@google.com
f7d27f2c64
Modified unittest to use new argument syntax.
...
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
efortuna@google.com
9163dfe93c
revert 1204. Will investigate when I get a chance.
...
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com
383488ec4f
Update unittest to new package layout.
...
Review URL: https://codereview.chromium.org//10917275
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com
659a57df3e
Revert "Make unittest follow the new package layout."
...
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.
Review URL: https://codereview.chromium.org//10911318
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com
2ba81033a6
Make unittest follow the new package layout.
...
Review URL: https://codereview.chromium.org//10918240
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
kasperl@google.com
8bd4bf096b
Update almost all tests (except co19) to use the new try-catch syntax.
...
R=ngeoffray@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10891020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11492 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-29 08:11:41 +00:00
dgrove@google.com
c265902bea
Move unittest from lib to pkg.
...
Review URL: https://chromiumcodereview.appspot.com//10836241
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
gram@google.com
9b79e27e17
Some unit test fixes:
...
Fixed a couple of issues in the ensureInitialized() function.
Added expectAsyncUntil methods to support callbackDone style tests.
Split the matcher tests up so that we can exclude those that use isInstance
from the environments where they don't work.
Eliminated the need for two functions calls in throws/throwsA.
Fixed some tests.
Changed some uses of Expect to expect.
Fixed a bug when using expectAsync with a count of zero.
Fixed a bug where we weren't updating the call count in invoke0/1/2.
Made expect behave sensibly in cases where the user doesn't supply a
matcher (e.g. expect(foo, 0)). USing the predicate form with a
reason now requires a named parameter.
Review URL: https://chromiumcodereview.appspot.com//10544167
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8753 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 23:17:57 +00:00
podivilov@google.com
eaef938e51
Fix a bug in overload dispatch.
...
R=sra@google.com ,vsm@google.com
BUG=3261
TEST=html/audiocontext_test
Review URL: https://chromiumcodereview.appspot.com//10451054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8068 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-29 16:06:36 +00:00
podivilov@google.com
064342cc5b
Copy lib/dom tests that use dart:html to lib/html.
...
R=vsm@google.com
Review URL: https://chromiumcodereview.appspot.com//10178014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7124 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-28 10:34:16 +00:00