Special bits in this block:
int_parse_radix_test: Converted to a check only on TypeError (since this is raised at runtime based on user data)
iterable_element_at_test.dart: Split into multitest with compile errors.
iterable_fold_test.dart: add4 and a couple of other cases here cause problems for some compilers, split out into multitests and annotated in
status file.
BUG=
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2997533002 .
Modified json_map_test to not expect the maps to be of type Map<int,
dynamic>, and marked iterable_to_list_test and iterable_to_set_test as
failing on DDC in the status files.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2996513002 .
This is only moving status lines around to ensure we only have 2 sections for
$dart2js_with_kernel per file: minified and host-checked. Some entries are now
duplicated because we no longer have the $dart2js_with_kernel (non-checked)
section.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2993083002 .
list_unmodifiable_test required some modifications so callbacks matched
the correct types. list_unmodifiable_test and list_test also needed to
be disabled on dartdevc due to some issue with List<int> not mapping to
JSArray.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2992833002 .
duration2_test.dart converted to a static-only test and skipped where appropriate for non-strong. error_stack_trace_test converted to a multitest and error_stack_trace1_test modified to use more modern catch convention for stack traces.
R=bkonyi@google.com, rnystrom@google.com
Review-Url: https://codereview.chromium.org/2987793002 .
This was a hairy test block, please review carefully. Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved outside the SDK
from_environment_const_type_undefined_test.dart, from_environment_const_type_test: change to expect compile-time errors for all error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments. Stripped runtime checking of checked mode. Also, this doesn't work, but should, with dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option comments
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989643002 .
It looks like one test was left off the status file, especially since it's mentioned in the comment of the CL description.
BUG=
Review-Url: https://codereview.chromium.org/2989973002 .
This will enable --use-kernel tests in the dart2js bots.
After this change, running our tests will change a little bit, either of these
would work:
Option A: --use-sdk (host-checked not allowed)
python tools/test.py -m release \
-c dart2js -r d8 --dart2js-batch --report \
--dart2js-with-kernel --use-sdk \
language corelib library_2 corelib_2 \
dart2js_native dart2js_extra
Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
-c dart2js -r d8 --dart2js-batch --report \
--dart2js-with-kernel --host-checked \
--dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
language corelib library_2 corelib_2 \
dart2js_native dart2js_extra
In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.
BUG=
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2988063002 .
Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.
Also tweaked some analyzer hints
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2990623002 .
Another fairly simple block. regress-standalone required the
introduction of two seperate result variables as result was having two
different types assigned to it at different times.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2985823002 .
Unusual things in this block:
- This is my first attempt to fix a multitest with various errors in it,
double_parse_test.dart. Most of them revolve around multitest #01 and
the conflict it has with the new multitest #04.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2988573002 .
This also:
- replaces --use-kernel with --use-kernel-in-ssa
- replaces --load-dill with --use-kernel
- makes --use-kernel support both: compiling from .dill or from .dart
- change the default of other options that are currently disabled when --use-kernel is on.
- adds .status lines for all tests in language/corelib/dart2js_extra/dart2js_native
R=efortuna@google.com
Note: this CL is built on top of another change
(https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
test.dart
Review-Url: https://codereview.chromium.org/2989453002 .
Unusual things in this block:
- date_time10_test.dart had no strong mode fork, and reveals what looks
like a legit DDC bug at first glance. Excluded it for now in the status file.
- date_time_test.dart had small differences between the two forks that looked
like an error. Fixed.
BUG=
R=bkonyi@google.com, rnystrom@google.com
Review-Url: https://codereview.chromium.org/2984063002 .
Stephen Adams