Bob Nystrom
edee53f93d
Bring back the deleted 1.0 corelib tests.
...
What is dead may never die.
Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com >
2017-09-21 18:29:40 +00:00
Ben Konyi
f50a306875
Migrated test block 16 to Dart 2.0.
...
Lots of issues in map_test caused by the use of conflicting key types.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2990903002 .
2017-07-31 15:08:23 -07:00
Florian Loitsch
f6020b6d7e
Make json-maps implement Map<String, dynamic>.
...
Fixes #26407 .
http://dartbug.com/26407
R=lrn@google.com
Review-Url: https://codereview.chromium.org/1980663002 .
2017-05-02 14:51:32 +02:00
Jacob Richman
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Lasse R.H. Nielsen
4e94938f7e
Fix some cases where Map.containsValue did not accept Object as argument.
...
Add tests.
Also remove a left-over check in SplayTreeMap.
BUG= https://github.com/dart-lang/dev_compiler/issues/344
R=wibling@google.com
Review URL: https://codereview.chromium.org//1360053003 .
2015-09-23 11:26:55 +02:00
lrn@google.com
182b7b8083
Don't inherit two versions of Comparable. Not supported by dart2js.
...
Review URL: https://codereview.chromium.org//836123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42625 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 11:21:12 +00:00
lrn@google.com
404d4a7243
Make Super abstract in map_test.dart to avoid warning.
...
Review URL: https://codereview.chromium.org//820693005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42624 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 11:17:28 +00:00
lrn@google.com
3f1780f70d
Change List/Set/Map/Queue.from constructrs to accept any iterable.
...
This allows using the .from constructor as a cast:
new Set<int>.from(numSetContainingOnlyInts);
BUG= http://dartbug.com/21731
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//838463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42620 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 10:14:56 +00:00
kasperl@google.com
1a56829f81
Use JsonMap even for JSON.decode with custom reviver.
...
R=floitsch@google.com
BUG=
Review URL: https://codereview.chromium.org//367683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37931 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 06:29:20 +00:00
kasperl@google.com
7087c8a7b6
Make the JSON decoder (parser) create Dart maps lazily when no reviver is provided (common case).
...
R=floitsch@google.com , lrn@google.com
BUG=http://dartbug.com/19649
Review URL: https://codereview.chromium.org//336863008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37858 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 09:53:18 +00:00
lrn@google.com
3a743f3d38
Add MapMixin to dart:collection.
...
BUG= http://dartbug.com/10128
R=ajohnsen@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//253023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35904 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 11:36:13 +00:00
lrn@google.com
3ba70935ed
Remove use of now private class from map_test.
...
Review URL: https://codereview.chromium.org//212673004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34429 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 13:09:47 +00:00
lrn@google.com
bf6e0dab05
Add MapBase and UnmodifiableMapView classes to dart:collection.
...
Includes supporting classes.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//211223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34422 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 12:10:25 +00:00
lrn@google.com
12c9510193
Update implementations to use Object.identityHashCode for identity map/set
...
Update map/set constructors to have an .identity() constructor as well.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//24267023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27869 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 09:43:43 +00:00
lrn@google.com
6d49d9f1ac
Reapply "Convert HashSet, LinkedHashSet to factory methods and custom implementations."
...
R=floitsch@google.com , fschneider@google.com , kasperl@google.com
Review URL: https://codereview.chromium.org//24104003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27610 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 11:36:25 +00:00
lrn@google.com
0f1e912d9d
Reapply "Make LinkedHashMap also have a factory constructor and be customizable""
...
The change was reverted due to failing Dartium tests that were not easily handelable on a Friday afternoon.
Review URL: https://codereview.chromium.org//23872008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27284 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 10:49:32 +00:00
lrn@google.com
761f55b1b9
Revert "Make LinkedHashMap also have a factory constructor and be customizable"
...
Dartium expectations expects "LinkedHashMap" and gets "_LinkedHashMap".
Review URL: https://codereview.chromium.org//23890008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27250 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 14:29:04 +00:00
lrn@google.com
64359158ab
Make LinkedHashMap also have a factory constructor and be customizable
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23494027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27246 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 13:01:54 +00:00
lrn@google.com
5d8f2cad4e
Reapply "Add custom equals and hashCode for HashMap implementation."
...
Review URL: https://codereview.chromium.org//23493017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27179 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 08:29:26 +00:00
lrn@google.com
c288d7c951
Revert "Add custom equals and hashCode for HashMap implementation."
...
Review URL: https://codereview.chromium.org//23883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27111 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 11:17:15 +00:00
lrn@google.com
76c0e79ff6
Add custom equals and hashCode for HashMap implementation.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27106 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 09:42:21 +00:00
lrn@google.com
b841ead571
Add addAll to Map interface.
...
Also add SplayTreeMap.from constructor (using addAll).
BUG=http://dartbug.com/2644
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16406005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23808 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 12:43:38 +00:00
floitsch@google.com
5d058bb0eb
Adding isNotEmpty property to collection and string.
...
BUG= http://dartbug.com/3074
R=floitsch@google.com
Review URL: https://codereview.chromium.org//15263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23294 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:30:37 +00:00
floitsch@google.com
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
kasperl@google.com
f15b6960c0
Add a new implementation of HashMap that uses JS objects for its (multiple) hash tables.
...
I'll start refactoring the implementation to make it a bit more
maintainable, but I wanted to get your first impressions.
R=erikcorry@google.com ,lrn@google.com ,srdjan@google.com
BUG=
Review URL: https://codereview.chromium.org//12827018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20770 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-02 11:51:36 +00:00
floitsch@google.com
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
lrn@google.com
719aca47b1
Restructure SplayTreeMap to be reusable (e.g., for a SplayTreeSet).
...
Add documentation that all keys of the map must be comparable to each other.
Review URL: https://codereview.chromium.org//12304016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19209 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 10:02:40 +00:00
floitsch@google.com
4a7dfd2da3
Big merge from experimental to bleeding edge.
...
Review URL: https://codereview.chromium.org//11783009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
gram@google.com
cdb7da543b
Library syntax updates. Covers all remaining files in ~/tests aprt from ~/tests/language and ~/tests/standalone.
...
Review URL: https://codereview.chromium.org//11358203
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14815 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 22:45:18 +00:00
ajohnsen@google.com
7e451fc1a4
Move SplayTreeMap from coreimpl to collection.
...
BUG=
Review URL: https://codereview.chromium.org//11304007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14178 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 09:40:54 +00:00
floitsch@google.com
2e778387b3
Make getKeys, getValues getters (keys, values).
...
Review URL: https://codereview.chromium.org//11267018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
sigmund@google.com
d9eae90196
test rename overhaul: step 7 - corelib tests
...
Review URL: https://chromiumcodereview.appspot.com//10244009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7096 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-27 18:06:37 +00:00