Commit Graph

8 Commits

Author SHA1 Message Date
Bob Nystrom edee53f93d Bring back the deleted 1.0 corelib tests.
What is dead may never die.

Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com>
2017-09-21 18:29:40 +00:00
Ben Konyi f50a306875 Migrated test block 16 to Dart 2.0.
Lots of issues in map_test caused by the use of conflicting key types.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2990903002 .
2017-07-31 15:08:23 -07:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
lrn@google.com 53dc9ba034 Change the field and constructor parameter types of NoSuchMethodError to Symbol.
The NSME uses strings for names. It should use symbols.

This change modifies the VM libraries only enough to make the signature change
not crash. It will probably need cleanup to ensure that symbols are passed
to the internal constructor directly, instead of strings that have to be
converted.

(Also fixes a type error in Map.fromIterable that was hit by the code).

BUG= http://dartbug.com/11190
R=ahe@google.com, regis@google.com

Review URL: https://codereview.chromium.org//23486007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26985 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 05:57:49 +00:00
lrn@google.com 0fa1bbdf15 Reapply "Make Map constructors return LinkedHashMap."
Updated tests assuming a specific ordering of an unlinked hash map
to not be daft.

R=floitsch@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//22859069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26693 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 08:43:46 +00:00
lrn@google.com 4983d492d3 Revert "Make Map constructors return LinkedHashMap."
Some tests are making assumptions that are not warranted.

Review URL: https://codereview.chromium.org//22966015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26624 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 09:12:48 +00:00
lrn@google.com 011f1ee4b8 Make Map constructors return LinkedHashMap.
BUG= http://dartbug.com/5803
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23190040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26622 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 08:08:06 +00:00
zarah@google.com 13d024e0dc Add Map constructors taking iterables.
BUG= http://dartbug.com/11330
R=floitsch@google.com

Review URL: https://codereview.chromium.org//18023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24514 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 13:17:16 +00:00