dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

28 Commits

Author SHA1 Message Date
Bob Nystrom edee53f93d Bring back the deleted 1.0 corelib tests. 
What is dead may never die.

Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-21 18:29:40 +00:00
Kevin Moore c347b0ed16 Migrate test block 9 to Dart 2.0 
Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.

Also tweaked some analyzer hints

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2990623002 .
 2017-07-25 16:43:08 -07:00
Alexander Markov 277f22329f Adjust some tests for limited 64-bit integers 
In preparation for limiting Dart integers to 64 bits, certain tests
are corrected to avoid large integer literal or computations with
overflow.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Review-Url: https://codereview.chromium.org/2988803002 .
 2017-07-25 13:19:30 -07:00
Jacob Richman 14531fa62d Re-land "Format all multitests" 
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
 2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests" 
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
 2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
 2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests 
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
 2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests" 
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
 2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests 
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
 2017-03-21 12:39:28 -07:00
koda@google.com 784c1e4f88 Replace Linked{Identity,Custom}Hash{Map,Set} with compact implementation; remove old code and flag. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//983703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44294 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-06 15:13:01 +00:00
koda@google.com ec00a4ace6 Make test compatible with dart2js integer semantics. 
R=vegorov@google.com

Review URL: https://codereview.chromium.org//946203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43941 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-22 05:57:35 +00:00
koda@google.com 574028165f Ensure hash pattern is non-zero. Re-enable compact hash map/set. 
BUG=dart:22520
TBR=vegorov@google.com

Review URL: https://codereview.chromium.org//946893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43940 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-22 03:04:35 +00:00
koda@google.com c6e3dd73c2 Default to compact Map/Set implementation. 
Also adjust unit tests accoringly to maintain coverage, and remove some redundant ones.

R=iposva@google.com

Review URL: https://codereview.chromium.org//936613007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43894 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 21:28:56 +00:00
koda@google.com 1d7ca12fdc Compact LinkedHashMap/Set implementation. 
Add GC-friendly replacement for default Map/Set:
* open-addressing hash table, avoiding the overhead of chained entries
* index separate from the keys/values, allowing more of it to fit in the cache
* new keys are always appended, to allow insertion-order iteration
* spare bits in index entries are used to store hashes
* index is typed data, so can be ignored by GC

Enable it with --use_compact_hash (disabled by default).

Reduces Dart2JS compilation time for huge codebase (N=200) by ~30%, due to reduced time in GC. Slightly slower for small maps and maps with deletions: json benchmarks regress by ~5%.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//915323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43840 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 13:58:32 +00:00
lrn@google.com 04c230b114 Add Set.lookup method to get the instance in the set. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26832002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28499 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-11 07:16:20 +00:00
lrn@google.com 12c9510193 Update implementations to use Object.identityHashCode for identity map/set 
Update map/set constructors to have an .identity() constructor as well.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//24267023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27869 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 09:43:43 +00:00
lrn@google.com 6d49d9f1ac Reapply "Convert HashSet, LinkedHashSet to factory methods and custom implementations." 
R=floitsch@google.com, fschneider@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//24104003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27610 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-18 11:36:25 +00:00
lrn@google.com 18362b2cf4 Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations." 
Triggers an error in html tests on dartium.

Review URL: https://codereview.chromium.org//23451045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27392 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-11 16:19:45 +00:00
lrn@google.com c5bb6f7b15 Convert HashSet, LinkedHashSet to factory methods and custom implementations. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23859008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27378 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-11 12:35:57 +00:00
kasperl@google.com 57a82e9d05 Implement JS version of LinkedHashSet and move the various HashTable implementations to the VM collection library patch. 
R=erikcorry@google.com,lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//13913005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21180 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-10 07:12:50 +00:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library. 
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library." 
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library. 
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-09 02:40:37 +00:00
lrn@google.com ecbf4478c2 Reapply "New implementation of {,Linked}Hash{Set,Map}." 
Review URL: https://codereview.chromium.org//12212211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18573 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:07:22 +00:00
lrn@google.com c3e2eace1e Revert "Reapply "New implementation of {,Linked}Hash{Set,Map}."" 
Breaks pub, which apparently contains concurrent modifications of a
HashMap.

Spurious error in:
 pkg/analyzer-experimental/test/generated/ast_test/test_literal_map
Seems to be an error in the analyzer.

TBR

Review URL: https://codereview.chromium.org//12254048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18569 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 10:06:49 +00:00
lrn@google.com 9d8aca9e45 Reapply "New implementation of {,Linked}Hash{Set,Map}." 
Review URL: https://codereview.chromium.org//12254006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18566 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 09:18:36 +00:00
lrn@google.com 6e0d6462ce Revert "New implementation of {,Linked}Hash{Set,Map}." 
Triggers assertion in VM debug mode.
Seems to have some bug or difference that affects dart2dart.

Review URL: https://codereview.chromium.org//12258008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18442 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-13 12:40:12 +00:00
lrn@google.com 6ad0b78818 New implementation of {,Linked}Hash{Set,Map}. 
Accepts null keys/entries.
Much faster LinkedHashMap, faster HashSet, slight penalty on HashMap,
possibly due to accepting null keys.
Performance difference depends on table size.

Review URL: https://codereview.chromium.org//12213010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18437 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-13 09:51:50 +00:00