Commit Graph

19 Commits

Author SHA1 Message Date
Bob Nystrom edee53f93d Bring back the deleted 1.0 corelib tests.
What is dead may never die.

Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com>
2017-09-21 18:29:40 +00:00
Janice Collins 7fdc6eb128 Migrate test block 6 to Dart 2.0.
Unusual things in this block:
- This is my first attempt to fix a multitest with various errors in it,
double_parse_test.dart.  Most of them revolve around multitest #01 and
the conflict it has with the new multitest #04.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2988573002 .
2017-07-25 08:13:41 -07:00
Jacob Richman 14531fa62d Re-land "Format all multitests"
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests"
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests"
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman 6a7d6c385e Add comments
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
Stephen Adams 8cadbf4f72 Redo "Remove U+180E from whitespace in js_runtime and tests"
TBR=alanknight@google.com
BUG=

Review-Url: https://codereview.chromium.org/2747983003 .
2017-03-13 21:43:05 -07:00
Stephen Adams 66539fb493 Revert "Remove U+180E from whitespace in js_runtime and tests"
Several VM and browser status updates needed.

TBR=alanknight@google.com
BUG=

Review-Url: https://codereview.chromium.org/2748003002 .
2017-03-13 21:11:10 -07:00
Stephen Adams c6a01283c1 Remove U+180E from whitespace in js_runtime and tests
BUG= https://github.com/dart-lang/sdk/issues/28983
R=alanknight@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2733353002 .
2017-03-13 20:18:19 -07:00
Florian Schneider 15f23eedc9 VM: Fix --no-use-field-guards.
Fields read from the snapshot must be initialized in the same way
as when allocated with Field::New.

BUG=https://github.com/dart-lang/sdk/issues/25957
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1842853002 .
2016-03-29 17:40:58 -07:00
Mads Ager 7ae093a3b8 Split double_parse_test into more multitests.
The 03 multitest cases are the ones that fail on arm using the
system strtod. Separating them out makes it easier to do suppresions
of only the parts of the tests that fail in a given configuration.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1312903010 .
2015-09-01 16:27:01 +02:00
Mads Ager bb8ca393e1 Split two string to double corner cases into a separate multitest.
When using a simpler version of the doubleconversion library that
uses the system strtod to parse strings these cases fail on MacOS.
Splitting them out allows us to mark only these corner cases as
failing on MacOS.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1312893007 .
2015-09-01 10:20:04 +02:00
sra@google.com 31993af4bf There was a weird dead expression that should have been used but was not, letting all upper case letters be 'accepted' for any radix over 10. The result was NaN values flowing into the program.
R=lrn@google.com

Review URL: https://codereview.chromium.org//988523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44304 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 21:34:02 +00:00
lrn@google.com 5bb4d992b4 Add more double-parsing tests.
I was looking at double parsing, and wanted more tests for myself anyway.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//712603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41664 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 13:31:40 +00:00
lrn@google.com d8a2043098 Fix wrong limit on list index in double.parse.
Review URL: https://codereview.chromium.org//623073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40892 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 07:03:45 +00:00
lrn@google.com 3192c983bf Dart version of double.parse that works for numbers that can be represented exactly as doubles.
BUG= http://dartbug.com/17711
R=vegorov@google.com

Review URL: https://codereview.chromium.org//520693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40891 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 06:01:44 +00:00