Emily Fortuna
e7bad54986
Make dart2js only run with 64 bit ints, not the larger ints from the vm.
...
Change-Id: I03887a0af963f1a8f68acff0428635fc130687f5
Reviewed-on: https://dart-review.googlesource.com/57041
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-05-30 17:21:49 +00:00
Alexander Thomas
d28c5499fc
[infra] Add support for app_jitk compiler to test.py ( #33126 )
...
* Add app_jitk configuration to test matrix.
* Skip it on non-Dart 2 test suites.
Change-Id: I05f75dbbd33d34a4acf4df1fe63104933d39d2fe
Reviewed-on: https://dart-review.googlesource.com/56113
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-05-28 11:54:56 +00:00
Emily Fortuna
49d5ca3bb4
Switch to BigInt for ConstantValue.
...
Change-Id: I17eec094d794b1c4791d491ea523d284f9eae4ed
Reviewed-on: https://dart-review.googlesource.com/55500
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-05-22 01:04:41 +00:00
Sigmund Cherem
c25a9fd46b
Remove support for dart:isolate in dart2js.
...
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-05-10 01:20:17 +00:00
Stephen Adams
cbdf102d0c
Use interceptor for reading type arguments
...
Type arguments that require a subsitution need the interceptor to
access the substitution function.
- Add an interceptor input to HTypeInfoReadVariable
- Add an entry point getRuntimeTypeArgumentIntercepted that takes the interceptor.
- Optimize uses that do not need the interceptor.
The interceptor is cheap to get from the context in the common case
that the type variable access is directly in an instance method.
A typical use (broken)
var t1 = H.getRuntimeTypeArgument(receiver, "ListMixin", 0);
becomes
var t1 = H.getRuntimeTypeArgumentIntercepted(this, receiver, "ListMixin", 0);
Change-Id: I2abe6a2b6e8d2cdb0ede1b7248dd8337830f8a0c
Reviewed-on: https://dart-review.googlesource.com/50640
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-04-11 21:25:26 +00:00
Alexander Thomas
3851591642
[infra] Keep comments intact when updating status files.
...
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.
Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-04-10 19:03:21 +00:00
Sam Rawlins
301b5a1f16
Remove Maps; move _fillMapWith* methods to MapBase
...
Fixes #31843
Bug: https://github.com/dart-lang/sdk/issues/31843
Change-Id: I02c544c921951f4a50421205dc1f25997cbecd6e
Reviewed-on: https://dart-review.googlesource.com/39880
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-03-26 21:23:21 +00:00
Sigmund Cherem
514271e494
Prepare corelib.status for flipping on CFE on dart2js
...
TBR=sra@google.com
Change-Id: Ie09f7e61c8e94e496eec1c3d016cfd0f6282df03
Reviewed-on: https://dart-review.googlesource.com/44801
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-03-02 19:18:49 +00:00
Sigmund Cherem
9ed595b4b3
Use $fasta instead of $dart2js_with_kernel in our status files.
...
Note: $fasta is true when passing --dart2js-with-kernel. This change will make it
easier to flip the default: the plan is that $fasta will be true by default
later on, and passing --dart2js-old-frontend will make it false.
TBR=sra@google.com
Change-Id: Ib917d55b2d14db954c56513af057dd9a37b9c825
Reviewed-on: https://dart-review.googlesource.com/44601
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-03-01 21:02:18 +00:00
Sigmund Cherem
e33f4f7c2e
Fail if mirrors are really used.
...
Some legacy libraries may import dart:mirrors, but not use it. This CL turns them
into a runtime error temporarily to give some time for the library
maintainers to remove the import to dart:mirrors in the future.
Change-Id: I876133908d2a61300256915aab54730bdff51649
Reviewed-on: https://dart-review.googlesource.com/43640
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Emily Fortuna <efortuna@google.com >
2018-02-27 04:57:27 +00:00
Brian Wilkerson
386f8b2f5f
Skip remaining Dart 1.0 tests
...
Change-Id: I8014cdb5d5cd154f52043593e577b29a01d71e2b
Reviewed-on: https://dart-review.googlesource.com/41601
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-15 14:14:07 +00:00
Johnni Winther
f2b8cafb44
Handle assert in initializers of constant constructors.
...
Change-Id: Ibb4053af00392b3c43177c60c8551cc6ffe937eb
Reviewed-on: https://dart-review.googlesource.com/38320
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-02-13 14:00:01 +00:00
Peter von der Ahé
8815bbe90e
Update status files for $compiler == fasta
...
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-07 15:38:09 +00:00
Paul Berry
cca7b4419d
Replace $builder_tag == strong with $strong in status files
...
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`. Now that `$strong` is supported, it's better to
use it directly to avoid confusion.
Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-07 11:50:10 +00:00
Lasse R.H. Nielsen
6f78471687
New methods on Iterable, List, Set, Queue, Map.
...
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-02-07 06:12:53 +00:00
William Hesse
9c35cff5cd
Revert "New methods on Iterable, List, Set, Queue, Map."
...
This reverts commit 0b59f24f97 .
Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751
Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
>
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
> Reviewed-by: Leaf Petersen <leafp@google.com >
TBR=lrn@google.com ,leafp@google.com
Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com >
2018-02-06 13:32:19 +00:00
Lasse R.H. Nielsen
0b59f24f97
New methods on Iterable, List, Set, Queue, Map.
...
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-02-06 11:17:46 +00:00
Brian Wilkerson
4cad8c202d
Attempt to fix bot status
...
Change-Id: Ib934765771306d57b218d3691c3bba249f1d90ef
Reviewed-on: https://dart-review.googlesource.com/37863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-31 19:51:55 +00:00
Erik Corry
c8ae9bf77b
[VM] Stop treating 0x180e as whitespace
...
This aligns us with JS engines and Unicode 6.3
R=lrn@google.com
Bug: 29060
Change-Id: I0b6356f0e652f7c9841bcf6485aa591a3d835061
Reviewed-on: https://dart-review.googlesource.com/35560
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Erik Corry <erikcorry@google.com >
2018-01-18 10:37:15 +00:00
Erik Corry
5ed2f25f40
There is no longer a safarimobilesim test runtime.
...
And so there is no need to maintain status files for this platform.
R=whesse@google.com
Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-01-17 13:13:17 +00:00
Sigmund Cherem
0e1a407823
Produce a static error when using kernel and mirrors
...
Just noticed that the 'supportsRelection' flag was not checked when running with
'--use-kernel'.
Change-Id: I9f4bd540ad963c33c8b9013860ac63b1c6707299
Reviewed-on: https://dart-review.googlesource.com/35006
Reviewed-by: Harry Terkelsen <het@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-01-17 00:56:12 +00:00
Sigmund Cherem
96f915faa1
Update status for dart2js-with-kernel after disabling int64 in dart2js
...
TBR=sra@google.com
Change-Id: I3e13493ba619fb16ed9731fc85fc14938022ef59
Reviewed-on: https://dart-review.googlesource.com/35000
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-01-16 22:30:04 +00:00
Sigmund Cherem
0c04eb53c7
Disable int64 when running dart2js
...
The goal is to renable it as soon as we migrate our constant-evaluator and
constant folding to use Bigint.
Change-Id: I3bba1bbe07517e9cb496896b3417f58173878d62
Reviewed-on: https://dart-review.googlesource.com/34302
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
2018-01-16 19:52:22 +00:00
Alexander Markov
c051a0b905
[VM, Tests] Turn Dart 2.0 fixed-size integers ON by default, v2
...
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.
This CL includes ff9fc413a7 with fixes.
Change-Id: I632d8177e9d07cd82ecea75ab6c325681b3a25c9
Reviewed-on: https://dart-review.googlesource.com/32443
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-01-05 01:44:56 +00:00
Alexander Markov
90551f6aa5
Revert "[VM, Tests] Turn Dart 2.0 fixed-size integers ON by default"
...
This reverts commit ff9fc413a7 .
Reason: buildbot failures.
Change-Id: I68ffde271c8ba3b212e3bf015e2e550c8c891441
Reviewed-on: https://dart-review.googlesource.com/32442
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-01-04 19:04:44 +00:00
Alexander Markov
ff9fc413a7
[VM, Tests] Turn Dart 2.0 fixed-size integers ON by default
...
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.
Change-Id: I967a413c0b81eb92cf6be78ad3ee324798288bd2
Reviewed-on: https://dart-review.googlesource.com/31406
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-01-04 18:02:57 +00:00
Emily Fortuna
4cd0593574
Tiny fix to fix type errors in our compiler while running host-checked
...
and deferred loaded code.
Bug:
Change-Id: I57b51a287fd7ffad59a1a59eae34e739b5e5603b
Reviewed-on: https://dart-review.googlesource.com/29745
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-12-15 18:42:33 +00:00
Johnni Winther
5f06d51d1a
Enable inlining by default
...
Change-Id: I4810959da23193d8a1b572b4feea329a2f4b2f31
Reviewed-on: https://dart-review.googlesource.com/29320
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-12-14 10:02:54 +00:00
Siva Annamalai
87520f5b6e
Adjust status file for precompiler configuration.
...
Change-Id: I6c2cedcf81b266165cd014a242a3b2f3bc3a5db2
Reviewed-on: https://dart-review.googlesource.com/28800
Reviewed-by: Siva Annamalai <asiva@google.com >
2017-12-12 17:44:33 +00:00
Siva Annamalai
bb240a6cbf
Skip all Dart 1.0 tests in language/corelib and standalone tests when kernel mode
...
is specified as we will only support Dart 2.0 in kernel mode.
Change-Id: I712fa6e0f733738e4b722aeb10b5eba6a64316c5
Reviewed-on: https://dart-review.googlesource.com/28520
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-12-12 16:16:21 +00:00
Bob Nystrom
a53e4dd504
Finish migrating stuff out of lib_strong.
...
Some of these are data files that weren't picked up by the migration
script. Some are files that slipped between blocks of tests.
Change-Id: I184dc4701758b280444d54ec55c225ade30f3276
Reviewed-on: https://dart-review.googlesource.com/26423
Reviewed-by: Emily Fortuna <efortuna@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2017-12-11 23:45:23 +00:00
Morten Krogh-Jespersen
3db4b1070b
Normalize all status files and enable presubmit hook.
...
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.
To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.
Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2017-12-07 08:38:30 +00:00
Emily Fortuna
dc1b5525bf
Create temporary Method type in kernel world for compatibility with Dart 1
...
Bug:
Change-Id: I9efa163ce1a9a76df405f32d35850743e7f090cc
Reviewed-on: https://dart-review.googlesource.com/25723
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-12-04 19:37:54 +00:00
Samir Jindel
e50326af39
[kernel] Update cloner.dart
...
Several revisions have updated ast.dart without updating cloner.dart to
clone the newly added fields. This revision fixes #31438 .
Bug: https://github.com/dart-lang/sdk/issues/31438
Change-Id: I2347de69e6a424f25c04d2a773d3f8d8b8387619
Reviewed-on: https://dart-review.googlesource.com/23180
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2017-12-01 14:06:26 +00:00
Morten Krogh-Jespersen
39907272f6
Remove comments from status files.
...
This will allow for having automatic tools to alphabetize sections and entries.
Bug:
Change-Id: Ia7b7a100ca33197c4f3b1c50c11f24873dfbc09b
Reviewed-on: https://dart-review.googlesource.com/23675
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-11-28 07:56:20 +00:00
Emily Fortuna
6557792b5b
Add information about what types are instantiated when dealing with
...
factories and reified generics.
Bug:
Change-Id: Ia34b08859f1e54e7dc8fc3f8d51a1e78a1fa0e41
Reviewed-on: https://dart-review.googlesource.com/24022
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-28 01:00:53 +00:00
Emily Fortuna
d3eef66367
Add function parameter type checks in checked mode with constructors and loop variables.
...
Bug:
Change-Id: Ib3245eb59c9f23b31e4a0b1c65a25f1c2ad3188f
Reviewed-on: https://dart-review.googlesource.com/23143
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-22 19:57:04 +00:00
Emily Fortuna
9e5ad7af1a
Populate field setter method body for checked mode.
...
Bug:
Change-Id: I802fc425b998ce1ff1110a7e48215b557035d442
Reviewed-on: https://dart-review.googlesource.com/22300
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-21 01:11:07 +00:00
Emily Fortuna
bf94e73568
Fix up type inference to run in checked mode and enable checked mode tests running with kernel script.
...
Bug:
Change-Id: If720b6868fbdf010f4aac614ceea1ddea533c277
Reviewed-on: https://dart-review.googlesource.com/21222
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-11-15 22:34:51 +00:00
Emily Fortuna
035c85580b
Make fast-startup work with kernel!
...
Bug:
Change-Id: I88bf7fd7609bc816cc6d50daaa7e3a0ec5dc1934
Reviewed-on: https://dart-review.googlesource.com/19403
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-11-09 01:37:25 +00:00
Vyacheslav Egorov
71978a74b9
[gardening] Update dartkp status files in attempt to make dartkp-release green.
...
Bug:
Change-Id: Iff6435ba7f69180c0395d278fceb33fc084d8a8c
Reviewed-on: https://dart-review.googlesource.com/19040
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2017-11-07 17:24:29 +00:00
Vyacheslav Egorov
b2721473aa
[VM,Kernel] Report an error on import of dart:mirrors when mirrors are disabled
...
Otherwise VM simply crashes further down in the pipeline.
Update corelib/apply3_test status to match this change.
R=kustermann@google.com
Bug:
Change-Id: Iffb4d2bc7e513d5a79123b029f7ea7c4e1033056
Reviewed-on: https://dart-review.googlesource.com/19003
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2017-11-07 15:37:09 +00:00
Peter von der Ahé
7559d79af3
Track offsets of unnamed mixins
...
Closes https://github.com/dart-lang/sdk/issues/30316
Change-Id: I858091104c4f13afb6d751f3d290a3127efb2b5f
Reviewed-on: https://dart-review.googlesource.com/15260
Reviewed-by: Dan Rubel <danrubel@google.com >
2017-10-20 12:24:37 +00:00
Jens Johansen
c8b2183bb5
[kernel] Disallow const x = [] and const y = {}
...
This CL makes fasta issue an error when trying to create a non-const
ListLiteral or MapLiteral in a context where const is required.
Bug:
Change-Id: I27ea151a38eb1198faa83a8cfa57453a4e225e1a
Reviewed-on: https://dart-review.googlesource.com/15460
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-20 09:38:57 +00:00
Harry Terkelsen
f36b1f49d6
Only set model.scopeInfo for the outer member, not nested closures
...
Change-Id: I848e18e1000158b4a198782227bfb2524104e805
Reviewed-on: https://dart-review.googlesource.com/14700
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-18 21:00:06 +00:00
Harry Terkelsen
f690f6225e
Use the validating constructor when creating a Symbol.
...
Change-Id: Iae150ad036f8a72dcc853b86ecd01c569d28bd0b
Reviewed-on: https://dart-review.googlesource.com/11963
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-10-06 19:54:47 +00:00
Johnni Winther
f9cb6c4137
Remove dart2js_with_kernel_in_ssa test option
...
Change-Id: I2da692a4d458acc4b36e14beb99e1fb9d2bdec70
Reviewed-on: https://dart-review.googlesource.com/10861
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-10-05 06:53:39 +00:00
Johnni Winther
0ed5cadad3
Update dart2js_with_kernel status
...
Change-Id: Ibb41fa04c4e05b56e908925f83c16e68cf8b68ed
Reviewed-on: https://dart-review.googlesource.com/10860
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-10-04 07:16:30 +00:00
Stephen Adams
2ea83486e1
dart2js kernel: generate constants for default arguments in Function.apply
...
Change-Id: I5bd0a8deaf16069749a574eb2ed132738e2e0747
Reviewed-on: https://dart-review.googlesource.com/8280
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-09-27 00:35:53 +00:00
Johnni Winther
772a0aff33
Handle and report erroneous compile time constants
...
Change-Id: I2ee86dbd714227e8e0894539ca64258fd11badfc
Reviewed-on: https://dart-review.googlesource.com/7820
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-09-22 18:57:37 +00:00