dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

304 Commits

Author SHA1 Message Date
Sigmund Cherem a06f7c9241 Remove dart:_isolate_helper. 
The rest of the code was used in a single place, so I've moved the code to the
appropriate library.

Change-Id: Idd0416bf7365e3de05f20ab1184428ae7ae614b2
Reviewed-on: https://dart-review.googlesource.com/54745
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-05-15 00:21:28 +00:00
Sigmund Cherem c25a9fd46b Remove support for dart:isolate in dart2js. 
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-10 01:20:17 +00:00
Sigmund Cherem 3ec1b929e3 Remove dependencies on isolates. 
This starts removing support for isolates. I've kept around the
isolate library for now, but I stopped injecting the isolate logic
unless you directly access an isolate API.

Concrete changes:

* Timer no longer uses the event queue: this was only used in worker
isolates, soon to be removed.

* Checking for whether the code is run within a worker is not dependent
   on initializing the isolates global state. This was important to allow
   deferred-loading to work without the isolate logic.

* Workers no longer track pending async calls correctly. This may make it possible
   to terminate worker isolates early, again this wont be relevant shortly.

Bug: https://github.com/dart-lang/sdk/issues/32684
Change-Id: I05025418e05c3641ba1a3bc34ea75ca558a28fbd
Reviewed-on: https://dart-review.googlesource.com/54160
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-09 16:36:26 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Sigmund Cherem e38e98afbe Update dart2js_native.status: updated to be accurate with our many configurations 
TBR=sra@google.com

Change-Id: Ic294b6b9fba128e82cff934b8f3587cee71292e4
Reviewed-on: https://dart-review.googlesource.com/44663
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-02 01:50:38 +00:00
Sigmund Cherem 9ed595b4b3 Use $fasta instead of $dart2js_with_kernel in our status files. 
Note: $fasta is true when passing --dart2js-with-kernel. This change will make it
easier to flip the default: the plan is that $fasta will be true by default
later on, and passing --dart2js-old-frontend will make it false.

TBR=sra@google.com

Change-Id: Ib917d55b2d14db954c56513af057dd9a37b9c825
Reviewed-on: https://dart-review.googlesource.com/44601
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-01 21:02:18 +00:00
Sigmund Cherem e33f4f7c2e Fail if mirrors are really used. 
Some legacy libraries may import dart:mirrors, but not use it. This CL turns them
into a runtime error temporarily to give some time for the library
maintainers to remove the import to dart:mirrors in the future.

Change-Id: I876133908d2a61300256915aab54730bdff51649
Reviewed-on: https://dart-review.googlesource.com/43640
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-02-27 04:57:27 +00:00
Sigmund Cherem 0e1a407823 Produce a static error when using kernel and mirrors 
Just noticed that the 'supportsRelection' flag was not checked when running with
'--use-kernel'.

Change-Id: I9f4bd540ad963c33c8b9013860ac63b1c6707299
Reviewed-on: https://dart-review.googlesource.com/35006
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-17 00:56:12 +00:00
Emily Fortuna 4cd0593574 Tiny fix to fix type errors in our compiler while running host-checked 
and deferred loaded code.

Bug:
Change-Id: I57b51a287fd7ffad59a1a59eae34e739b5e5603b
Reviewed-on: https://dart-review.googlesource.com/29745
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-12-15 18:42:33 +00:00
Johnni Winther 5f06d51d1a Enable inlining by default 
Change-Id: I4810959da23193d8a1b572b4feea329a2f4b2f31
Reviewed-on: https://dart-review.googlesource.com/29320
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-12-14 10:02:54 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook. 
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-12-07 08:38:30 +00:00
Sigmund Cherem 30f154c8ea Bring status on a few suites up to date for --checked and --fast-startup 
TBR=efortuna@google.com

Change-Id: If7196983eecf4cd7932e20332dca5471f24319f0
Reviewed-on: https://dart-review.googlesource.com/27087
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-12-07 05:08:30 +00:00
Emily Fortuna dc1b5525bf Create temporary Method type in kernel world for compatibility with Dart 1 
Bug:
Change-Id: I9efa163ce1a9a76df405f32d35850743e7f090cc
Reviewed-on: https://dart-review.googlesource.com/25723
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-12-04 19:37:54 +00:00
Emily Fortuna 9e5ad7af1a Populate field setter method body for checked mode. 
Bug:
Change-Id: I802fc425b998ce1ff1110a7e48215b557035d442
Reviewed-on: https://dart-review.googlesource.com/22300
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-21 01:11:07 +00:00
Emily Fortuna bf94e73568 Fix up type inference to run in checked mode and enable checked mode tests running with kernel script. 
Bug:
Change-Id: If720b6868fbdf010f4aac614ceea1ddea533c277
Reviewed-on: https://dart-review.googlesource.com/21222
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-15 22:34:51 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Johnni Winther ff7cfea850 Turn on inference by default with --use-kernel 
Change-Id: I3f320cc5aa8f265b45c73c9d3023950d8ed4240b
Reviewed-on: https://dart-review.googlesource.com/20064
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-13 10:51:03 +00:00
Emily Fortuna 035c85580b Make fast-startup work with kernel! 
Bug:
Change-Id: I88bf7fd7609bc816cc6d50daaa7e3a0ec5dc1934
Reviewed-on: https://dart-review.googlesource.com/19403
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-09 01:37:25 +00:00
Harry Terkelsen 0c7fbd7f38 fix dart2js_native test status file 
Change-Id: Id99e8403871542ab43e7a7762aca6975ffd2c3e0
Reviewed-on: https://dart-review.googlesource.com/16622
Reviewed-by: Stephen Adams <sra@google.com>
 2017-10-25 19:25:30 +00:00
Stephen Adams 2c44adec91 dart2js kernel status updart for dart2js_native and dart2js_extra 
Not sure why they changed, but it is useful for other work to have a
'correct' baseline.

TBR=sigmund@google.com

Change-Id: I6d22f731e74f093e39ad0203a668b2ea165946b5
Reviewed-on: https://dart-review.googlesource.com/14362
Reviewed-by: Stephen Adams <sra@google.com>
 2017-10-17 02:53:41 +00:00
Stephen Adams b80c0a1dde fix archaic syntax in dart2js_native test 
TBR=efortuna@google.com

Bug:
Change-Id: I394985d25513fa213f7ba9270c92b4d357bff91c
Reviewed-on: https://dart-review.googlesource.com/13923
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2017-10-13 22:40:34 +00:00
Johnni Winther f9cb6c4137 Remove dart2js_with_kernel_in_ssa test option 
Change-Id: I2da692a4d458acc4b36e14beb99e1fb9d2bdec70
Reviewed-on: https://dart-review.googlesource.com/10861
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-05 06:53:39 +00:00
Emily Fortuna 1bf53724bb Use in correct version of CommonElements (J vs K entities) for backend. 
Bug:
Change-Id: I8731624f7453d47019fbf24be4d9d6db4d5a0318
Reviewed-on: https://dart-review.googlesource.com/7488
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-21 17:57:26 +00:00
Emily Fortuna 942963fa2e Add TypeVariable analysis in closure conversion. 
Bug:
Change-Id: I4155ceb042295934cc3c9125d275dc5f034675dd
Reviewed-on: https://dart-review.googlesource.com/6025
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-18 20:26:33 +00:00
Stephen Adams 69b50ed990 dart2js-kernel: Fix bug with finding optional parameter default values 
Change-Id: Iefa443318124838aeafa9998e08d1143c1976dc4
Reviewed-on: https://dart-review.googlesource.com/6346
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-15 23:54:22 +00:00
Johnni Winther 5aa3259698 Handle break to labeled statement 
No tests yet. Kernel doesn't support file-offsets on labeled statement.

Change-Id: I5dcfcc21433aec5ad0be26bfef5bbca0b609ba35
Reviewed-on: https://dart-review.googlesource.com/5161
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-14 08:59:11 +00:00
Stephen Adams 45d6ed8a01 Allow 'lookup' of native classes declared in dart2js_native and dart2js_extra tests' 
R=johnniwinther@google.com

Change-Id: I510fd1f76c5369fdf37b833ccce10dc788810099
Reviewed-on: https://dart-review.googlesource.com/5640
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-14 03:59:00 +00:00
Stephen Adams 0bfad6483e de-dup dart2js kernel status files 
TBR=sigmund@google.com

Bug:
Change-Id: I41d0bfdad38f0ab65649cd9d69e82097e9877fe2
Reviewed-on: https://dart-review.googlesource.com/5483
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 17:13:03 +00:00
Emily Fortuna b1dd578da7 Don't try to add abstract methods to the codegen work queue to generate bodies 
BUG=
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/3012683002 .
 2017-09-01 10:21:03 -07:00
Johnni Winther 374df045e7 Handle forwarding constructors to unnamed mixin applications 
+ handle instance fields from mixins
+ change class sorting to put unnamed mixin applications last

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3005823002 .
 2017-09-01 19:07:02 +02:00
Emily Fortuna 98e36f719e Add boxing for modified variables 
BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/3007743002 .
 2017-08-29 16:27:28 -07:00
Stephen Adams 5865a13c44 dart2js kernel: update tryInlineNativeMethod to Entities 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2998413002 .
 2017-08-25 16:13:38 -07:00
Stephen Adams 83ea082dd3 Redo "dart2js-kernel: implement native static methods" 
BUG=

Review-Url: https://codereview.chromium.org/2995293002 .
 2017-08-23 14:06:20 -07:00
Johnni Winther 1658036b05 Share locals between members 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2995113002 .
 2017-08-21 15:02:10 +02:00
Stephen Adams bda3b1451d Revert "dart2js-kernel: implement native static methods" 
This reverts commit 1206111dea.

Has analyzer warnings that I will fix after the sun comes back out.

TBR=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/3003003002 .
 2017-08-18 22:20:41 -07:00
Stephen Adams 1206111dea dart2js-kernel: implement native static methods 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/2997253002 .
 2017-08-18 19:40:51 -07:00
Stephen Adams 2fc1ca0b6c DeferredTask.isDeferredClass Element->Entity 
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/2995253002 .
 2017-08-18 11:00:49 -07:00
Stephen Adams 8499c8f12e dart2js kernel: minimal recognition of external native methods 
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/3000123002 .
 2017-08-17 21:39:14 -07:00
Stephen Adams 3021706f87 More dart2js status duplicate removal 
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/2996203002 .
 2017-08-17 19:17:41 -07:00
Johnni Winther 7c77f2db48 Various redemptions 
R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/49b064da419f6eb141c980aec15296a4bb517956

Reverted: https://github.com/dart-lang/sdk/commit/a0110b32f33462be85db64cbda2024ee8912a968
Review-Url: https://codereview.chromium.org/2994333002 .
 2017-08-17 15:54:37 +02:00
Emily Fortuna 09b215a2fd Fix the local variable lookup in the locals handler. 
BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2994363002 .
 2017-08-16 16:08:21 -07:00
Stephen Adams fd600fd334 Implement methods in KernelClosedWorldMixin 
R=sra@google.com

Review-Url: https://codereview.chromium.org/2997843002 .
 2017-08-15 14:18:46 -07:00
Sigmund Cherem 4d53ef3449 Add crash comments in dart2js_extra and dart2js_native 
BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2993113002 .
 2017-08-04 13:30:52 -07:00
Sigmund Cherem edc1054ae1 Normalize status files for dart2js_with_kernel 
This is only moving status lines around to ensure we only have 2 sections for
$dart2js_with_kernel per file: minified and host-checked.  Some entries are now
duplicated because we no longer have the $dart2js_with_kernel (non-checked)
section.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2993083002 .
 2017-08-04 09:41:08 -07:00
Emily Fortuna 4929f282b3 Make minification Entity-friendly. 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2996463002 .
 2017-08-03 19:19:21 -07:00
Sigmund Cherem e1bccfc857 FE: let targets override whether imports to internal platform 
libraries (dart:_foo) are allowed.

Override this in Dart2jsTarget to allow it in the dart2js_native test suite.

R=sra@google.com

Review-Url: https://codereview.chromium.org/2992073002 .
 2017-07-31 15:23:12 -07:00
Stephen Adams 0c46242023 dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2990083002 .
 2017-07-31 15:14:47 -07:00
Stephen Adams efb3abb77b dart2js_native tests: Migrate 'native STRING' to JS-calls 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2984403002 .
 2017-07-31 12:40:47 -07:00