Zachary Anderson
6cd8a79078
VM: Re-format to use at most one newline between functions
...
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2974233002 .
2017-07-13 08:08:37 -07:00
Zachary Anderson
a1bcf051d8
clang-format runtime/vm
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 13:54:47 -08:00
Zachary Anderson
103881d01c
Make header include guards great again
...
i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER
This lets us remove a hack from the PRESUBMIT.py script that existed
for reasons that are no longer valid, and sets us up to add some
presubmit checks for the GN build.
R=asiva@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2450713004 .
2016-10-26 00:26:03 -07:00
Siva Annamalai
bd1895017b
Add a verification step which iterates over the heap and verifies that all canonical objects are consistent (i.e canonicalizing the object returns the object).
...
Review URL: https://codereview.chromium.org/2160953002 .
2016-07-25 14:35:13 -07:00
Srdjan Mitrovic
40d8eee81e
Remove unnecessary isolate argument from some visitors
...
BUG=
R=regis@google.com
Review URL: https://codereview.chromium.org/1838373002 .
2016-03-29 14:47:51 -07:00
Srdjan Mitrovic
53e814f0dd
Move reusable handles from isolate to thread.
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org/1394673002 .
2015-10-09 10:10:34 -07:00
koda@google.com
627e89639c
Check mark bit when verifying heap.
...
Verify expected state of mark bit, depending on:
- pre vs. post-GC
- VM vs. regular isolate
- concurrent vs. regular sweep
Review URL: https://codereview.chromium.org//630933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40943 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 19:24:45 +00:00
asiva@google.com
8c2df33d13
Use a bit in the handle structure to indicate if it is a prologue weak handle instead of the tagging the address.
...
R=koda@google.com
Review URL: https://codereview.chromium.org//208443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34258 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 17:23:33 +00:00
asiva@google.com
e380b175f8
Pass in the isolate parameter to the weak persistent callback handler so that
...
there is no need to access the current isolate in the callback and delete
path (this code is run while a GC is in progress).
See https://codereview.chromium.org/185643003/ for corresponding changes
in dartium
R=iposva@google.com
Review URL: https://codereview.chromium.org//186003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33282 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 18:11:19 +00:00
asiva@google.com
8e0129970c
Use a tag bit for indicating prologue weak persistent handles, this avoids
...
the costly lookup to determine if a handle is a prologue weak persistent
handle or a regular weak persistent handle in Dart_DeleteWeakPersistentHandle
R=iposva@google.com
Review URL: https://codereview.chromium.org//177093010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33254 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 00:35:45 +00:00
asiva@google.com
b4d9e0d620
Auto create ApiLocalScope before calling native functions, this ensures that
...
native functions do not have to call Dart_EnterScope/Dart_ExitScope
when they callback into the VM.
Remove Dart_EnterScope/Dart_ExitScope calls around native functions in 'bin'
directory.
R=regis@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//22303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25827 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 19:27:48 +00:00
cshapiro@google.com
0928c651e5
Implement a 2-pass heap verification algorithm.
...
The previous algorithm would visit each pointer in the heap and verify it
without regard for whether the pointer had already been visited.
The new algorithm computes the set of allocated objects and verifies each
object in the set. In a second pass, each pointer is visited and tested
for membership in the set.
BUG=2606
Review URL: https://chromiumcodereview.appspot.com//10696029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9532 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-10 22:07:40 +00:00
iposva@google.com
6a5ef0e692
- Add an isolate field to visitors.
...
Review URL: https://chromiumcodereview.appspot.com//10502004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8337 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-06 14:47:17 +00:00
iposva@google.com
4d3c2b94a2
- Add extra checking when validating objects.
...
- Properly set the class tags when converting growable arrays
to fixed length arrays.
- Set the class tag when allocating instantiated type arguments.
Review URL: https://chromiumcodereview.appspot.com//10271032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7190 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-01 15:16:02 +00:00
cshapiro@google.com
917bbbfc39
Provide API support for weak handles and post-mortem finalization.
...
In addition, this change separates the storage of weak persistent
handles from ordinary persistent handles. An ordinary persistent
handle now stores no other data than the raw pointer value.
Review URL: http://codereview.chromium.org//9148051
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3273 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 01:23:42 +00:00
dgrove@google.com
4c0f559d23
Initial checkin.
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00