Jacob Richman
4360e99d18
Revert "Fix observatory tests broken by running dartfmt."
...
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.
BUG=
Committed: https://github.com/dart-lang/sdk/commit/62be0eacfbb36bdc92a05c7c35bb4506621b6a3a
Review-Url: https://codereview.chromium.org/2767533002 .
2017-03-21 10:07:26 -07:00
Jacob Richman
62be0eacfb
Revert "Fix observatory tests broken by running dartfmt."
...
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.
BUG=
Review-Url: https://codereview.chromium.org/2767533002 .
2017-03-20 22:19:22 -07:00
Jacob Richman
88f8aacd5f
Re-apply rolled back CL to apply dartfmt to runtime.
...
Fix observatory tests broken by running dartfmt due to line and column changes.
Temporarily reverted formatting for evaluate_activation_test.dart as dartfmt doesn't yet handle multitests.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2759973004 .
2017-03-20 21:44:59 -07:00
Ryan Macnak
ea4744a06f
Revert "Run dartfmt on all files under runtime."
...
This reverts commit 15f393f189 .
The change caused many service test failures due to changed line numbers.
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2762583003 .
2017-03-20 13:42:55 -07:00
Jacob Richman
15f393f189
Run dartfmt on all files under runtime.
...
I've omitted files where the formatter output is significantly uglier
than the original code and I'll send those files in a separate CL
with options for how to make the code look reasonable while still
taking advantage of the formatter.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2751423005 .
2017-03-20 13:13:50 -07:00
Ryan Macnak
b15b98bcc3
Reapply "Use CodeSourceMap for stack traces (still JIT only)."
...
- Fix missing null termination in initialization of ZoneTextBuffer.
- Merge with John's async stack trace changes.
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2686813006 .
2017-02-09 18:03:41 -08:00
Ryan Macnak
15a9eafb77
Revert "Reapply "Use CodeSourceMap for stack traces (still JIT only).""
...
This reverts commit bee82fef8b .
Revert "Use zone memory for StackTrace::ToCString."
This reverts commit 4e8b265ea0 .
The later CL somehow caused hangs in some service tests.
Review-Url: https://codereview.chromium.org/2683033007 .
2017-02-09 13:14:01 -08:00
Ryan Macnak
bee82fef8b
Reapply "Use CodeSourceMap for stack traces (still JIT only)."
...
Include CodeSourceMaps in app-jit snapshots.
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2686623006 .
2017-02-08 16:43:47 -08:00
Srdjan Mitrovic
b3405d5ebc
Add --no-background-compilation to tests that expect to run code in optimized form
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org/1759973002 .
2016-03-02 16:30:58 -08:00
fschneider@google.com
bdd6b29fd8
Revert r40306 because of crash.
...
TBR=vegorov@google.com
Review URL: https://codereview.chromium.org//572913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40312 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 12:14:33 +00:00
fschneider@google.com
cd78dbe709
Refactor generating lazy deoptimization descriptors.
...
Instead of having special handling for closure calls, pass
the number of input operands down so that the correct lazy
deoptimization environment is generated at calls.
There is no functional change here - this is to simplify
having calls with pushed arguments and input operands
(like closure calls).
Runtime calls still do not have a correct lazy deoptimization environment
the environment should only be used for creating stack traces
from optimized code.
Fix a bug with --trace-deoptimization-verbose printing: We
cannot call ToCString on objects when the slots have not
been filled in yet. (e.g. Closures)
R=vegorov@google.com
Review URL: https://codereview.chromium.org//575443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40306 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 10:31:47 +00:00
regis@google.com
303011f48d
Enable all vm tests on simarm (skip 2 timing out byte array tests).
...
Reduce number of iterations in inline_stack_frame_test to avoid time out.
R=zra@google.com
Review URL: https://codereview.chromium.org//14651005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22280 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-01 21:10:00 +00:00
floitsch@google.com
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
lrn@google.com
53f877edb7
Rename String.concat to operator+.
...
Review URL: https://codereview.chromium.org//12441003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19788 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 12:59:17 +00:00
floitsch@google.com
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
asiva@google.com
09ce352df7
Fix comment in test case.
...
Review URL: https://codereview.chromium.org//11783035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16821 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 21:04:36 +00:00
asiva@google.com
9c4e6eb72f
Added a test to ensure that stack frames are reported correctly when an exception is thrown in a chain which has inlined methods. This test currently fails and I have added an issue 7757 for it and skipped it in the status file.
...
Review URL: https://codereview.chromium.org//11781007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16778 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 01:53:47 +00:00