dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

16 Commits

Author SHA1 Message Date
Ryan Macnak b59923de58 Partial static mode changes for vm-service tests. 
Bug: https://github.com/dart-lang/sdk/issues/31587
Change-Id: I9fc7d83aab68ee2b30d71f8a3a75b74fa4dde55e
Reviewed-on: https://dart-review.googlesource.com/30390
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-12-19 17:45:55 +00:00
Jacob Richman 4360e99d18 Revert "Fix observatory tests broken by running dartfmt." 
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/62be0eacfbb36bdc92a05c7c35bb4506621b6a3a
Review-Url: https://codereview.chromium.org/2767533002 .
 2017-03-21 10:07:26 -07:00
Jacob Richman 62be0eacfb Revert "Fix observatory tests broken by running dartfmt." 
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.

BUG=

Review-Url: https://codereview.chromium.org/2767533002 .
 2017-03-20 22:19:22 -07:00
Jacob Richman 88f8aacd5f Re-apply rolled back CL to apply dartfmt to runtime. 
Fix observatory tests broken by running dartfmt due to line and column changes.
Temporarily reverted formatting for evaluate_activation_test.dart as dartfmt doesn't yet handle multitests.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2759973004 .
 2017-03-20 21:44:59 -07:00
Ryan Macnak ea4744a06f Revert "Run dartfmt on all files under runtime." 
This reverts commit 15f393f189.

The change caused many service test failures due to changed line numbers.

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2762583003 .
 2017-03-20 13:42:55 -07:00
Jacob Richman 15f393f189 Run dartfmt on all files under runtime. 
I've omitted files where the formatter output is significantly uglier
than the original code and I'll send those files in a separate CL
with options for how to make the code look reasonable while still
taking advantage of the formatter.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2751423005 .
 2017-03-20 13:13:50 -07:00
John McCutchan e577dd8438 Remove --compile_all from all but one service test 
BUG=

Review URL: https://codereview.chromium.org//1286493004 .
 2015-08-10 14:20:05 -07:00
Srdjan Mitrovic a3e1db6263 Fix --compile_all flag (--compile-all is wrong) 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1230883002 .
 2015-07-09 13:16:37 -07:00
Todd Turnidge c4dad3117a Make VM event streams look like real dart streams. 
This is a bit ugly in that vm event streams are created
asynchronously, which is not very natural with the dart libs.

Update tests accordingly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1217823009 .
 2015-07-08 14:18:59 -07:00
Todd Turnidge 6c2ebfcc60 Switch to using SourceLocation universally in service protocol. 
Add <location-link> and <location-inset> to provide links and insets
for a location.

Make Frame, Message, and SourceLocation first class in service lib.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1150303004
 2015-06-03 09:02:40 -07:00
Todd Turnidge ab6b2218b0 Standardize on using "kind" to distinguish sub-varieties of a type. 
- Event.eventType -> Event.kind.
- Sentinel.id -> Sentinel.kind.

We were already doing this for Code and will do so for Instance in
an upcoming cl.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1153193006
 2015-05-28 11:04:32 -07:00
Todd Turnidge 8d24372339 Revert "Add the streamListen and streamCancel rpcs to the vm service." 
This reverts commit 0967b63073.

Conflicts:
	runtime/observatory/tests/service/graph_test.dart
	runtime/vm/service.cc

BUG=

Review URL: https://codereview.chromium.org//1152283005
 2015-05-26 15:22:39 -07:00
Todd Turnidge 0967b63073 Add the streamListen and streamCancel rpcs to the vm service. 
We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph.

    Only generate events when at least one client is listening to the
    corresponding event stream.

    Only send events to the clients that actually request them.

    Implement this all as Dart streams in the service lib.

    Update tests.  Fix a race in async_generator_..._test that was biting me.

Review URL: https://codereview.chromium.org//1143783003
 2015-05-26 13:52:35 -07:00
rmacnak@google.com 06bd41df60 Use words please. 
eval -> evaluate

isolate.evaluate(object, expression) -> object.evaluate(expression)

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1133733005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45823 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 20:28:28 +00:00
turnidge@google.com ca5de9eac9 Kill service_test.cc tests in favor of dart tests for the service protocol. 
Associated cleanups and fixes that I noticed as I rewrote the tests.

Review URL: https://codereview.chromium.org//1090293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45257 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 21:08:02 +00:00
johnmccutchan@google.com 647c355f8c Relocate service library tests and hookup a working status file 
BUG=

Review URL: https://codereview.chromium.org//1071363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45043 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 22:57:59 +00:00