87ee6cc0d6
Polyfill only once
...
Avoid dcall on polyfill.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2983903002 .
2017-07-19 13:42:23 -07:00
99e672d1cb
Registration-based approach to cross frame support.
...
This approach installs all Dart extension types onto a window whenever
that window is accessed.
See #28326
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2980853002 .
2017-07-19 12:53:43 -07:00
12e32e230d
Add hook to register global object
...
DDC will use this in a later CL.
R=alanknight@google.com , sra@google.com
Stephen: I assume this will get compiled out be dart2js.
Review-Url: https://codereview.chromium.org/2983813002 .
2017-07-19 05:46:07 -07:00
7365a24d98
Fix DDC status
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2981213002 .
2017-07-18 13:59:57 -07:00
ab39958ac5
Dummy DDC implementation of MirrorSystem
...
It's a bit absurd that a bunch of tests are passing with this.
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2978223002 .
2017-07-18 13:00:23 -07:00
34361bb02a
fix #30138 , reland with windows fix
...
Revert "Revert "fix #30138 , synethic nodes causing crash generating source maps""
This reverts commit b7e3d9185dR=vsm@google.com
Review-Url: https://codereview.chromium.org/2977183002 .
2017-07-17 15:58:24 -07:00
87c0b757cb
fix #27320 , better DDC temp generation
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2980113002 .
2017-07-17 14:33:30 -07:00
8913dd97df
Update ddc dart:html
...
This is just a straight copy of the dart2js version to pick up sra's range fix.
TBR=sra@google.com ,alanknight@google.com
Review-Url: https://codereview.chromium.org/2983693002 .
2017-07-17 12:14:30 -07:00
9f059e58b4
Move null check out of getExtensionType
...
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2980133002 .
2017-07-14 17:02:09 -07:00
b7e3d9185d
Revert "fix #30138 , synethic nodes causing crash generating source maps"
...
This reverts commit 52880e9c4chttps://codereview.chromium.org/2977163002 .
2017-07-14 15:54:23 -07:00
52880e9c4c
fix #30138 , synethic nodes causing crash generating source maps
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2977943002 .
2017-07-14 12:46:22 -07:00
cc167f5901
fix #30108 , mock support for callable classes
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2975273002 .
2017-07-14 12:42:16 -07:00
418d11fbd6
fix #30094 , assert should work with a function
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2971243003 .
2017-07-13 22:51:45 -07:00
4f7fa8a930
Check for null when getting the extension type.
...
isJsInterop can call this with null.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2983523002 .
2017-07-13 16:48:25 -07:00
4a87156b13
Move NullError into interceptors
...
Put the NullError class into interceptors so that it will be picked
up as a native type.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2976173002 .
2017-07-13 14:38:39 -07:00
d952055a7e
Support ClassMirror.newInstance on factory constructors
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2976133002 .
2017-07-13 13:07:37 -07:00
5a74d8ab09
Properly handle Windows file: URLs on Node.js ( #30098 )
...
This adds logic to the JS implementation of URI to determine whether
the code is running on Windows under Node.js.
2017-07-12 14:57:01 -07:00
d7544d2452
Fix bad merge
...
R=leafp@google.com
Undo this:
https://github.com/dart-lang/sdk/commit/90380dfdfa4c0feb1ed2a896c4ad9fb20774aa64#diff-faec4ab5f53e175ed283041f1fe3c0bf
Review-Url: https://codereview.chromium.org/2980623002 .
2017-07-11 11:23:33 -07:00
5b742853c7
Treat JS TypeError as Dart NSM
...
Fixes #30134
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2979613002 .
2017-07-11 05:44:22 -07:00
7b17a3dd01
Use "|" as the separator between module path and name. ( #30106 )
...
* Use "|" as the separator between module path and name.
":" is already a path character in Windows. This is why the
dartdevc tests aren't working on Windows. Because they try to do:
-sC:/some/path/blah.dart:blah
And it splits at the first ":". Oops.
* Switch to "=" for separating module path from name.
It looks a little funny when used with "--summary=", but it works fine
and is very unlikely to be used for anything else on any platform
(since we already use it as the separator between arg name and value).
2017-07-07 17:13:43 -07:00
db02df3d3f
update strong mode test for fasta scanner
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2973963002 .
2017-07-07 12:27:48 -04:00
666b8713d4
fix libraries getter
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2965283002 .
2017-07-06 14:38:28 -07:00
90380dfdfa
fix #27259 , implement covariance checking for strong mode and DDC
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2954523002 .
2017-07-06 14:31:35 -07:00
79cace0848
fix #29028 , understand promoted type parameters
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2969373002 .
2017-07-06 13:16:23 -07:00
7c1e0bea36
add reload to dart_library
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2970283002 .
2017-07-06 13:16:14 -07:00
a67db4cd1e
Remove failures
...
Weird - passing now. Maybe some flakiness in our test framework?
TBR=jmesserly@google.com ,rnystrom@google.com
Review-Url: https://codereview.chromium.org/2971193002 .
2017-07-06 10:06:54 -07:00
5533a256cb
fix #30030 , fix #27327 - fix tearoffs and various Object member bugs
...
this includes various cleanups found along the way:
* various issues with JS annotations, see #30043
* getGenericClass is now optimized when used in a JS builtin with a Type literal
* typed list literals should be slightly faster to create
* memoized getters used by dart:_runtime should be faster
* registerExtension should be a tad faster, and now understands JSArray
* dart.bind "safeName" hack gone in codegenerator
* JSArray<E>.runtimeType returns List<E>
* JSArray<E>.noSuchMethod works
* cleans up code that generates `setExtensionBaseClass` (used only by JSArray)
* _throwUnsafe helper for generating a `throw` in --unsafe compile mode
* fix tearoff of JS interop types (_emitSimpleIdentifier)
* fix TODO about splitting LazyJSType and AnonymousJSType
* fix is/as/cast methods on TypeRep and related classes
* fix codegenerator to not tearoff "hashCode" and "runtimeType" (they are not methods)
* fix NoSuchMethodError.toString() (update via dart2js sdk impl)
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2962263002 .
2017-07-05 14:17:53 -07:00
52a9e3d9c6
Fix build_pkgs.dart to not mutate arguments list. ( #30078 )
...
* Fix build_pkgs.dart to not mutate arguments list.
Also remove build of when package since it's apparently gone now.
* Use sublist to remove element.
2017-07-05 12:20:58 -07:00
7b766556a1
Update test status
...
See #30075
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2967193002 .
2017-07-05 10:16:25 -07:00
9cbd5bdc2e
Output errors for tests that fail to compile
...
This makes it easier to fix strong mode errors in tests.
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2971443002 .
2017-07-05 09:37:14 -07:00
6f73694bb7
Generate better code for '==', core.identical, and dart.test.
...
Avoid falling back to the dart.equal runtime helper where possible based on static types. Also uses JS `==` or `===` in some cases.
Treat core.identical as a compiler intrinsic, based on type.
Make dart.test assume correct types, use dart.dtest for combined cast and nullability check only when required.
Fixes https://github.com/dart-lang/sdk/issues/29851
Fixes https://github.com/dart-lang/sdk/issues/29772
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2926613003 .
2017-06-30 15:04:29 -07:00
24743461c9
Fix test.sh to not run non-existent shell script.
...
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2964123002 .
2017-06-29 17:25:17 -07:00
24f9478550
Fix handling of inline JS types in DDC.
...
DDC was incorrectly interpreting inline JS types, and hence marking
some things as non-nullable which were nullable. This fixes that, and
also slightly improves the analyzers treatment of inline JS types.
Also fixes some incorrect inline JS type annotations in DDC patch
files.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2965633002 .
2017-06-29 16:02:04 -07:00
0b2c9b048d
Dynamically load packages for dartdevc tests in test.dart.
...
This involves a few pieces:
- Add support to DDC for specifying the module name associated with a
given summary. This lets test.dart invoke DDC using summaries in the
build directory outside of the directory containing the test itself.
- Add support to the build scripts for building the packages. This adds
a new GN target that builds everything needed to run test.dart with
dartdevc. In particular, it invokes build_pkgs.dart to compile the
relevant packages to JS+summary so that the tests can use them.
This requires some changes to build_pkgs.dart so it can output to a
given directory.
- In test.dart, when tests are compiled with dartdevc, pass in the
summaries for the packages so they don't get compiled in. Then, when
the test is run, configure require.js with the right paths to their
JS files so they can be loaded.
I also removed a bunch of unneeded buildDir parameters being passed
around the various CompilerConfiguration class methods now that they
have direct access to the configuration.
Fix #29923 .
R=vsm@google.com , whesse@google.com , zra@google.com
Review-Url: https://codereview.chromium.org/2955513002 .
2017-06-29 13:45:57 -07:00
94af6bf093
fix #29733 , handle variables that completely shadow parameters
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2961863003 .
2017-06-29 10:39:09 -07:00
e84fd776cb
Improve runtime error when a module is not loaded
...
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2959323002 .
2017-06-29 08:09:26 -07:00
83d9e3fc91
Fix a few unused imports and symbol warnings.
...
BUG=
R=messick@google.com
Review-Url: https://codereview.chromium.org/2961013002 .
2017-06-28 09:44:38 -07:00
fd6164cce4
Handle toString on DOM types
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2952363003 .
2017-06-27 09:22:25 -07:00
029b1cb948
Spelling fixes e to i.
...
R=kevmoo@google.com
BUG=
Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
daf960d5a4
Fix Object method tearoffs
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2953933002 .
2017-06-22 15:59:45 -07:00
7d73159017
Fix ddc build
...
Not sure why this just started breaking. I don't think Ben added this
param - just a use of it. Our patch script might not be catching the
mismatch.
TBR=jmesserly@google.com ,bkonyi@google.com
Review-Url: https://codereview.chromium.org/2954513003 .
2017-06-22 14:27:22 -07:00
635d95fccf
cleanup unused useDisplayName parameter
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2953883002 .
2017-06-22 14:17:44 -07:00
febded6052
Fix mocked operator methods
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2949123002 .
2017-06-21 16:54:08 -07:00
ecca1e1c2a
Add FallThroughError patch
...
TBR=jensj@google.com ,rnystrom@google.com
Review-Url: https://codereview.chromium.org/2953693002 .
2017-06-21 16:33:31 -07:00
070f31a899
optimize null safe ops by using DDC's let abstraction
...
We were already using it for most other things (increment ops, op assign, ??, cascades, etc)
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2944413002 .
2017-06-20 10:31:30 -07:00
ed8de04f08
Fixes for super tearoff in constructor
...
Fixes #29932
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2944003003 .
2017-06-19 13:39:53 -07:00
93a02bf8f9
fix super setters when super is not allowed
...
We were generating these incorrectly. This also improves the code structure around super helpers as well as accessors vs fields.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2940323003 .
2017-06-16 11:49:51 -07:00
c848476643
fix super from constructors
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2938713002 .
2017-06-13 16:47:20 -07:00
1f50f0d126
fix mixins with factory constructors
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2935933005 .
2017-06-13 15:58:50 -07:00
9e3fdbf94d
Update DDC core patch for ConstantExpressionError
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2941593002 .
2017-06-13 13:57:42 -07:00
Vijay Menon