dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

1931 Commits

Author SHA1 Message Date
Vijay Menon 69279d6b62 Fix summary path for tests 
Should get travis back to green

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2470053002 .
 2016-11-01 21:12:01 -07:00
Jennifer Messerly 2e8d011ca3 fix #27607, add dev_compiler summary to the SDK and move JS files 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2474523003 .
 2016-11-01 18:17:43 -07:00
Vijay Menon 9d34f30c9c Build collection as a separate test pkg 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2462263002 .
 2016-11-01 06:04:57 -07:00
Vijay Menon 830cf7c3ea Test packages with ddc on travis 
Here's a setup to test build of various SDK packages with DDC and strong mode per commit on travis.

It's not an ideal setup:
- If deps / files change, this will need updating.
- It only breaks on error, not warning.
- It doesn't actually run any package tests.

I haven't gone through all packages either.  Might be worth automating something like this.

See try-run here:

https://travis-ci.org/dart-lang/sdk/builds/172066040

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2465923003 .
 2016-11-01 06:01:45 -07:00
Vijay Menon 2d15b4ae74 Type-related fixes 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2468493003 .
 2016-10-31 15:01:29 -07:00
Natalie Weizenbaum dddede61fe Allow trailing options in DDC. (#27691) 2016-10-31 14:23:58 -07:00
Vijay Menon e8fbfc4f0d Mark test as runtime failure 
pkg collection is now clean.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2466533002 .
 2016-10-31 06:00:59 -07:00
Jan-Hendrik Dolling 89560c68a0 change "the the" to the 2016-10-28 21:47:50 +02:00
Jennifer Messerly bdeb6023af fix #27672, call computeConstantValue for metadata 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2458693003 .
 2016-10-27 14:05:54 -07:00
Jennifer Messerly 644c1dca75 fix #27429, html wrapper methods pass incorrect number of arguments 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2454173003 .
 2016-10-27 13:16:00 -07:00
Vijay Menon f276f3422f Mark test strong clean for DDC 
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2457753002 .
 2016-10-27 16:13:43 +02:00
Adão Júnior 205e9a58e1 DDC readme links pointing to current repository (#27662) 2016-10-26 10:50:46 -07:00
vsmenon 2cafc4d044 Update README.md 2016-10-24 09:01:50 +02:00
Jennifer Messerly ce76fc1fe5 fix #27644, allow "dart" and "dartx" to be renamed if needed 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2435223002 .
 2016-10-21 11:48:19 -07:00
Jennifer Messerly 982f9f46ed fix #27642, static members should now work 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2440863002 .
 2016-10-21 11:25:47 -07:00
Jennifer Messerly 95ef8bb59a fix #27643, failed to virtualize fields if an abstract one is mixed in 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2441693003 .
 2016-10-20 16:31:06 -07:00
Vijay Menon ce963596f0 Emit API-only summaries 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2435203002 .
 2016-10-20 16:21:53 -07:00
Jennifer Messerly cc1ad8cdde fix #27532, implementing a native type with fields 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2430953006 .
 2016-10-20 15:59:18 -07:00
Jennifer Messerly 5111675810 fix #27631, get/set methods no longer shadow index operator 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2435163002 .
 2016-10-20 15:45:29 -07:00
Brian Wilkerson 96750cd5cb Split out options from ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2425423009 .
 2016-10-20 11:03:11 -07:00
Alan Knight 47150f50d5 Use dart:html prefixes (e.g. webkitAudioNode) on other browsers 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2431443002 .
 2016-10-19 16:43:41 -07:00
Jacob Richman 4f6ce11bc8 Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag that performs permissive dynamic calls on private members. Polish web_command.dart adding the ability to evaluate code in the context of an existing library. 
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2423313002 .
 2016-10-18 16:34:48 -07:00
Nicholas Shahan 3f67c24cb8 Revert "Fix library name insert and access inconsistency on windows" 
This reverts commit d8505ee264.

It was found to cause issues in the web file system when one file
was found to be within a root path.

R=jacobr@google.com

Review URL: https://codereview.chromium.org/2432603002 .
 2016-10-18 16:25:03 -07:00
Vijay Menon a032a4c952 Revert "Fix file name handling on windows" 
This appears to break on bazel.

BUG=
R=nshahan@google.com

Review URL: https://codereview.chromium.org/2422403002 .
 2016-10-17 15:27:48 -07:00
Bob Nystrom 60a966605d Remove uses of unittest in the HTML tests where possible. 
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.

In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578).

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2419863002 .
 2016-10-14 13:44:19 -07:00
Vijay Menon 852ef37f71 Some mirrors fixes 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2415053004 .
 2016-10-14 12:19:24 -07:00
Bob Nystrom ae5a566f98 Move minitest.dart into the expect package. 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2416853003 .
 2016-10-13 14:15:21 -07:00
Bob Nystrom 2305865365 Start cleaning up the HTML tests. 
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2413073002 .
 2016-10-13 08:47:27 -07:00
Nicholas Shahan 96f485b075 Fix file name handling on windows 
Paths on windows were having the drive letter (ex: c:\) recognized as
a URI scheme.

Fixes #27450

R=vsm@google.com

Review URL: https://codereview.chromium.org/2413823002 .
 2016-10-12 14:30:15 -07:00
Nicholas Shahan d8505ee264 Fix library name insert and access inconsistency on windows 
Make naming of libraries on windows consistent with the behaivor on
linux and mac.

Fixes #27576

R=vsm@google.com

Review URL: https://codereview.chromium.org/2415653002 .
 2016-10-12 14:14:00 -07:00
Vijay Menon 2495f6a060 Handle private members in dart:mirrors 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2410453002 .
 2016-10-10 15:55:20 -07:00
Bob Nystrom 9b6317d571 Stop using unittest in point_test and rectangle_test. 
This also makes rectangle_test strong mode clean. Alas, the test isn't
passing because of another bug, but once that bug is fixed, it should.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2407913002 .
 2016-10-10 11:02:37 -07:00
Bob Nystrom b30571884f Use expect instead of unittest for json_lib_test. 
One step closer to removing the deprecated unittest.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2402123002 .
 2016-10-10 09:42:40 -07:00
nshahan 0132d6114a Fix for the missing new keyword on an external factory call. 
Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test

Fixes #27443

R=jacob314@gmail.com, vsm@google.com

Review URL: https://codereview.chromium.org/2394103002 .
 2016-10-06 10:24:38 -07:00
Vijay Menon 8846988b1d Travis / chrome fixes 
- Use google-chrome-stable by default
- Use google-chrome-unstable as Canary (instead of trying to determine last-known-good-revision - we has issues with that yesterday)
- Test chrome stable and unstable separately on travis

Try bot:
https://travis-ci.org/dart-lang/sdk/builds/165541943

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2396433007 .
 2016-10-06 08:33:06 -07:00
Vijay Menon ef973f7d56 Restore unittests 
Fixes #27261

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2345853002 .
 2016-10-05 16:58:53 -07:00
Vijay Menon 4b2d1e06f3 Workaround from Chromium breakage 
We're installing the latest Chromium Canary on travis.  It appears
broken on Linux.  Pinning pending further investigation.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2398843002 .
 2016-10-05 16:32:11 -07:00
Bob Nystrom 20e402c43d Fix type errors in math.min() and math.max(). 
Really, this works around them, but the workaround is all round better
code.

Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2386493003 .
 2016-09-30 13:18:07 -07:00
Bob Nystrom 2c313a43ac Fix some errors around []= in core types. 
- Get rid of JSMutableIndexable since it isn't useful.
- Make JSIndexable generic. (I think dart2js already did.)
- Add .length to NativeTypedArray since it no longer inherits it from
  JavaScriptIndexingBehavior.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2378423003 .
 2016-09-30 13:03:10 -07:00
Vijay Menon 6144c10409 Fix analyzer error 
Analyzer was complaining that final field was not set.  The other constructor
does set, so doing so here as well.  We may be able to remove this flag soon,
but I see downstream uses.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2382463002 .
 2016-09-28 10:21:15 -07:00
Vijay Menon 68d2121fd0 Use .packages instead of pubspec.yaml 
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2371113004 .
 2016-09-28 09:49:31 -07:00
Roman Vanesyan 3a4b32d957 Update STRONG_MODE.md (#27391) 
Correct quotes.
 2016-09-26 11:57:22 +02:00
John Messerly 1129d3d121 fix #27421, DDC did not generate implicit super calls in some cases 
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers

R=vsm@google.com

Review URL: https://codereview.chromium.org/2365053003 .
 2016-09-23 17:06:10 -07:00
John Messerly 361cd4c61c fix #27408, reverts "ignore dynamic in inference" 
this reverts https://github.com/dart-lang/sdk/commit/8c25a41accf52265a89bcc2ffac3bdb7c271f9fb

R=vsm@google.com

Review URL: https://codereview.chromium.org/2360973004 .
 2016-09-23 17:01:33 -07:00
Vijay Menon ead14fbd74 Update global_compile tool 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2363053003 .
 2016-09-23 13:30:18 -07:00
Vijay Menon d10d77aada Remove pubspec.lock 
Otherwise we break whenever a dep gets updated.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2370433002 .
 2016-09-23 08:45:10 -07:00
John Messerly adc71ab396 re-land fix #27110 with proper DDC side of changes 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2362563004 .
 2016-09-22 15:47:55 -07:00
Vijay Menon aae63b7e21 Regenerate DDC SDK 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2358323002 .
 2016-09-21 16:39:24 -07:00
Vijay Menon a22b3b6205 Runtime fixes on DDC tests 
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2354383003 .
 2016-09-21 16:12:30 -07:00
Vijay Menon 8e943b8c59 Fix tests 
This fixed the original 5 static errors from this morning.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2356413002 .
 2016-09-21 13:59:55 -07:00