dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

26 Commits

Author SHA1 Message Date
Jenny Messerly b62276d97f fix DDC SDK implementation JS type annotations to work with CFE 
This migrates the JS builtin's string type to the `<T>` type parameter
for a few more cases. This was done to eliminate null checks, casts and
dynamic calls when dartdevk builds the SDK, so it matches dartdevc.

Change-Id: I8570e5127149a45289a90002c27034333c3038ad
Reviewed-on: https://dart-review.googlesource.com/51207
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-17 19:29:40 +00:00
Jenny Messerly 5013b28bbe fix #31999, remove fuzzy arrow runtime support from DDC 
Also updates tests that relied on fuzzy arrows.

Change-Id: Ia8df1d8d421e43dfada589223d5e46182b92fa67
Reviewed-on: https://dart-review.googlesource.com/37425
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-31 22:20:38 +00:00
Leaf Petersen 1ed4096b4e Remove generic comment syntax from pkg/dev_compiler. 
Bug:
Change-Id: Ifc823c2b703ec70cd97981f08b29396de516f678
Reviewed-on: https://dart-review.googlesource.com/30382
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2017-12-19 22:03:43 +00:00
Bob Nystrom 979a75c4b3 Fix more errors in DDC SDK. 
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2871363002 .
 2017-05-11 11:22:05 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Erik Corry 6617737ff5 Replace 'the the' with 'the' 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2830353002 .
 2017-04-24 08:50:37 +02:00
Jacob Richman 9484ac8bdf Format all dart dev compiler files 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2752163002 .
 2017-03-15 21:34:25 -07:00
Jacob Richman badfd146d2 Fix type error in js_dart2js.dart caught by DDC. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2611423002 .
 2017-01-09 07:42:49 -08:00
Jacob Richman 93fb5d8119 Fix cross-window JS interop on FireFox. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2610813003 .
 2017-01-04 14:15:20 -08:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc. 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
 2016-12-19 15:00:55 -08:00
Mohamed Hayibor 5595b9698d Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' (#27853) 
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
 2016-11-18 09:36:25 -08:00
Jacob Richman fb467ef68a Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2504733002 .
 2016-11-15 12:52:28 -08:00
Jacob Richman f0cde883e9 Change allowInterop to a generic method. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2106613002 .
 2016-06-29 14:41:32 -07:00
Bob Nystrom 44db042cd8 Redo how Type objects are exposed from DDC. 
- Instead of using the raw runtime type that DDC uses for its type
  checks, use a WrappedType that correctly implements Type's interface.
- Compile class literals to wrap the type in a WrappedType.
- Make Object.runtimeType() do the same thing.

Fixes #488. Fixes #511.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1944483002 .
 2016-05-03 14:24:08 -07:00
Vijay Menon dc8e00b2da Revert "Workaround #537" 
Undoing this.  Paul fixed this in 1.17.  We'll need to run with 1.17 builds going forward, but we need that for other reasons.

Fixes #537

R=jacobr@google.com

Review URL: https://codereview.chromium.org/1936693002 .
 2016-05-03 10:38:59 -07:00
Vijay Menon b2c0a7446e Workaround #537 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1933383002 .
 2016-04-29 12:47:16 -07:00
Jacob Richman 7db49e6a44 Fixed 3 final missing casts in dart:js 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1931373002 .
 2016-04-29 08:50:14 -07:00
Jacob Richman 27ed87462b Cleanup dart:indexed_db, dart:svg, and dart:js errrors. update dart:html with extra generic methods. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1909193002 .
 2016-04-21 14:51:18 -07:00
Vijay Menon c75d51d6bf Fixes #460 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1718353002 .
 2016-02-22 15:03:56 -08:00
John Messerly 5b45c6ef87 partial fix for #414, avoid dcall in _convertToDart 
this doesn't fix the root call, but still, it's nice to clean up this dead code

R=vsm@google.com

Review URL: https://codereview.chromium.org/1609843002 .
 2016-01-19 12:02:06 -08:00
Vijay Menon e29437a374 First cut of mini dart:html. 
This gets us going on Angular.

Note, this is auto-generated from my hacked up versions of the dom scripts.  Still tackling the long tail of sdk errors.

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1528613004 .
 2015-12-15 13:08:17 -08:00
Jacob Richman d0cec4ac47 Switch ddc to use @JS instead of @JSName. Also update dart:js to support new public methods added for 1.13 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1448993002 .
 2015-11-16 12:55:30 -08:00
Vijay Menon 2358366f56 Rewire DDC to use the analyzer task model 
This is WIP - not quite ready for review.

Not all tests are passing yet.  Most checker and inference tests are passing, but about a quarter are failing - need to look.

The non-runtime changes under lib along with test/testing.dart are the only real changes.

We seem to be losing some type info - lots of new casts - but I see at least one removed.

R=brianwilkerson@google.com, jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1355893003 .
 2015-10-08 13:42:53 -07:00
Vijay Menon 2ef54c946b Fixes for Angular 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1324693004 .
 2015-09-02 13:39:53 -07:00
John Messerly c2e65df22c fixes #168, dart:js implementation with a test 
R=vsm@google.com

Review URL: https://codereview.chromium.org/1200233004.
 2015-06-25 13:18:52 -07:00
John Messerly d1a4c5dc94 first step for #168, adds dart:js impl to the build 
the code most likely does not work yet. But this gets it in so we can iterate more easily, from a clean baseline.

R=jacobr@google.com

Review URL: https://codereview.chromium.org/1179643005.
 2015-06-12 15:17:38 -07:00