b07a4bc264
improve deduping of cached types in DDC/K
...
This works around broken FunctionTypeImpl.== in Analyzer. Also
makes DDK's type naming heuristic more consistent with DDC.
Change-Id: I09527fad681c3fdc6c66654e572e9b03c57491bd
Reviewed-on: https://dart-review.googlesource.com/37120
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Jenny Messerly <jmesserly@google.com >
2018-04-04 00:37:21 +00:00
68dc77f456
Build DDC's SDK as part of the regular build.
...
This involves a few main pieces:
- Add code to the GN scripts to generate DDC's patched SDK and then
compile it to summaries and JS in the build output directory.
- Add support to the underlying DDC build scripts to support controlling
which files are built where.
- Update test.dart to use the DDC SDK from the build directory.
- Update create_sdk to use the built SDK instead of the checked in one.
- Fix various internal DDC tools to build their own copy of the SDK
(since they can't easily find the one in the build directory because
it's path if config-specific) and use those.
- Delete the checked DDC SDK JS and summaries.
I think I got everything working. The built Dart SDK looks fine -- it's
identical to one built using the old build scripts.
The various tools and DDC's little test runner I *think* work, but there
may be a bug or two in there. I tried the various things I could and it
seems like they work but it's hard to tell since they may be kind of
broken right now anyway.
Bug:
Change-Id: Iea77915a5c1cc8450f60ebfbdf8c725c7ea2f32c
Reviewed-on: https://dart-review.googlesource.com/18144
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2017-11-20 23:24:07 +00:00
4afc0aeb73
Fix some analysis issues.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2882003002 .
2017-05-13 16:24:47 -07:00
334373b1dc
Temporarily disable overlapping summary check
...
Turning this off to unblock the current roll. We'll try flipping the
flag internally and shaking out the last violators.
R=keertip@google.com
Review-Url: https://codereview.chromium.org/2853543002 .
2017-04-28 11:08:05 -07:00
21c38e6c8c
Various DDC fixes for windows
...
This gets most tests compiling and running on Windows.
Fixes #27450
Fixes #27797
Fixes #28752
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2833633002 .
2017-04-20 11:30:57 -07:00
a3d2e49198
Revert "Revert "Report error if the same uri appears in multiple summaries.""
...
Relanding after fixing package_bundle_reader_test.dart.
Note, original CL (already reviewed here: https://codereview.chromium.org/2781483007/ ) is patch set 1.
Test fix is patch set #2 .
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2825503002 .
2017-04-17 10:11:21 -07:00
dcdccf4750
Revert "Report error if the same uri appears in multiple summaries."
...
This reverts commit 2afa21bb2cTBR=jmesserly@google.com
BUG=
Review-Url: https://codereview.chromium.org/2821933002 .
2017-04-17 08:07:36 -07:00
2afa21bb2c
Report error if the same uri appears in multiple summaries.
...
Fixes #27025
R=brianwilkerson@google.com , jmesserly@google.com
Review-Url: https://codereview.chromium.org/2781483007 .
2017-04-17 07:32:59 -07:00
d1030e9be0
Don't hardcode 'dart' as the executable name to spawn.
...
I don't think it's on the PATH on the buildbots.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2617013003 .
2017-01-05 16:44:09 -08:00
5b84611856
refactor DDC to support --ignore-unrecognized-flags
...
* add --ignore-unrecognized-flags to DDC
* refactor Analyzer CLI to use same filterUnknownArguments functionality
* remove now unused CommandLineParser and associated tests
R=brianwilkerson@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2578113002 .
2016-12-15 10:46:09 -05:00
8f04f902df
fix #27771 , create directory if needed
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2483753004 .
2016-11-08 10:21:31 -08:00
69279d6b62
Fix summary path for tests
...
Should get travis back to green
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2470053002 .
2016-11-01 21:12:01 -07:00
36273565e3
fixes #610 , incorrect help output
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2244703003 .
2016-08-12 15:06:41 -07:00
0aa5cbd128
fix #620 , infer the input files from sources
...
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2234343003 .
2016-08-11 13:19:36 -07:00
c3ee6dc5ee
fix #606 , allow specifying the summary file extension
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/2176763002 .
2016-07-22 11:39:35 -07:00
477182e88d
fix worker_test
2016-06-14 14:54:20 -07:00
f0517c4deb
Enable strong mode in DDC, fix all warnings/errors
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2016483002 .
2016-05-26 11:13:32 -07:00
9f764bf5b4
Make parts hermetic, fixes #531
...
R=paulberry@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org/1930133002 .
2016-04-28 13:37:10 -07:00
419f6e5382
add e2e tests for usage/compile errors
2016-04-20 14:29:38 -07:00
4e54ff0181
Move all args to per-request for the worker, and add a test
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1896613002 .
2016-04-18 11:17:08 -07:00
4e958f5f54
Support reading summaries in DDC
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1893603003 .
2016-04-15 13:52:18 -07:00
cb358696e1
dont reuse the analysis context across worker requests
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1892553003 .
2016-04-15 10:54:06 -07:00
308fa5ccb4
Add bazel worker support to the dev compiler.
...
BUG=
R=jmesserly@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/1884073003 .
2016-04-15 06:51:40 -07:00
Jenny Messerly