Commit Graph

14 Commits

Author SHA1 Message Date
Dan Rubel b79696982d Improve extraneous or out of position modifier recovery
In addition to improving modifier recovery, this CL
* Improves recovery when builtin keywords are used as types
* Updates ModifierContext to avoid parsing modifiers used as identifiers
* Addresses comment in https://dart-review.googlesource.com/c/sdk/+/34200
* Streamlines missing class body recovery
* Ensures the endMember event is sent during recovery

Change-Id: I87bda7c7da9d0e951427037087c7aa7e8e4da109
Reviewed-on: https://dart-review.googlesource.com/34520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-01-16 17:24:12 +00:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d.
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
Johnni Winther b31a2566d4 Use specific messages for const constructor with body.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1768143003 .
2016-03-10 10:09:17 +01:00
Florian Loitsch d41bce8cda Don't assume that we always have a HowToFix and remove failing test.
Also fix a typo.

Review URL: https://codereview.chromium.org/1769043002 .
2016-03-07 17:36:34 +01:00
Florian Loitsch dd326beee1 Move more messages.
Migrates some of the 'undefined' messages to the shared file.

R=brianwilkerson@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org/1750143005 .
2016-03-07 16:39:12 +01:00
Florian Loitsch 65b4256b9e Support multiple categories per message.
Also move more messages to use this feature.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1763373002 .
2016-03-07 16:37:57 +01:00
Florian Loitsch 7a7ecf299b Split the JSON output into multiple lines.
Otherwise a git grep will produce a huge output when finding the entry in the json db.

R=brianwilkerson@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/1711863005 .
2016-02-18 22:15:03 +01:00
Florian Loitsch 7db06aedc4 More shared messages.
R=brianwilkerson@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/1716463002 .
2016-02-18 22:13:15 +01:00
Florian Loitsch 4d26e4ec13 More shared messages.
R=brianwilkerson@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/1706033002 .
2016-02-18 17:21:04 +01:00
Florian Loitsch 3301bc7786 Use shared error for constructor's with return type.
Dart2js reports constructor's with return type, as long as the class is used.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1704173002 .
2016-02-17 23:50:41 +01:00
Florian Loitsch 830ac68d05 Share const-error messages.
R=brianwilkerson@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/1700243002 .
2016-02-17 20:10:30 +01:00
Florian Loitsch 6468ba5022 Share the first error messages.
R=brianwilkerson@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org/1660703002 .
2016-02-04 12:52:39 +01:00
Florian Loitsch 5cb3da473b Update messages, and fix typing in test.
Review URL: https://codereview.chromium.org/1625213003 .
2016-01-25 13:41:03 +01:00
Florian Loitsch c849a62744 Generate dart2js and analyzer files for shared messages.
R=brianwilkerson@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/1582903003 .
2016-01-25 13:08:40 +01:00