dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

34 Commits

Author SHA1 Message Date
Mike Fairhurst f22cdd8def Revert "Change completionTarget.forOffset to accept & wrap dangling AstNodes." 
This reverts commit fbfe5691cb.

Reason for revert: Subtle backwards incompatibility, with no obvious win-win fix.

Original change's description:
> Change completionTarget.forOffset to accept & wrap dangling AstNodes.
>
> Deprecate the entryPoint parameter, but still accept it in place of what
> used to be (positionally) compilationUnit.
>
> Detect if we have a compilation unit or not; and in the case we don't,
> add a new protection by asserting that it has no parent (its the root of
> the dangling tree).
>
> Its more of an implementation detail that completion contributors don't
> work well on dangling nodes, so fix it up for clients rather than
> expecting them to do it themselves.
>
> Change-Id: I3e454734e5b515f4e536f7229d541ca8c6aed60c
> Reviewed-on: https://dart-review.googlesource.com/52645
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

Change-Id: I64a6689f7862fb2d256b348491c79c58ee0fe1a9
Reviewed-on: https://dart-review.googlesource.com/52962
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-04-27 21:23:06 +00:00
Paul Berry 010d8144bc Add missing copyright notice 
Change-Id: I1283a9536c6ddad3c99e644cd8619e7202cfc5f6
Reviewed-on: https://dart-review.googlesource.com/52880
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-04-27 17:06:09 +00:00
Brian Wilkerson 1c5d1a56e7 Clean up some hints 
Change-Id: I623a4d86912ad0666b75ad519c15c84b24a5b579
Reviewed-on: https://dart-review.googlesource.com/52861
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-26 22:29:06 +00:00
Mike Fairhurst fbfe5691cb Change completionTarget.forOffset to accept & wrap dangling AstNodes. 
Deprecate the entryPoint parameter, but still accept it in place of what
used to be (positionally) compilationUnit.

Detect if we have a compilation unit or not; and in the case we don't,
add a new protection by asserting that it has no parent (its the root of
the dangling tree).

Its more of an implementation detail that completion contributors don't
work well on dangling nodes, so fix it up for clients rather than
expecting them to do it themselves.

Change-Id: I3e454734e5b515f4e536f7229d541ca8c6aed60c
Reviewed-on: https://dart-review.googlesource.com/52645
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-04-26 20:32:27 +00:00
Paul Berry 88099ffcc3 Stop importing front_end into analyzer_plugin. 
The symbols we previously needed (SyntheticBeginToken and
SyntheticToken) are now exported from the analyzer as of
dc21d3ce9d.

Change-Id: I5d0901c544fed0983d45c1da1dccfd5659a7777c
Reviewed-on: https://dart-review.googlesource.com/52821
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-04-26 19:12:46 +00:00
Mike Fairhurst 4bf738606b Fix (+test) dangling expression autocompletion for angular 
Change-Id: If35f998eb7fe38f21e30bfba3d87c507c07ebc7c
Reviewed-on: https://dart-review.googlesource.com/52522
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-04-24 22:04:13 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson b15860f43a Convert analyzer_plugin tests to pass under preview-dart-2 
Change-Id: I4531491524de0e93391a75a3972f249d604f0e2b
Reviewed-on: https://dart-review.googlesource.com/46568
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-15 16:54:59 +00:00
Brian Wilkerson 602a8c2a7b Clean up usage of deprecated constants 
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-09 01:02:49 +00:00
Brian Wilkerson 1d159e7c23 Rename annotation testing methods in Element 
Change-Id: I0f60b9abd3de350e62d89eac0d690a1db40316b7
Reviewed-on: https://dart-review.googlesource.com/45080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-05 17:23:48 +00:00
Brian Wilkerson ebe2ce681e Fix ClassElement.allSupertypes to include interfaces of mixins (issue 29767) 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3000183002 .
 2017-08-18 07:30:05 -07:00
Brian Wilkerson 1abf749b77 Fix more uses of generic method comments and increment the data version (TBR) 
Review-Url: https://codereview.chromium.org/2996653002 .
 2017-08-08 11:27:02 -07:00
Brian Wilkerson 8a275e6df8 Add utility method to SubscriptionManager 
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2983913002 .
 2017-07-21 07:24:55 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Konstantin Shcheglov 6323bedc58 Stop depending on LabelElement(s) to be reported in visitChildren(). 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2973093002 .
 2017-07-06 11:28:06 -07:00
Brian Wilkerson 4a10003924 Update the plugin API 
R=maxkim@google.com, mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2953093002 .
 2017-06-23 12:31:00 -07:00
Brian Wilkerson eafc070479 Remove ReplacementRange 
R=danrubel@google.com, maxkim@google.com

Review-Url: https://codereview.chromium.org/2946573003 .
 2017-06-19 10:15:36 -07:00
Max Kim 382ddb21c3 Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of test into lib/utilities and modified test path. 
This is needed to expose ReplacementRange outside of test folder for external plugin users to utilize. Reason discussed further in ticket: https://codereview.chromium.org/2934133002/

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2937093002 .
 2017-06-16 11:19:27 -07:00
Brian Wilkerson 0e6586492d Make common tests consistent 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2925273003 .
 2017-06-09 08:40:16 -07:00
Brian Wilkerson b9529da60e More test fixed (TBR) 
Review-Url: https://codereview.chromium.org/2925163002 .
 2017-06-07 14:04:29 -07:00
Brian Wilkerson dce88b45e7 Fix test tests under windows (TBR) 
Review-Url: https://codereview.chromium.org/2930723003 .
 2017-06-07 10:01:20 -07:00
Brian Wilkerson 8a724f7093 Port two completion contributors for use by plugins 
R=danrubel@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2927663002 .
 2017-06-07 09:14:49 -07:00
Brian Wilkerson 691cc1b57a Make navigation support consistent with completion support 
R=mfairhurst@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2919293002 .
 2017-06-05 12:33:20 -07:00
Brian Wilkerson 6bff3433b7 Add navigation support in plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2902193002 .
 2017-05-24 15:06:18 -07:00
Brian Wilkerson 3085734ef6 Generate common types into a separate library 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2880443006 .
 2017-05-13 08:12:14 -07:00
Brian Wilkerson 68b6f9b90d Fix bot failures (TBR) 
Review-Url: https://codereview.chromium.org/2869193002 .
 2017-05-09 13:51:54 -07:00
Brian Wilkerson a70e29ac60 Add support for converting elements to plugin API objects 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2873503007 .
 2017-05-09 13:02:31 -07:00
Brian Wilkerson 98e8f17b96 Convert server to use RangeFactory 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2869083002 .
 2017-05-09 10:08:14 -07:00
Brian Wilkerson bbb37dae8b Add support for creating source ranges 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2872813002 .
 2017-05-09 08:28:09 -07:00
Brian Wilkerson f05ecff43d Add more conversion utilities 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2867163002 .
 2017-05-08 13:40:58 -07:00
Brian Wilkerson 9ca84e15f4 Improve default support provided for plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2861373005 .
 2017-05-08 10:01:35 -07:00
Brian Wilkerson 91fede471f Re-organize and comment clean-up 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2846963004 .
 2017-04-28 09:09:59 -07:00
Brian Wilkerson 6ca3a29f2f Rename generated file 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2686933002 .
 2017-02-08 13:26:02 -08:00
Brian Wilkerson 81397c00aa Add top-level driver and abstract plugin superclass 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2667823003 .
 2017-01-31 13:41:56 -08:00