dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

251 Commits

Author SHA1 Message Date
Konstantin Shcheglov 623d2868a9 Reapply "Switch to the new analysis driver in analyzer_cli." 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2696083002 .
 2017-02-14 14:41:42 -08:00
Konstantin Shcheglov 25bc8ddd68 Fix for reporting not analyzed parts with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2695863003 .
 2017-02-14 14:18:03 -08:00
Konstantin Shcheglov e97042bec3 Revert "Switch to the new analysis driver in analyzer_cli." 
This reverts commit cda7520e5c.

There is a couple of integration tests for embedder analyzer_cli which
are failing, and I cannot find the solution quickly.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2695823005 .
 2017-02-14 12:35:46 -08:00
Konstantin Shcheglov cda7520e5c Switch to the new analysis driver in analyzer_cli. 
Our internal users use the new analysis driver, and we're enabling it
for everyone in 1.23, AFAIK.

We disable using the file system byte store during internal testing
because we don't want accidentally change analyzer code, run tests
and get all green only because we forgot to update DATA_VERSION.

R=brianwilkerson@google.com, whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2694083002 .
 2017-02-14 09:04:26 -08:00
danrubel 167107e94c fix dartanalyzer sdk setup 
Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.

Fix https://github.com/dart-lang/sdk/issues/28507

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2678633002 .
 2017-02-04 12:08:53 -05:00
Konstantin Shcheglov 39a5e660cd Call addFile() before getErrors() to actually get errors. 
With this change we have only 7 failing shared tests.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2662693002 .
 2017-01-27 15:11:09 -08:00
Konstantin Shcheglov 8cca41772d Implement AnalysisDriver.getSourceKind() and use it in analyzer-cli. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2658983004 .
 2017-01-27 14:29:44 -08:00
Konstantin Shcheglov 6bb8a923d3 Use AnalysisDriver.getErrors() to get cached errors for already analyzed files. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2656233004 .
 2017-01-27 13:26:45 -08:00
Konstantin Shcheglov a3cc5fe7f7 Implement using AnalysisDriver in analyzer_cli. Disabled. 
It's not ready to be enabled yet.

There are 11 failing tests in tests/language, and 174 in tests/co19.

It also works about 5 times slower.

But I'd like to land it to make parallel changes to AnalysisDriver and
analyzer_cli to make it pass more tests and be faster.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657903006 .
 2017-01-26 10:16:52 -08:00
Konstantin Shcheglov d142d80af7 Make analyzer_cli batch mode asynchronous. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2659463003 .
 2017-01-26 07:25:23 -08:00
Konstantin Shcheglov b206c84210 Reland c9e1b88 and 56726fc with a DDC fix. 
Revert "Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider.""

This reverts commit b701ad6453.

R=brianwilkerson@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2647323006 .
 2017-01-24 09:13:26 -08:00
Vijay Menon b701ad6453 Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider." 
This reverts commit c9e1b888a3.

Revert "Remove parent from SummaryResynthesizer."

This reverts commit 56726fcce0.

TBR=scheglov@google.com

Review-Url: https://codereview.chromium.org/2648213007 .
 2017-01-24 06:21:38 -08:00
Konstantin Shcheglov c9e1b888a3 Use single InputPackagesResultProvider, without SdkSummaryResultProvider. 
Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2652823002 .
 2017-01-23 16:54:17 -08:00
Dan Rubel 13bd1ad0bf DDC/AnalyzerCLI common cmdline option processing 
Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2584293003 .
 2016-12-19 16:24:20 -05:00
danrubel a105d89e2b refactor DDC and Analyzer CLI parser option declaration 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2580933002 .
 2016-12-15 14:10:09 -05:00
danrubel e321439470 cleanup Analyzer CLI and DDC arg parsing 
This removes the need to split arguments on '='
before calling the extractDefinedVariables method.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2581723002 .
 2016-12-15 12:16:20 -05:00
danrubel 5b84611856 refactor DDC to support --ignore-unrecognized-flags 
* add --ignore-unrecognized-flags to DDC
* refactor Analyzer CLI to use same filterUnknownArguments functionality
* remove now unused CommandLineParser and associated tests

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2578113002 .
 2016-12-15 10:46:09 -05:00
danrubel 2c62510f5f move CommandLineParser into analyzer for reuse by DDC 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2578733002 .
 2016-12-14 16:31:45 -05:00
danrubel 1417eec66e move extractDefinedVariables from analyzer cli to analyzer 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2571583007 .
 2016-12-14 13:22:41 -05:00
Dan Rubel 5aa30397d7 update DDC and analyzer cli preprocessArgs 
* refactor Analyzer CLI and DDC to use common preprocessArgs method
* throw clear exception if trailing @file not found or cannot be read
* update preprocessArgs method to always return new list

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2572813002 .
 2016-12-13 14:37:22 -05:00
Dan Rubel 665a12d1b5 add verbose option to show hidden options 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2570053002 .
 2016-12-13 11:17:23 -05:00
Brian Wilkerson 756cfc963d Fix warnings 
Review-Url: https://codereview.chromium.org/2564323002 .
 2016-12-11 16:53:13 -08:00
Brian Wilkerson 86c62a6bad Remove the command-line plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2565993002 .
 2016-12-11 10:59:19 -08:00
Brian Wilkerson a01afcd1d1 Remove the options plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569603002 .
 2016-12-11 08:38:29 -08:00
Brian Wilkerson ebf5fbcd0e Remove references to the linter plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2567863002 .
 2016-12-10 10:00:20 -08:00
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
 2016-12-07 10:51:33 -08:00
Brian Wilkerson 20baedc660 Reapply "Move the linter core to the analyzer package" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559773002 .
 2016-12-07 09:57:17 -08:00
Paul Berry 1a172e935b Revert "Move the linter core to the analyzer package" 
This reverts commit 6d9d5f53a1, which
was causing analysis server unit tests to fail.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2561573003 .
 2016-12-07 05:36:46 -08:00
Brian Wilkerson 6d9d5f53a1 Move the linter core to the analyzer package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2553203002 .
 2016-12-06 09:42:26 -08:00
Dan Rubel aff6b796f3 update analyzer cli to support include directive in analysis options file 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2541933002 .
 2016-11-30 15:16:55 -05:00
Brian Wilkerson 7e067a6fc8 Enable read-only access to initializing formals (issue 27895) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2532953004 .
 2016-11-29 07:46:28 -08:00
Brian Wilkerson 5b1236cfe7 Fix the setting of analysis options when there is an embedded SDK 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523313002 .
 2016-11-23 15:48:42 -08:00
Brian Wilkerson 96750cd5cb Split out options from ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2425423009 .
 2016-10-20 11:03:11 -07:00
Paul Berry 4b2bf4d6a0 Add an analysis option to disable cache flushing. 
This improves the analysis speed of large projects by as much as 20%.
It also can be used to work around cache flushing bugs.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2383203003 .
 2016-10-01 06:41:20 -07:00
Brian Wilkerson 685e4ff9e1 Revert "Remove unused option in server API" 
Review URL: https://codereview.chromium.org/2382033003 .
 2016-09-30 10:14:12 -07:00
Brian Wilkerson 2972bd0d6b Remove unused option in server API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2382053002 .
 2016-09-30 09:04:38 -07:00
Paul Berry 5d1dcde18c Revert "Issue 27375. Use ContextBuilder to find analysis options file in analyzer_cli." 
This broke the analyzer bots.  See for example: https://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux-release-be/builds/9135/steps/tests%20--host-checked%20--checked/logs/stdio

This reverts commit 75a4f968be.

TBR=scheglov@google.com

Review URL: https://codereview.chromium.org/2366913002 .
 2016-09-23 05:12:42 -07:00
Konstantin Shcheglov 75a4f968be Issue 27375. Use ContextBuilder to find analysis options file in analyzer_cli. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27375

Review URL: https://codereview.chromium.org/2355413005 .
 2016-09-22 15:11:15 -07:00
Konstantin Shcheglov 5703f5adb1 Replace using reprecated 'package:analyzer/src/generated/error.dart'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2364643002 .
 2016-09-22 10:10:53 -07:00
Paul Berry 2839653161 Fix generation of analysis results in analyzer_cli "build mode". 
This was inadvertently broken in 1b10de1a86.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2350963005 .
 2016-09-20 10:07:11 -07:00
Konstantin Shcheglov 979a9bd6da Remove incremental session from analyzer_cli. 
This should have been done together with 1310dc801a.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2348283004 .
 2016-09-19 15:06:03 -07:00
Konstantin Shcheglov 1387e8ec5c Remove fallback mode and corresponding cli flag. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2356523002 .
 2016-09-19 14:02:14 -07:00
Konstantin Shcheglov 1b10de1a86 Generate only AST based summaries in build mode. 
Should we also remove fallback mode?

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2355613003 .
 2016-09-19 13:47:38 -07:00
Paul Berry f7a12f9c83 Allow input summaries to be specified when running analyzer_cli in non-build mode. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2347133004 .
 2016-09-19 12:39:24 -07:00
Konstantin Shcheglov f5a616834e Use configurations and declared variables to select import/export URIs during prelinking. 
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27045

Review URL: https://codereview.chromium.org/2353433002 .
 2016-09-18 14:04:01 -07:00
Brian Wilkerson a5ee525e14 Add support for accessing field formal parameters in the initializer list of constructors 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2335693002 .
 2016-09-12 09:48:34 -07:00
Brian Wilkerson fa1b80fd82 Remove references to deprecated code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2331743002 .
 2016-09-10 11:28:43 -07:00
Brian Wilkerson 6c448b6938 Move exception support to its own library 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2328043002 .
 2016-09-10 11:04:19 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
 2016-09-09 09:09:59 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses" 
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
 2016-09-01 16:08:43 -07:00