dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

51 Commits

Author SHA1 Message Date
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson 602a8c2a7b Clean up usage of deprecated constants 
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-09 01:02:49 +00:00
Konstantin Shcheglov 5450d917fe Fix PhysicalResourceProvider tests on Windows. 
R=brianwilkerson@google.com

Bug:
Change-Id: I3665041840081e6d4889487249bf4b7d09be652b
Reviewed-on: https://dart-review.googlesource.com/7846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-22 21:20:14 +00:00
Konstantin Shcheglov 50c964b819 Add option for AnalysisDriver to use KernelDriver and KernelResynthesizer. 
Run NonErrorResolverTest_Driver tests with this option enabled.
We fail 163 out of 478 tests, or 35%.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Iac6154a14a1357fe239b0140f9f66de792825693
Reviewed-on: https://dart-review.googlesource.com/6340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-18 02:09:14 +00:00
Devon Carew 2b3b0272c4 Switch to using specific throws calls instead of general throwsA() calls. 
Bug:
Change-Id: Id604dca1b8c3060c1d12c9ed0b1493771d2eb0d6
Reviewed-on: https://dart-review.googlesource.com/5883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2017-09-14 18:04:44 +00:00
Brian Wilkerson f645c34bb0 Add support for copying directory structures 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2733053002 .
 2017-03-06 08:51:40 -08:00
Konstantin Shcheglov 891e709c5f Add File.lengthSync to use it for FileByteStore eviction. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2490023003 .
 2016-11-10 13:31:06 -08:00
Brian Wilkerson 1a893edb82 Add prefix to path import to work around breaking change 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2411423003 .
 2016-10-13 08:29:09 -07:00
Konstantin Shcheglov d4ebdabf43 MemoryResourceProvider.getFolder() should not create the folder. 
But newFolder() should be used to create.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2396423002 .
 2016-10-07 10:12:00 -07:00
Konstantin Shcheglov 175dad4f15 Switch 'analyzer' to 'package:test' and test_reflective_loader ^0.1.0. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2391423003 .
 2016-10-06 08:46:35 -07:00
Brian Wilkerson b83ca4f8dc Fix context comparisons 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2397813002 .
 2016-10-05 09:57:53 -07:00
Brian Wilkerson db73915c77 More fixes for testing under windows 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2393663002 .
 2016-10-04 13:11:57 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
 2016-09-09 09:09:59 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses" 
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
 2016-09-01 16:08:43 -07:00
Brian Wilkerson 2cdafd82c2 Remove unnecessary hide clauses 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2305453002 .
 2016-08-31 16:44:52 -07:00
Konstantin Shcheglov cc6beaf56d Pull in test_reflective_loader 0.0.4 and switch analyzer to it. 
There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2298913003 .
 2016-08-31 13:46:39 -07:00
Brian Wilkerson 3a6d80780b Add support for resolving symbolic links 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2270593003 .
 2016-08-23 09:39:48 -07:00
Brian Wilkerson 17ffa1e9c0 Add writeAsStringSync (issue 27109) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2265593002 .
 2016-08-19 12:17:13 -07:00
Konstantin Shcheglov 9f187f3df5 Normalize paths in PhysicalResourceProvider.getFile()/getFolder(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2239303004 .
 2016-08-12 11:04:02 -07:00
Brian Wilkerson c03b85d418 Add a toUri method to Resource 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2165843002 .
 2016-07-20 08:53:03 -07:00
Konstantin Shcheglov ed887c09d1 Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2132073003 .
 2016-07-08 15:01:05 -07:00
Jaime Wren 7f244c8d39 Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace the usages with ResourceUriResolver(PhysicalResourceProvider.INSTANCE). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2060263006 .
 2016-06-16 11:14:03 -07:00
Konstantin Shcheglov d2e3078321 Add Resource.delete() method. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2067613002 .
 2016-06-13 13:00:06 -07:00
Konstantin Shcheglov cb428694d3 Add Folder.getChildAssumingFile(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2058163002 .
 2016-06-10 10:37:43 -07:00
Paul Berry 9e52ab17e0 Consolidate duplicate code for resloving URIs. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1831133005 .
 2016-03-25 10:37:36 -07:00
Konstantin Shcheglov 561f6f5bed Add File.renameSync() to virtual file system. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1808213004 .
 2016-03-17 12:50:21 -07:00
Konstantin Shcheglov 45711829f6 Add File.readAsBytesSync/writeAsBytesSync() methods. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1811643002 .
 2016-03-16 11:21:59 -07:00
Brian Wilkerson f0d249e269 Clean up package imports and library names 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
 2015-12-10 08:11:56 -08:00
Konstantin Shcheglov f464e2eddb Use AbsolutePathContext in Folder.contains(). 
This makes MDL analysis about 5% faster, from 5900 samples to 5600 samples.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1444943003 .
 2015-11-15 09:33:16 -08:00
Konstantin Shcheglov ebdfa991d4 Issue 24538. Route SDK results into SDK context DartWorkManager. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24538

Review URL: https://codereview.chromium.org/1399873002 .
 2015-10-09 21:45:35 -07:00
Paul Berry 8f2ed2c68d Fix most implementations of UriResolver.restoreAbsolute. 
Although it wasn't previously clear in the documentation,
implementations of UriResolver.restoreAbsolute() should only depend on
Source.fullName.  To do otherwise breaks some assumptions made by
analysis server.  This CL fixes all implementations except
SdkExtUriResolver (which has been deferred to issue #24090).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1296653003 .
 2015-08-18 11:32:15 -07:00
Brian Wilkerson 6359735d93 Disable flaky test under Windows (and fix formatting from an earlier CL) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1287513002 .
 2015-08-10 13:32:07 -07:00
Brian Wilkerson fa80ca52e9 Revert a work-around that is now causing bot failures 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1282873002 .
 2015-08-10 12:06:27 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
danrubel 79db30d8d0 (TBR) patch test on Windows pending investigation 
dartbug.com/23762

Review URL: https://codereview.chromium.org//1219863004.
 2015-07-06 12:18:16 -04:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class. 
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
 2015-06-26 13:00:44 -07:00
Dan Rubel f550b8d76e add file watching support 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1191933004.
 2015-06-20 15:03:14 -04:00
scheglov@google.com 5432c74cd6 Add readAsStringSync() to File. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1007233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44506 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:01:52 +00:00
scheglov@google.com f0c4735db7 Convert file system tests into reflective. 
I need to add new tests... to add new methods... to fix issue 22757.
It's too hard to do now.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1000473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44389 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 00:03:01 +00:00
scheglov@google.com 339476c61f Wrap dart:io exception in getChildren(), implement for the memory FS. 
...for consistency.

Plus tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//989393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44358 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-10 04:30:56 +00:00
brianwilkerson@google.com 98b7382071 Reformat 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//975453004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44149 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 21:34:46 +00:00
paulberry@google.com 45b7294eff Don't do folder existence checks when parsing pub list results. 
It's just a waste of time since we already to folder existence checks
when resolving package URI's.  Besides, all the folders output by pub
list should always exist except in pathological situations.

Improves total analysis time by about 2%.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//952333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44137 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 18:28:22 +00:00
scheglov@google.com 279bdb7ec0 Add File.modificationStamp accessor. 
Dan, I noticed that you're using createSource().modification stamp to access this information.
So, we need a more direct way to get it.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//940313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43968 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-23 18:40:09 +00:00
paulberry@google.com 7b3b86c38e Fix flakiness in physical_resource_provider_test 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//840363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42751 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 19:20:53 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
scheglov@google.com 772a0c6b22 Fix 'Unused local variable' hints in analyzer and analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//709493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 18:32:54 +00:00
brianwilkerson@google.com 0a439dfc90 Add support for cross-session storage 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//632353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40962 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-07 16:58:18 +00:00
scheglov@google.com 4392cc42a0 Support for excluded files/folders. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//456893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39046 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-08 19:42:07 +00:00
scheglov@google.com 8b247578f1 Add Folder.contains(path) and use it in ContextDirectoryManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//444193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38958 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-06 22:25:04 +00:00
scheglov@google.com c5263aae9f Breaking changes in 'analyzer' package. 
1. Source.uri added.

2. DartSdk.fromEncoding() replaced with fromFileUri().

  This CL cannot be committed as is until pkg/code_transformers is fixed.

R=brianwilkerson@google.com, sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org//428303004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38949 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-06 20:41:42 +00:00