7b1edbbdf9
Issue 20144. Reset propagated type if one of the 'if' branches changes it to a different one.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20144
Review URL: https://codereview.chromium.org//1036233006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44754 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 19:13:50 +00:00
32688bf728
Fix the value of multiline strings. This re-applies the changes in 44722 (which was reverted in 44734) and fixes another bug that was uncovered by that change.
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1043473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44752 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 18:26:06 +00:00
281f305c90
Issue 22521. Drop '_J2DAccessor' suffixes.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22521
Review URL: https://codereview.chromium.org//1042453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44745 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 16:55:52 +00:00
87171553c9
Rename MethodInvocation.period to MethodInvocation.operator.
...
The name is inaccurate--if the method invocation is part of a cascade,
it is the ".." operator. It's going to get even more inaccurate when
null-aware operators are added, since it will also be used to
represent "?.".
Deprecated getters and setters named "period" are added to avoid
breaking the analyzer API.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1039713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44744 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 16:38:33 +00:00
3899dd2dcd
Issue 23010. Compute constant and report related errors during incremental resolution.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23010
Review URL: https://codereview.chromium.org//1037313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44743 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 16:29:03 +00:00
c95c8299bc
Fix NPE in ErrorReporter (issue 22980)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1040573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44739 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 15:40:04 +00:00
8982110eaf
Make some results private
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1034423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44738 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 15:37:01 +00:00
88380d5708
Revert "Fix value computation for multi-line strings (issue 22993)"
...
This reverts revision 44722
This is causing test failures:
http://build.chromium.org/p/client.dart/builders/pub-linux-be/builds/11761/steps/pub%20and%20pkg%20%20tests%20failures/logs/stdio
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1038353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44734 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 13:59:13 +00:00
ada62d06d1
Rewrite constants evaluation and checks to avoid using 'is double'.
...
We have 33 hints because of it.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1017573004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44724 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 22:45:18 +00:00
b073936fd0
Allow "dynamic" as a constant value in analyzer.
...
BUG=dartbug.com/22989
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1004353006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44723 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 21:50:44 +00:00
117ed251cc
Fix value computation for multi-line strings (issue 22993)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1034953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44722 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 21:45:31 +00:00
695b438019
Task: Resolve References.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1038963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44720 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 19:28:28 +00:00
dc0499d075
Task: Resolve Variables.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1031303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44710 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 14:01:31 +00:00
4b418376fe
BuildLibraryConstructorsTask to build all constructors of all library classes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1031283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44701 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 21:59:58 +00:00
c37839bab1
Extract _ListTaskInputMixin and allow chaining.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1007063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44698 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 21:23:22 +00:00
247b3edb06
Add toMap / toMapOf / toList
...
Rename 'inputOf' to 'of'.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1005693007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44690 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:54:17 +00:00
6cbfee9bf6
Move "null2" getter from ConstantVisitor to TypeProvider.
...
ConstantVisitor isn't a very long-lived object, and it's going to get
even shorter-lived in the new task model, so the caching is
ineffective. Moving the getter to the TypeProvider makes it easier to
get to and improves caching.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1036723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44684 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 15:33:05 +00:00
3e62e9ff67
Task: BuildClassConstructorsTask.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1029953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44675 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 21:20:15 +00:00
3d8bd5fcb6
Add UNITS and CLASS_ELEMENTS results.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1034493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44673 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 18:47:22 +00:00
0491a6ff6b
More comment clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1021723008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44670 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 16:06:20 +00:00
cc1eaee4e2
Issue 22962. Adding/removing method/accessor body is a declartion mismatch.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22962
Review URL: https://codereview.chromium.org//1024553006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44667 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 14:52:35 +00:00
79af2ba662
Fix constant evaluation of division.
...
To be consistent with the VM and dart2js implementations, the
analyzer's constant evaluation of a / b should always yield a double,
even if the arguments are ints. For example, 300 / 2 = 150.0 and 301
/ 2 = 150.5.
BUG=dartbug.com/22937
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1027453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44645 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 19:36:37 +00:00
5c9110841e
Fix hints in the analyzer package.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1026093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44639 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 17:34:00 +00:00
85db3fbe62
Report separate UNUSED_CATCH_CLAUSE and UNUSED_CATCH_STACK hints.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//1020243004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44635 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 16:41:20 +00:00
e568512534
Rename parameters in error_verifier
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1027693005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44633 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 15:12:39 +00:00
03cac10578
improve parser recovery of type argument list
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//1025903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44626 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-22 18:33:23 +00:00
f2df67f2fe
ResolveLibraryTypeNamesTask to force type name resolution in parts.
...
Also clean ups in other tasks inputs.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1024973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44623 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-21 01:08:20 +00:00
c2231e5f08
Clean up comments in error verifier
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1021083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44619 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 23:02:52 +00:00
c16fc96d58
Implement the new definition of flatten() from r44569 in analyzer.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1023903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44603 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 13:29:05 +00:00
56ff9d92e7
Add engine plugin
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1026483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44589 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 20:08:05 +00:00
3b8c23ce58
Fix static type analysis of function invocation expressions.
...
BUG=dartbug.com/22916
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1021773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44588 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:39:20 +00:00
b36c00f15f
Temporarily move plugin support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1027433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44586 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:06:22 +00:00
39c3a6c255
Issue 22886. Quick fixes create getter' and 'create field' for hints.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22886
Review URL: https://codereview.chromium.org//1024573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44585 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:16:04 +00:00
505b83a377
Rewrite ImplicitConstructorBuilder to use only element model.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1022843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44583 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:11:33 +00:00
e9dfd7e3b1
Clean up comments in element_resolver
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1019643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44574 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 14:41:57 +00:00
abaf8171cc
Task: Resolve Type Names.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1023503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44566 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 21:50:43 +00:00
10a83e55c4
Task: Build Type Aliases.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44565 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 20:49:26 +00:00
47d33ecd72
Add public and export namespaces to LibraryElement.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1023443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44563 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 19:25:51 +00:00
8fba9fa5a4
Task: Create Export Namespace.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1017743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44545 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 22:22:27 +00:00
a151c5d495
Move PublicNamespaceBuilder into tasks.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1002393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44543 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 20:47:09 +00:00
fe5c9fdfd5
fix for getting node for class element
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1007563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44539 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 17:00:05 +00:00
80913d8fa0
Clean up comments in constants.dart
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1017633003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44536 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 15:30:15 +00:00
c6a760de66
Task: Build Export Source Closure.
...
It's result will be used later to compute EXPORT_NAMESPACE for each library.
One of the inputs of the task computing EXPORT_NAMESPACE is a map of each source from EXPORT_SOURCE_CLOSURE to its PUBLIC_NAMESPACE.
It will require also changes to NamespaceBuilder to replace direct
AnalysisContext.getPublicNamespace(LibraryElement) with an externally provided function.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44535 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 14:54:01 +00:00
1ff4ead0f6
Rename ContributionPoint
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1012993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44534 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 14:52:45 +00:00
2c7348f585
Use PUBLIC_NAMESPACE for computing TypeProvider.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1013973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44533 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 13:56:33 +00:00
8910e64632
Start analyzing LibraryUnitTarget(s) from BuildLibraryElementTask.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1018443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44529 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 23:39:48 +00:00
aea99bdfa1
Remove the old formatter from analyzer.
...
BUG=https://code.google.com/p/dart/issues/detail?id=22401
R=brianwilkerson@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org//1001403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44522 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 20:03:33 +00:00
970cff5002
Fix ErrorProperty enum.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1010873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44512 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 18:14:39 +00:00
ef2a41217d
Add NOT_INITIALIZED_FIELDS property for FINAL_NOT_INITIALIZED_CONSTRUCTOR_X.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1004793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44511 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 17:49:19 +00:00
dfb5713b95
Include the common library name used in 'part of' directives.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44496 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 23:38:31 +00:00
scheglov@google.com