dd451d1424
Move DartWorkManager notification to _sourceChanged().
...
This fixes scheduling analysis after overlay changes.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1126233008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45797 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 21:51:38 +00:00
80e7ee46a6
In the new task model, use explicit dependencies on the type provider.
...
Previously, some of the tasks got the type provider from the context,
which meant we were at risk of invoking the task manager reentrantly
(which might have broken some task manager assumptions and potentially
degraded responsiveness). With this CL, all tasks that need the type
provider get it using an explicit input.
Assertions are added so that if we accidentally introduce future code
paths that invoke the task manager in a reentrant fashion, we will see
the problem during unit tests.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1124003007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45794 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 19:49:32 +00:00
4b942318c9
Don't invalidate dependent results when set values.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133863006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45793 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 19:45:39 +00:00
47534318f6
Fix for invalidating results of a target being removed.
...
Tweaks for tests.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1140943005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45785 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 14:33:08 +00:00
f01c1490f7
Revert 45783
...
BUG=
Review URL: https://codereview.chromium.org//1138993005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45784 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 00:32:32 +00:00
95515238cc
Move 'dart:profiler' contents into 'dart:developer' and remove 'dart:profiler'
...
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//1139503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45783 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 23:48:04 +00:00
9baa563923
Fix for using the deprecated AnalysisError constructor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1131383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45780 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 20:52:33 +00:00
6c66bbac50
Return empty contents for not existing sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1127403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45778 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 20:51:04 +00:00
13af577c37
Rename CONSTANT_RESOLVED_UNIT to RESOLVED_UNIT.
...
And move the old RESOLVED_UNIT out of the public API and rename it to
RESOLVED_UNIT6.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1138853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45777 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 20:41:10 +00:00
d9555d7005
Fix for creating the correct SdkAnalysisContext.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1139463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45772 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 19:45:51 +00:00
9741a34885
Move getErrors() to DartWorkManager, report errors in ChangeNotice(s).
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1134873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45766 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 16:28:20 +00:00
6e25226a0d
Issue 23444. Use ConstructorMember(s) for super constructor fixes.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23444
Review URL: https://codereview.chromium.org//1140963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45765 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 16:13:09 +00:00
dfd26c038b
Create ChangeNotice(s) and set parsed/resolved units.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1138853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45736 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 13:52:20 +00:00
e6b4fbd402
Validate modifications times only for sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1130423003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45724 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 01:50:13 +00:00
0bb38ab8b9
Prioritize scheduling analysis for priority sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1136543006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45722 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 00:29:15 +00:00
130376558f
Add a task for computing all constant values in a compilation unit.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1137873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45719 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 22:18:02 +00:00
7bcc0c21f9
Remove unused DartWorkManager.librarySources/partSources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1128853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45717 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 20:52:26 +00:00
f7e242ae1b
Remove the 'cache' prefix by hiding the conflicting entities from engine.dart
...
I think it would be nice to prioritize the new stuff by making it easy to reference :-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133673007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45716 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 20:37:46 +00:00
867bea557a
Remove some unused AnalysisContextImpl methods.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45714 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:42:11 +00:00
0e4d3d0190
Unify evaluation of annotations with evaluation of other constants.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1134133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45713 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:35:26 +00:00
270980e22a
Add AnalysisCache.getState() and getValue().
...
There is a small functionality change, I think a valid one.
We don't check is the value is valid, we ask the CacheEntry, which updates the flush manager.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1139643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45710 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:26:20 +00:00
c2de14f6c5
Implement AnalysisContext.ensureResolvedDartUnits().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1132423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45707 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 18:49:03 +00:00
ade0f154f5
(Was: Linter analysis plugin.)
...
FWIW: Lint rule plugins are moving to their (rightful) home in the linter proper.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1134823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45698 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 17:43:44 +00:00
6bc350e543
After every change iterate over the cache to find invalidated libraries and reschedule them.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45696 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 16:59:31 +00:00
b6bccf200d
Use WorkManager(s) in AnalysisDriver.
...
Install DartWorkManager in AnalysisContextImpl.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1131673004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45690 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 15:16:19 +00:00
88973df145
Add DartWorkManager to manage Dart-specific results computation scheduling.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1132893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45677 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-09 23:22:21 +00:00
81e474c43e
Clean up many generated constructors
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1131423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45676 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-09 19:06:12 +00:00
b901fbcf95
Add a "librarySource" field to CompilationUnitElementImpl.
...
This fixes a dependency problem in ComputeConstantDependenciesTask.
Prevously it used element.library.source to get access to the library
source, but this created an implicit dependency on LIBRARY_ELEMENT1
(since element.library is null if the library element hasn't been
built yet). There was no way to make that dependency explicit since
previous to this change, the CompilationUnitElement did not store
enough information to determine what library it was part of until
after the library element had been created.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1125123006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45674 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-09 01:19:17 +00:00
73f176d45e
Add LIBRARY_ERRORS result.
...
This result will work as a top-level target for Dart work manager.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45668 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 23:11:13 +00:00
d14e5042bb
Removed CLASS_ELEMENTS from BuildCompilationUnitElementTask and cleaned up comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1139473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45661 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 21:39:59 +00:00
8dcf63f9b1
Move CONSTANT_DEPENDENCIES out of the analyzer public API.
...
Exposing this through the public API was a mistake. There is no
reason why clients (or plug-ins) should need to access this
intermediate result directly.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1127423005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45653 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 20:07:33 +00:00
e51ffadb87
Add a task to the new task model for computing constant values.
...
Not yet implemented: proper handling of circular references.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1125423004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45651 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 19:44:41 +00:00
262ba21fef
When a target is removed, invalidate all dependent results.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1129033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45650 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 19:27:39 +00:00
bd51645937
Automatically remove empty entries from the cache.
...
Now we use Element(s) and other "big" structures as keys.
So, now we need a mechanism to remove entries with their keys altogether,
not just removing associated data.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45648 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 16:59:09 +00:00
2d41ec2079
Remove memento.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1132103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45645 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 15:11:47 +00:00
728e9b3a9e
Create a task in the new task model to compute constant dependencies.
...
This is the first of several planned tasks for constant evaluation.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1131953004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45624 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 00:36:45 +00:00
ed28cd5969
Progress toward new AnalysisContextImpl
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1136673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45623 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 23:19:46 +00:00
194d48f9da
Set CacheEntry.target in the contructor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1135613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45619 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 21:04:51 +00:00
47df8674d1
Remove unused AnalysisContextImpl.findElementById().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1132623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45618 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 21:02:23 +00:00
61a371476b
Remove unused InternalAnalysisContext.addSourceInfo().
...
The analysis cache is now accessible, if we will ever need this feature again.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1131063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45616 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:17:13 +00:00
1ccf10f617
Some clean ups for cache partitions.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1130263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45615 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:15:49 +00:00
9414515ba7
Remove CompositeResultDescriptor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1136603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45613 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:00:49 +00:00
7040257579
Store elements in the constant eval dependency graph rather than AST nodes.
...
This paves the way for constant evaluation to be integrated into the
new task model, since the new tasks for constants will use elements as
their targets.
Since the element model makes a distinction between constructor
members and constructor elements, we have to be careful to be
consistent about what kinds of elements are stored in the dependency
graph. We always store constructor elements in the dependency graph.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1129143003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45611 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:38:37 +00:00
1bc667b086
Flush memento objects.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1129173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45610 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:36:04 +00:00
9aeccc0d2f
Get AnalysisCache from InternalAnalysisContext.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1124113004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45609 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:12:42 +00:00
11f96844dc
When invalidate because of the ERROR state, propagate its exception.
...
I have to move invalidation implementation into CacheEntry, because we need to set the "exception" field value.
Should we also move "setDependedOnResults" and make ResultData a dumb data container?
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1126793004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45608 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:10:27 +00:00
965ac274f6
Clean-up result descriptors
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1131983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45607 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:10:14 +00:00
4f04a6cf2e
Don't update offsets for elements of 'part' and 'part of' directives.
...
These elements are not defined in the source that references it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1131053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45605 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 18:34:19 +00:00
e8c5b87478
Get computeError working
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1130763003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45604 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 18:30:40 +00:00
a3366361de
Cache flushing implementation for the task model.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1133513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45597 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 15:50:13 +00:00
scheglov@google.com