dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

26 Commits

Author SHA1 Message Date
Brian Wilkerson b936ffb329 Move several libraries out of the public API 
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-17 17:35:27 +00:00
Brian Wilkerson 26c06cdd82 Clean up Dart 2 type issues related to YAML support 
Change-Id: Ic29054afca9773286aa899eecede287f7ecbca9a
Reviewed-on: https://dart-review.googlesource.com/47680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-22 17:06:40 +00:00
Brian Wilkerson 1560f19844 Fixes to make analyzer preview-dart-2 safe, part 1 of many 
Change-Id: I8f88168a1fab61b3d0d808b5d9e09e6391325302
Reviewed-on: https://dart-review.googlesource.com/46953
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 13:15:46 +00:00
Konstantin Shcheglov 5cd77dda37 AnalysisOptionsProvider.getOptionsFile() should return only existing files. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review-Url: https://codereview.chromium.org/2981553002 .
 2017-07-11 13:38:08 -07:00
Brian Wilkerson 24996fbfe7 Add support to pass the location of the analysis options file to plugins 
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2947743002 .
 2017-06-20 07:41:03 -07:00
Dan Rubel 0d15f1d892 report errors in included options files 
Example error messages include:
/analysis_options.yaml(10..27): The include file other_options.yaml in /analysis_options.yaml cannot be found.
/analysis_options.yaml(10..27): Bad options file format (expected String scope key, got YamlScalar) in /other_options.yaml(0..0)
/analysis_options.yaml(10..27): Warning in the included options file /other_options.yaml(47..49): The option 'ftw' isn't supported by 'errors'.

Since the included options file may not be part of the project,
the error is reported on the initial include statement
and includes the needed location information for the user to track down the problem.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2502233004 .
 2016-11-17 14:43:05 -05:00
danrubel 68ba3cfe51 work in progress - support analysis options include declaration 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2489973002 .
 2016-11-14 15:12:03 -05:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
 2016-09-09 09:09:59 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses" 
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
 2016-09-01 16:08:43 -07:00
Brian Wilkerson 2cdafd82c2 Remove unnecessary hide clauses 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2305453002 .
 2016-08-31 16:44:52 -07:00
pq c07b21d03b Dangling comment reference cleanup in analyzer. 
First pass with the new `comment_reference` lint.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1994243002 .
 2016-05-19 10:24:53 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
 2016-05-13 07:33:06 -07:00
Brian Wilkerson 24d23680d1 Use null-aware operators to clean up the code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1933763002 .
 2016-04-29 08:48:12 -07:00
Brian Wilkerson cda79ce966 Remove unnecessary casts and general code clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1918923003 .
 2016-04-25 12:24:34 -07:00
Konstantin Shcheglov d097a6e1cd Allow Analysis Server crawl up the folders to search .analysis_options file. 
R=brianwilkerson@google.com, jwren@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1832643002 .
 2016-03-23 17:09:48 -07:00
Brian Wilkerson 5309d86424 First batch of changes to make analyzer package strong mode error free 
Review URL: https://codereview.chromium.org/1808123005 .
 2016-03-18 07:47:58 -07:00
Brian Wilkerson f0d249e269 Clean up package imports and library names 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
 2015-12-10 08:11:56 -08:00
pq b0a08827aa Improves options validation type safety (#24885). 
Fixes #24885.

https://github.com/dart-lang/sdk/issues/24885

BUG=24885
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1437703003 .
 2015-11-12 09:44:25 -08:00
pq 67dc108f39 Map merging. 
Basic YAML map merging suitable for merging a default map with an overriding one.

The semantics favor the overrider with a twist to support a short-hand for lists that stand-in for maps of scalars to booleans.  Specifically, lint rules can be enumerated as a list or as a map.  To make this work, lists can be "promoted" to maps.  In particular, if

linter:
  rules:
    - camel_case_types
    - one_member_abstracts

is merged with

linter:
  rules:
    one_member_abstracts: false
    always_specify_return_types: true

the right thing is done to get us to:

linter:
  rules:
    camel_case_types: true
    one_member_abstracts: false
    always_specify_return_types: true

R=brianwilkerson@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1425393002 .
 2015-11-03 10:42:18 -08:00
pq ffeacec73d Improved YAML doc exception handling. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1415153004 .
 2015-10-28 11:24:42 -07:00
pq 6c85fe785a Analysis Options error notifications. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411013003 .
 2015-10-21 09:59:19 -07:00
pq bf0ba96027 Analysis Options processing task and manager. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1413973003 .
 2015-10-20 15:38:55 -07:00
pq 140a4f5891 Register .analysis_options files for analysis. 
Some oportunistic constant cleanup as well (follow-up from: https://codereview.chromium.org/1399893004/).

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1412213003 .
 2015-10-19 09:46:54 -07:00
John McCutchan 9535715f92 Fix handling of empty .analysis_options files and test this case 
Fixes #24431

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1369573003 .
 2015-09-24 12:38:53 -07:00
John McCutchan 977d213344 Refactor AnalysisOptionsProvider 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1245513002 .
 2015-07-17 15:17:40 -07:00
John McCutchan 4bf66ce912 Add an AnalysisOptionsProvider to analyzer 
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1231633011 .
 2015-07-17 13:34:03 -07:00